Moodle

wrong answer choices pulled from short answer questions into random matching

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.3
  • Fix Version/s: None
  • Component/s: Quiz
  • Labels:
    None
  • Environment:
    All
  • Affected Branches:
    MOODLE_13_STABLE

Description

I entered two possible answers in the short-answer questions which were to be used in a random matching question. One of the possible answers was worth 100% and the other was only partially correct (50% or less). However, only the partially-correct answers were used in the drop-down list in the random matching question. Obviously, the ones which should have been used are those worth 100%.

Plus: if there are more than one fully-correct answer (100%) in the short-answer questions, I believe both answers should be included in the drop-down list of the random matching question.

Activity

Hide
Martin Dougiamas added a comment -

From Martin Dougiamas (martin at moodle.com) Tuesday, 25 March 2003, 04:35 PM:

There is code in there already that is supposed to pick the highest scoring answer - I'm not sure yet why it didn't work in this case.

From P. S. (p_stencel at wp.pl) Tuesday, 25 March 2003, 04:49 PM:

Actually, it always pulled the lowest-grade answers. I didn't experiment with many different cases, though.

From Bernard Boucher (bernard.boucher at cjonquiere.qc.ca) Sunday, 16 May 2004, 08:25 AM:

real bug

Missing line in moodle/mod/quiz/lib.php around 872

$bestfraction = $questionanswer->fraction;

foreach ($questionanswers as $questionanswer) {

if ($questionanswer->fraction > $bestfraction) { $bestanswer = $questionanswer; $bestfraction = $questionanswer->fraction; }

}

Without that line the last graded answer was always choosen.

Bernard

From Martin Dougiamas (martin at moodle.com) Wednesday, 19 May 2004, 10:53 AM:

Thanks, Bernard - checked in.

From Martin Dougiamas (martin at moodle.com) Wednesday, 19 May 2004, 10:53 AM:

Nice job, BTW!

Show
Martin Dougiamas added a comment - From Martin Dougiamas (martin at moodle.com) Tuesday, 25 March 2003, 04:35 PM: There is code in there already that is supposed to pick the highest scoring answer - I'm not sure yet why it didn't work in this case. From P. S. (p_stencel at wp.pl) Tuesday, 25 March 2003, 04:49 PM: Actually, it always pulled the lowest-grade answers. I didn't experiment with many different cases, though. From Bernard Boucher (bernard.boucher at cjonquiere.qc.ca) Sunday, 16 May 2004, 08:25 AM: real bug Missing line in moodle/mod/quiz/lib.php around 872 $bestfraction = $questionanswer->fraction; foreach ($questionanswers as $questionanswer) { if ($questionanswer->fraction > $bestfraction) { $bestanswer = $questionanswer; $bestfraction = $questionanswer->fraction; } } Without that line the last graded answer was always choosen. Bernard From Martin Dougiamas (martin at moodle.com) Wednesday, 19 May 2004, 10:53 AM: Thanks, Bernard - checked in. From Martin Dougiamas (martin at moodle.com) Wednesday, 19 May 2004, 10:53 AM: Nice job, BTW!
Hide
Michael Blake added a comment -

Temp reopen to assign to a valid user BBoucher

Show
Michael Blake added a comment - Temp reopen to assign to a valid user BBoucher
Hide
Michael Blake added a comment -

Reassigning to a valid user.

Show
Michael Blake added a comment - Reassigning to a valid user.

People

Dates

  • Created:
    Updated:
    Resolved: