Moodle

Calendar CSS in standard theme has many !important declarations

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Trivial Trivial
  • Resolution: Unresolved
  • Affects Version/s: 1.5
  • Fix Version/s: None
  • Component/s: Themes
  • Labels:
    None
  • Environment:
    All
  • Affected Branches:
    MOODLE_15_STABLE

Description

The CSS in the standard theme has many !important declarations, particularly for Calendar. The !important declaration means that CSS further down the cascade (e.g. themes based on the standard theme, user style sheets specified in browsers) can't override these declarations unless they themselves are also declared !important.

I'm guessing there was a reason to add these in the first place (maybe to override styles encoded in the HTML?). If that reason is still valid then that original problem should be fixed, if it is already fixed and the !important declarations are uneccesary then I'd prefer if they were taken out.

Activity

Hide
Martin Dougiamas added a comment -

From Urs Hunkler (u.hunkler at elearningkontor.de) Friday, 15 July 2005, 04:50 AM:

Hi Jon, will you please look if you can find some time to look if your !important marks are still neccessary? Would be really great.

Show
Martin Dougiamas added a comment - From Urs Hunkler (u.hunkler at elearningkontor.de) Friday, 15 July 2005, 04:50 AM: Hi Jon, will you please look if you can find some time to look if your !important marks are still neccessary? Would be really great.
Hide
Matt Gibson added a comment -

This is causing it to be impossible to change many of the calendar colours with chameleon. I'm experimenting, but having trouble - I don't want to break standardwhite in order to make my theme work.

Matt

Show
Matt Gibson added a comment - This is causing it to be impossible to change many of the calendar colours with chameleon. I'm experimenting, but having trouble - I don't want to break standardwhite in order to make my theme work. Matt
Hide
Matt Gibson added a comment -

specifically, shift-clicking on coloured boxes showing the key for different events on the main calendar screen.

Show
Matt Gibson added a comment - specifically, shift-clicking on coloured boxes showing the key for different events on the main calendar screen.
Hide
Urs Hunkler added a comment -

Still quite annoying.

Show
Urs Hunkler added a comment - Still quite annoying.

People

Vote (1)
Watch (0)

Dates

  • Created:
    Updated: