Details
-
Type:
New Feature
-
Status:
Open
-
Priority:
Major
-
Resolution: Unresolved
-
Affects Version/s: 1.5, 1.6.9, 1.7.7, 1.8.8, 1.9.4
-
Fix Version/s: None
-
Labels:None
-
Environment:All
-
Affected Branches:MOODLE_15_STABLE, MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
Description
The $menu variable in the themes header.html does too many things.
On the front page of your Moodle it tells you who you are logged in as as well as allowing you to choose a language (as long as that option is switched on)
On Course index pages it only tells you if you are logged in.
On Resource pages it gives you a button for viewing logs (again, only if switched on), a jump menu, and a previous and next button.
All of these things are pretty cool, but it's a bit of straightjacket that you can only specify them to be in one place and, by extension surround them with a single bit of HTML and CSS style.
You may well want all of the above to appear but in different places and styled differently. Or you may only want some elements e.g. the jump menu without the backwards and forwards arrows.
Attachments
Issue Links
| This issue has a non-specific relationship to: | ||||
| MDLSITE-719 | Modules and Plugins database: selecting language produces data error |
|
|
|
From Urs Hunkler (u.hunkler at elearningkontor.de) Friday, 15 July 2005, 04:39 AM:
Martin, David made a good proposal. What do you think? Can you divide the different functions?
From Martin Dougiamas (martin at moodle.com) Friday, 15 July 2005, 11:54 AM:
I'm very aware of the problem and I totally agree, but it's a legacy problem that will require a lot of changes around Moodle (in many print_header calls) ... we probably should have tackled it in 1.5 but we didn't ...
To start with can you look at it from a CSS point of view and come up with a good naming scheme for all these bits and pieces?