Moodle

Custom Icons are not used when viewing activity reports

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Duplicate
  • Affects Version/s: 1.5.2
  • Fix Version/s: None
  • Component/s: Themes
  • Labels:
    None
  • Environment:
    All

Description

If you have selected a custom iconset, these icons are not used on the activity reports pages. Instead the default moodle icons are displayed.

A possible fix can be made by editing a couple of places in http://moodle.cvs.sourceforge.net/moodle/moodle/course/user.php

first, by changing the print_outline_row function as follows

function print_outline_row($mod, $instance, $result) {

global $CFG, $THEME;

if ($THEME->custompix) { $image = <img src=\$CFG->pixpath/mod/$mod->modname/icon.gif\ height=\16\ width=\16\ alt=\$mod->modfullname\ />; } else { $image = <img src=\../mod/$mod->modname/icon.gif\ height=\16\ width=\16\ alt=\$mod->modfullname\ />; }

// snip! the rest of the function is unmodified

and then a similar change (at approx line 140)

if (function_exists($user_complete)) {

if ($THEME->custompix) { $image = <img src=\$CFG->pixpath/mod/$mod->modname/icon.gif\ ; } else { $image = <img src=\../mod/$mod->modname/icon.gif\ ; }

$image .= height=\16\ width=\16\ alt=\$mod->modfullname\ />;

echo <h4>$image $mod->modfullname: .

<a href=\$CFG->wwwroot/mod/$mod->modname/view.php?id=$mod->id\>.

format_string($instance->name,true).</a></h4>;

echo <ul>;

$user_complete($course, $user, $mod, $instance);

echo </ul>;

}

Activity

Hide
Martin Dougiamas added a comment -

From Urs Hunkler (u.hunkler at elearningkontor.de) Tuesday, 2 August 2005, 05:38 PM:

Martin, this is one for you I think.

From Urs Hunkler (u.hunkler at elearningkontor.de) Sunday, 11 September 2005, 04:14 AM:

see MDL-4051

Show
Martin Dougiamas added a comment - From Urs Hunkler (u.hunkler at elearningkontor.de) Tuesday, 2 August 2005, 05:38 PM: Martin, this is one for you I think. From Urs Hunkler (u.hunkler at elearningkontor.de) Sunday, 11 September 2005, 04:14 AM: see MDL-4051

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: