Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 1.5.2
-
Fix Version/s: None
-
Component/s: Quiz
-
Labels:None
-
Environment:Windows XP
-
Database:MySQL
-
Affected Branches:MOODLE_15_STABLE
Description
There are 3 options for displaying highlights on the correct answers during student review: Immediately, Later, and After Closing. Immediately works correctly, but Later and/or After Closing fail to display highlights. Have tested on production site (1.5.2+ 20July05) and localhost site (1.5.2+ 8Aug05), using real student data and test data. Used Standard and StandardWhite themes. Note that while correct answer highlights don't show, highlight over score on high-score attempt is highlighted correctly. Also, changing option to Immediately produces correct highlights in student review.
From Julian Sedding (jps502 at york.ac.uk) Monday, 15 August 2005, 11:26 PM:
This is fixed now in CVS. The function quiz_get_reviewoptions had two slight errors. Where the value of $options->correct_responses was determined for open and closed quizzes their value was determined using the constant QUIZ_REVIEW_IMMEDIATELY instead of QUIZ_REVIEW_OPEN and QUIZ_REVIEW_CLOSED respectively. It's quite plausible that this lead to the observed bug when the answers checkbox for 'Immediately' was unchecked.
From James Robertson (jimrprovo at gmail.com) Tuesday, 16 August 2005, 02:55 AM:
After updating I found that LATER option worked but AFTER CLOSING still did not. Checking the code, in the last part of the conditional QUIZ_REVIEW_OPEN needed to be changed to QUIZ_REVIEW_CLOSED. Changed my copy (attached) and it seems to work correctly. Please check and update CVS version.
From Julian Sedding (jps502 at york.ac.uk) Tuesday, 16 August 2005, 08:51 PM:
I comitted Jim's fix.