Moodle

The course/user/outlinereport page does not show the custom icons

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Cannot Reproduce
  • Affects Version/s: 1.5.2
  • Fix Version/s: None
  • Component/s: Course
  • Labels:
    None
  • Environment:
    All
  • Affected Branches:
    MOODLE_15_STABLE

Description

the path to the images is hardcoded:

<img src=\../mod/$mod->modname/icon.gif\

in:

/moodle/course/

_ grade.php

_ grades.php

_ outline_rep.php

_ user.php

Activity

Hide
Martin Dougiamas added a comment -

From Urs Hunkler (u.hunkler at elearningkontor.de) Sunday, 11 September 2005, 04:13 AM:

this is a follow up to MDL-3844.

From David Scotson (d.scotson at admin.gla.ac.uk) Friday, 7 July 2006, 06:34 PM:

two other similar items:

  • the printer icon (print.gif) used in the glossary module is similarly hardcoded and should also be changed to use $modpixpath
  • the smiley images used in the help/javascript-inserter for those with the HTML editor turned off don't match those in an alternate icon theme since the help files are pure HTML and so are necessarily hardcoded (the help for the HTML editor is a PHP page and so it works as expected). I'm not sure if this is fixible in the same way, perhaps it needs re-classified from a translatable help HTML file to a standard Moodle PHP page that pulls in just the language strings.
Show
Martin Dougiamas added a comment - From Urs Hunkler (u.hunkler at elearningkontor.de) Sunday, 11 September 2005, 04:13 AM: this is a follow up to MDL-3844. From David Scotson (d.scotson at admin.gla.ac.uk) Friday, 7 July 2006, 06:34 PM: two other similar items:
  • the printer icon (print.gif) used in the glossary module is similarly hardcoded and should also be changed to use $modpixpath
  • the smiley images used in the help/javascript-inserter for those with the HTML editor turned off don't match those in an alternate icon theme since the help files are pure HTML and so are necessarily hardcoded (the help for the HTML editor is a PHP page and so it works as expected). I'm not sure if this is fixible in the same way, perhaps it needs re-classified from a translatable help HTML file to a standard Moodle PHP page that pulls in just the language strings.
Hide
Dan Marsden added a comment -

looks like this was resolved ages ago - just did a quick search and couldn't find any instances where the icon was still hardcoded - if not feel free to open a new tracker issue with the specifics!

thanks!

Show
Dan Marsden added a comment - looks like this was resolved ages ago - just did a quick search and couldn't find any instances where the icon was still hardcoded - if not feel free to open a new tracker issue with the specifics! thanks!

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: