Issue Details (XML | Word | Printable)

Key: MDL-4395
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Trivial Trivial
Assignee: Martin Dougiamas
Reporter: Samuli Karevaara
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Remove the Book module language files from the main CVS

Created: 28/Nov/05 09:38 PM   Updated: 17/Aug/07 04:15 AM
Return to search
Component/s: Languages
Affects Version/s: 1.6
Fix Version/s: None

Environment: All
Issue Links:
Cloners
 

Participants: Martin Dougiamas, Michael Blake and Samuli Karevaara
Security Level: None
Affected Branches: MOODLE_16_STABLE


 Description  « Hide
As the Book module is not in the standard distro, I think the corresponding language files should be removed from the main CVS. They (should be / are) included in the Book module itself, under the Book module folder.



Offending languages include:

ar, bs, ca, de, es, eu, ja, ja_utf8, ko, ko_utf8, lv, ru, sv, th, vi_utf8.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Martin Dougiamas added a comment - 15/Aug/06 08:50 PM
From oen roggemans (koen at roggemans.net) Monday, 28 November 2005, 11:58 PM:

I can agree with that. There are a lot of modules not belonging but checked in in different language packs.

I've once (too long ago) created a list. It's may be time to pick it back up and do some cleaning.

Also the en package is not free of sins. What does eg the webquest.php file in there? I believe it was there already when I moved in with moodle 1.0.8...

From Samuli Karevaara (samuli.karevaara at lamk.fi) Tuesday, 29 November 2005, 02:03 AM:

Some odd loose files are probably not a big problem, but with later updates there might two versions of the same file, in the general /lang/ and under the module. Also, it is confusing when doing merging to custom branches and similar diffing, noticing that there are changes like this (I cleaned the Book files thinking that they came with an earlier Book module, and only now found out that they came with the main distro).

From oen roggemans (koen at roggemans.net) Sunday, 4 December 2005, 09:13 PM:

I suggested Martin to delete the underlined from the en langpack and make all other langpacks the same. Waiting for confirm

activitynames.php

admin.php

algebra.php

appointment.php

assignment.php

attendance.php

auth.php

block_course_list.php

block_course_summary.php

block_glossary_random.php

block_html.php

block_loancalc.php

block_online_users.php

block_quiz_results.php

block_rss_client.php

block_search_forums.php

block_section_links.php

block_social_activities.php

calendar.php

censor.php

chat.php

choice.php

countries.php

currencies.php

dialogue.php

editor.php

emailprotect.php

enrol_authorize.php

enrol_database.php

enrol_flatfile.php

enrol_internal.php

enrol_ldap.php

enrol_paypal.php

error.php

exercise.php

forum.php

glossary.php

grades.php

hotpot.php

install.php

journal.php

label.php

lams.php

lesson.php

mediaplugin.php

message.php

moodle.php

multilang.php

my.php

pix.php

questionnaire.php

quiz.php

quiz_analysis.php

quiz_responses.php

README

resource.php

scorm.php

survey.php

tex.php

timezones.php

webquest.php

wiki.php

workshop.php

From Samuli Karevaara (samuli.karevaara at lamk.fi) Sunday, 4 December 2005, 11:09 PM:

The underlining was lost in the plain text comment

From oen roggemans (koen at roggemans.net) Monday, 5 December 2005, 03:05 AM:

Oh silly me (and that bugtracker )

This time with stars

activitynames.php

admin.php

algebra.php

  • appointment.php

assignment.php

  • attendance.php

auth.php

block_course_list.php

block_course_summary.php

block_glossary_random.php

block_html.php

block_loancalc.php

block_online_users.php

block_quiz_results.php

block_rss_client.php

block_search_forums.php

block_section_links.php

block_social_activities.php

calendar.php

censor.php

chat.php

choice.php

countries.php

currencies.php

dialogue.php

editor.php

emailprotect.php

enrol_authorize.php

enrol_database.php

enrol_flatfile.php

enrol_internal.php

enrol_ldap.php

enrol_paypal.php

error.php

  • exercise.php

forum.php

glossary.php

grades.php

hotpot.php

install.php

  • journal.php

label.php

lams.php

lesson.php

mediaplugin.php

message.php

moodle.php

multilang.php

my.php

pix.php

  • questionnaire.php

quiz.php

quiz_analysis.php

quiz_responses.php

README

resource.php

scorm.php

survey.php

tex.php

timezones.php

  • webquest.php

wiki.php

workshop.php

From Samuli Karevaara (samuli.karevaara at lamk.fi) Monday, 5 December 2005, 02:33 PM:

...and the accompanying help files

From Samuli Karevaara (samuli.karevaara at lamk.fi) Monday, 19 June 2006, 02:33 PM:

Eloy, the original bug has been fixed, the book module lang files are gone. However, the files mentioned by Koen are still there... maybe this is a Wno't fix, but at some point these deprecated lang files might be removed from the core packages?

For example, attendance.php and 8 html help files in help/attendance. Attendance is not listed in the modules download page, not even as contrib or development. (Should it be?)

From Samuli Karevaara (samuli.karevaara at lamk.fi) Tuesday, 15 August 2006, 08:50 PM:

I'm closing this as the original bug has been fixed, and the rest of the language files have been shuffled around twice or thrice... If there are more oddities in the language packs I'll file a new bug for those.


Michael Blake added a comment - 24/Aug/06 01:57 PM
assign to a valid user

Michael Blake added a comment - 24/Aug/06 01:58 PM
assign to a valid user