Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.5.3
-
Fix Version/s: 1.9
-
Component/s: Administration
-
Labels:None
-
Environment:All
-
Database:Any
-
Affected Branches:MOODLE_15_STABLE
-
Fixed Branches:MOODLE_19_STABLE
Description
admin -> upload users.
choose the attached file.
operate.
Now you have in the list of new users two account with the same email address
Issue Links
| This issue will be resolved by: | ||||
| MDL-11996 | bulk user upload - improvements, fixes and cleanup |
|
|
|
From Iñaki Arenaza (iarenuno at eteo.mondragon.edu) Sunday, 15 January 2006, 06:47 AM:
Just try the attached patch. It checks that email is not alrelady in the user table (and not just the username).
BTW, this should be applied to HEAD too.
Saludos. Iñaki.
From Daniele Cordella (d.cordella at iss.it) Monday, 16 January 2006, 10:31 PM:
on the basis of your hints (giving me lights in the error catching) I wrote the following solution (more exaustive). To you for your comments and, maybe, the inclusion in the last 1.5.3 release and 1.6 release. Is this the right place to send you comments on this bug?
From Iñaki Arenaza (iarenuno at eteo.mondragon.edu) Wednesday, 18 January 2006, 05:47 AM:
I suppose this is the right place for these kind of comments (I'm new to all this aswell).
As to the proposed solution, I don't see any problems with it. Maybe a little rewriting of the conditions (not your additions, but the whole block) is in order, as we are making a couple of database queries twice when one should be enough.
Saludos. Iñaki.
From Martin Dougiamas (martin at moodle.com) Tuesday, 21 March 2006, 08:48 PM:
Yes, re: http://moodle.org/mod/forum/discuss.php?d=37786
that solution calls get_record() over and over when it doesn't need to.