Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 1.6
-
Fix Version/s: None
-
Component/s: Themes
-
Labels:None
-
Environment:All
-
Affected Branches:MOODLE_16_STABLE
Description
[OU-Bugzilla 851]
The CSS pages are never refreshed by IE, so you have to press Ctrl-R to get any CSS changes.
Check what Moodle is currently doing in this area. We would like it to cache the CSS for a bit (e.g. 1 hour) but not longer. Can achieve just by setting the Expires or Max-Age header for CSS requests.
Issue Links
| This issue has been marked as being related by: | ||||
| MDL-10932 | Conditional get support for stylesheets |
|
|
|
From Nick Freear (n.d.freear at open.ac.uk) Wednesday, 5 April 2006, 06:33 PM:
Re-assign to me - Todo, duplicate fix from local OU cvs.
3 fixes for the OU theme: reduce (styles.php) $lifetime, fix (weblib.php) 'Cache-Control: max-age=', and (styles.php) use filemtime for the style sheet(s) (1 for the ou theme), not styles.php
From sashaik abdul (sashaik at rediffmail.com) Thursday, 6 April 2006, 01:19 AM:
tyi
From Nick Freear (n.d.freear at open.ac.uk) Friday, 7 April 2006, 06:58 PM:
Hi sashaik. What does tyi mean - is it good or bad? I know FYI..., IMHO...
Thanks, Nick
From Nick Freear (n.d.freear at open.ac.uk) Friday, 7 April 2006, 08:48 PM:
Fix in, function style_sheet_setup.
1. Override $lastmodified parameter - we don't want filemtime('styles.php'), could use maximum of filemtimes for all style sheets. But its easier to just use current time().
2. Fixed 'Cache-Control: max-age='.