Issue Details (XML | Word | Printable)

Key: MDL-5192
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: Tim Hunt
Reporter: Anthony Borrow
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Cannot Make comment or override grade

Created: 14/Apr/06 02:49 AM   Updated: 22/Mar/07 05:01 AM
Component/s: Quiz
Affects Version/s: 1.6
Fix Version/s: None

Environment: All

Database: Any
URL: http:///mod/quiz/comment.php
Participants: Anthony Borrow, Martin Dougiamas, Michael Blake, P Sunthar and Tim Hunt
Security Level: None
Affected Branches: MOODLE_16_STABLE


 Description  « Hide
Problems with using the Make comments or override grade option

The problem seems to be with the comments. I have recieved 2 types of errors

1) could not find any user attempts and a changes saved prompt back.

2) could not insert entry in question_sessions.

It would seem that if a comment and manual grade has been entered that this should somehow be indicated. I noticed that the x/x marks was not displaying what was being manually graded even though the final grade was changing.

I know that this is new functionality being worked on and developed. I will attempt to look more into it and provide information as I stumble across it. Please let me know if there is anything specifically that I can do to help.

Peace - Anthony



 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Martin Dougiamas added a comment - 01/May/06 04:19 AM
From Gustav Delius (gwd2 at york.ac.uk) Friday, 14 April 2006, 04:07 AM:

Anthony, it would indeed be very helpful if you could give us the precise steps that would allow us to reproduce the problems that you have observed.

From Anthony Borrow (aborrow at jesuitcp.org) Friday, 14 April 2006, 06:43 AM:

I have created a Sample Quiz (Borrow) on test.moodle.org. The issue may be that I am using random questions. I have viewed the one attempt that I created using a student account and I am getting the same behavior.

From Anthony Borrow (aborrow at jesuitcp.org) Friday, 14 April 2006, 06:49 AM:

I have also created a similar quiz that does not randomize and it appears to handle those questions better by showing the adjusted mark and comment but I still get the error that it could not find the user attempt.

From Gustav Delius (gwd2 at york.ac.uk) Thursday, 27 April 2006, 04:10 PM:

I really have to find the time to fix this one!

From Gustav Delius (gwd2 at york.ac.uk) Monday, 1 May 2006, 12:23 AM:

Anthony, thanks for this bug report. I have now fixed the problem that led to the bug. I have also put in code to automatically fix the data for existing attempts.

From Anthony Borrow (aborrow at jesuitcp.org) Monday, 1 May 2006, 04:19 AM:

FYI - I just tried to change a grade and add a comment on test.moodle.com and received the following:

Notice: Undefined property: id in /home/moodtest/public_html/lib/questionlib.php on line 706

Column 'newest' cannot be null

INSERT INTO question_sessions ( ATTEMPTID, QUESTIONID, NEWEST, SUMPENALTY ) VALUES ( 192, 51, null, 0 )

print_header() was called more than once - this should not happen. Please check the code for this page closely, a common culprit is a call to error() after print_header().

Could not insert entry in question_sessions


Michael Blake added a comment - 24/Aug/06 12:46 PM
assign to a valid user

P Sunthar added a comment - 29/Jan/07 10:30 AM
Both these issues are similar, in that random questions donot accept overriding comment or grade, and the history of responses is not seen. I am linking it here as this issue is "closed" and fixed. Although in which version has it been fixed is not clear from this page on MDL-5192. Also I donot see this bug being mentioned as resolved in later versions of 1.6.x and 1.7.y