From non non (nbhansen at midway.uchicago.edu) Saturday, 22 April 2006, 07:31 AM:
This is partially a duplicate of MDL-5262.
From Gustav Delius (gwd2 at york.ac.uk) Thursday, 27 April 2006, 03:57 PM:
I'll assign this bug to Jean-Michel as soon as I have his bug tracker username.
From Jean_Michel Vedrine (jean-michel.vedrine at wanadoo.fr) Monday, 1 May 2006, 03:38 PM:
To correct the problem with line 364 moodle\mod\quiz\questiontypes\multichoice\questiontype.php
change:
$answer = $answers[$rid]->answer;
$responses[] = $answer;
to
$responses[] = (!empty($answers[$rid]) ? $answers[$rid]->answer : '');
in the moodle\mod\quiz\questiontypes\multichoice\questiontype.php file
Note to Gustav: This is simply a backport of my fix already in the 1.6 branch.
The excel bug problem was reported in bugs 5158 and 4763. It was fixed in the 1.6 branch. it's definitely not a quiz problem, but an excel lib problem.
For the category.php problem, you are right! defaultcategory is an object so on the 2 mentionned lines it should be defaultcategory->id and not defaultcategory. Here also this has been already corrected in the 1.6 branch.
So in mod/quiz/category.php lines 340 and 364
change:
if ($category->id != $this->defaultcategory) {
to:
if ($category->id != $this->defaultcategory->id) {
Gustav, the good news are that none of these problems are in the 1.6 branch !!!!!!!
I'll look at MDL-5262 now.
From non non (nbhansen at midway.uchicago.edu) Saturday, 22 April 2006, 07:31 AM:
This is partially a duplicate of
MDL-5262.From Gustav Delius (gwd2 at york.ac.uk) Thursday, 27 April 2006, 03:57 PM:
I'll assign this bug to Jean-Michel as soon as I have his bug tracker username.
From Jean_Michel Vedrine (jean-michel.vedrine at wanadoo.fr) Monday, 1 May 2006, 03:38 PM:
To correct the problem with line 364 moodle\mod\quiz\questiontypes\multichoice\questiontype.php
change:
$answer = $answers[$rid]->answer;
$responses[] = $answer;
to
$responses[] = (!empty($answers[$rid]) ? $answers[$rid]->answer : '');
in the moodle\mod\quiz\questiontypes\multichoice\questiontype.php file
Note to Gustav: This is simply a backport of my fix already in the 1.6 branch.
The excel bug problem was reported in bugs 5158 and 4763. It was fixed in the 1.6 branch. it's definitely not a quiz problem, but an excel lib problem.
For the category.php problem, you are right! defaultcategory is an object so on the 2 mentionned lines it should be defaultcategory->id and not defaultcategory. Here also this has been already corrected in the 1.6 branch.
So in mod/quiz/category.php lines 340 and 364
change:
if ($category->id != $this->defaultcategory) {
to:
if ($category->id != $this->defaultcategory->id) {
Gustav, the good news are that none of these problems are in the 1.6 branch !!!!!!!
I'll look at
MDL-5262now.MDL-5262. From Gustav Delius (gwd2 at york.ac.uk) Thursday, 27 April 2006, 03:57 PM: I'll assign this bug to Jean-Michel as soon as I have his bug tracker username. From Jean_Michel Vedrine (jean-michel.vedrine at wanadoo.fr) Monday, 1 May 2006, 03:38 PM: To correct the problem with line 364 moodle\mod\quiz\questiontypes\multichoice\questiontype.php change: $answer = $answers[$rid]->answer; $responses[] = $answer; to $responses[] = (!empty($answers[$rid]) ? $answers[$rid]->answer : ''); in the moodle\mod\quiz\questiontypes\multichoice\questiontype.php file Note to Gustav: This is simply a backport of my fix already in the 1.6 branch. The excel bug problem was reported in bugs 5158 and 4763. It was fixed in the 1.6 branch. it's definitely not a quiz problem, but an excel lib problem. For the category.php problem, you are right! defaultcategory is an object so on the 2 mentionned lines it should be defaultcategory->id and not defaultcategory. Here also this has been already corrected in the 1.6 branch. So in mod/quiz/category.php lines 340 and 364 change: if ($category->id != $this->defaultcategory) { to: if ($category->id != $this->defaultcategory->id) { Gustav, the good news are that none of these problems are in the 1.6 branch !!!!!!! I'll look atMDL-5262now.