History | Log In     View a printable version of the current page.  
We are currently focused especially on Moodle 2.0, Moodle 1.9.x bugs and Moodle 1.9.x testing.    Confused? Lost? Please read this introduction to the Tracker.
Issue Details (XML | Word | Printable)

Key: MDL-5688
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: Petr Škoda
Reporter: Tim Hunt
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Moodle

Restrict activity modules feature does not work

Created: 02/Jun/06 12:44 AM   Updated: 25/Aug/06 03:23 PM
Component/s: Administration
Affects Version/s: 1.6
Fix Version/s: None

Environment: All

Database: PostgreSQL
Participants: Martin Dougiamas, Michael Blake, Petr Škoda and Tim Hunt
Security Level: None


 Description  « Hide
Steps to reproduce
===============

1. Go to the admin -> variables page

2. At the bottom of the Permissions section, set
    restrictmodulesfor to 'All Courses'
    restrictbydefault to 'Yes'
    defaultallowedmodules to some list that contains most but not all of the modules. For example select all of them except chat.

3. Save changes.

4. Start creating a new course. At the bottom of the create new course form, not that there is a 'Restrict activity modules?' bit, and that says 'Yes', and has the correct list of modules preselected.

5. Save changes.

6. Go to the new course. Turn editing on.

7. Attempt to add a chat.

Actual result
==========

The chat can be added.

Expected result
============

Chat should not even appear in the activity dropdowns.


Other points
==========

We have observed that this does not work on Postgres. We can't test in on MySQL.

We at the OU would really like to have this working in 1.6, if possible.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Martin Dougiamas - 04/Jun/06 03:59 AM
From (penny at catalyst.net.nz) Friday, 2 June 2006, 03:45 AM:

assigning to myself

From Petr Skoda (skodak at centrum.cz) Friday, 2 June 2006, 03:58 AM:

I fixed some problem in restricted mods - switched key value in foreach, I guess it did not work properly in non-english languages ;-)



Tim, did you logout/login as ordinary teacher? I tried it first as admin and then realized that I should use teacher account instead...

From (penny at catalyst.net.nz) Friday, 2 June 2006, 04:14 AM:

yes, absolutely - it will let you do whatever you want as admin... it's only teachers who are affected by restrict activity mods.

From Tim Hunt (T.J.Hunt at open.ac.uk) Friday, 2 June 2006, 05:00 PM:

Oh! so this feature is only supposed to apply to teachers was it? I had no idea.



We really need to add a sentence to the lang string



$string['configdefaultallowedmodules'] = 'For the courses which fall into the above category, which modules do you want to allow by default <b>when the course is created</b>?';



$string['configdefaultallowedmodules'] = 'For the courses which fall into the above category, which modules do you want to allow by default <b>when the course is created</b>? Note that this setting only applys to teachers, admin users will still be able to add any activity module to a course.';



As it is, this feature is completely baffling.



Now I know how it is supposed to work, I can confirm that the actual feature is woking here, apart from the bit about localised names.



Thanks.

From Petr Skoda (skodak at centrum.cz) Friday, 2 June 2006, 05:07 PM:

My +1 for fixing the config message and closing this in 1.6, should I do it?

From Tim Hunt (T.J.Hunt at open.ac.uk) Friday, 2 June 2006, 07:16 PM:

Yes please.

From Petr Skoda (skodak at centrum.cz) Sunday, 4 June 2006, 03:59 AM:

fixed in cvs, closing now...

Michael Blake - 24/Aug/06 02:08 PM
assign to a valid user