|
Hi Martin, - any chance on gettting this patched? - I could commit it to head if you have no objections!
this is the change I'd suggest $sql = 'SELECT u.id, u.username Instead of: $sql = 'SELECT u.id, u.username Dan - I agree with the idea but... your "patch" looks backwards?
Bringing attached diff from old tracker over.
Martin,
I believe Dan's patch is correct, but there are 2 queries that need to be adjusted. I have brought over the diff from the old tracker. The other option would be to populate prefix_extuser.idnumber with the same value as user.idnumber or change that fieldname in extuser to username. Hi Martin,
Nope - not backwards! - it makes the thing work in our environment! - what looks wrong - will this not work everywhere?
Dan should be fixed as part of the auth cleanup, only usernames are now used for sync, synchronization of removed users is now fully configurable - allows full delete/suspend/nothing actions.
please report any problems with the new code, closing now - thanks! Although revamped code in 1.82 DO fix the previous issue (it is a pity it was not backported in CVS in 1.6 and 1.7 in Novembre 2006 , it would have saved us a lot of headache ;-(() , use of username as the Ldap unique user's information to sync Moodle's user database brings new problems.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
attached is a diff from that should fix this bug. I chose to go with username as the rest of the authentication code is keying off of username rather than idnumber.