adding martinl to cc list

From Luke Hudson (lingo at paradise.net.nz) Friday, 28 July 2006, 05:36 AM:

The attached patch solves this problem using the following method:

When a discussion is moved to a new forum, a skeleton discussion is left behind with the same title, but with (Moved) appended to it. The discussion will contain only one post, with the text:

This discussion has been moved to here, in the forum (new location)

The user can click either the 'here' or the name of the new forum to go the the relevant places.

From Luke Hudson (lingo at paradise.net.nz) Friday, 28 July 2006, 05:37 AM:

Oh, bother. I've put this in the wrong place

Please excuse me, this attachemnt and message refer to MDL-4874

http://git.catalyst.net.nz/gitweb?p=moodle-r2.git;a=commitdiff;h=5e256e8a1f283883c18efdef669b26bdaa8eba45;hp=8f12f5e1b93b27c1479548ce6b0106408445944a

The patch has my signoff except for that detail. If Eloy or someone else knowledgeable in backup versioning nods...

1) When a calendar event is saved with n repeats, n records are created in the event table all them sharing the repeatid value (pointing to the first event of the group). That should be the correct behaviour, yep?

2) The race condition happens when inserting new event "groups" yep?

If both answers are yes, then I think that:

1) The "calendar/event.php" patch looks perfect, because it enforces 1) perfectly.
2) The "backup/restorelib.php" patch looks glorious too, because enforces 1) perfectly.
3) It's not needed to increment the backup version at all.
4) About upgrade scripts... I really would leave them unmodified. It's a "rare" race condition and iterating over all repeated events can be heavy in some servers. In fact, I think that current queries in the patch are useless, because if the race condition has arrived, then two events will share the "repeatid" and we cannot differentiate them at all by "repeatid" (an that seems to be the base for those upgrade queries).

Any comment?

Thanks all! Ciao