|
|
|
I've just realised there's quite a serious race condition for how repeat events are handled in the calendar. I thought the repeatid column just pointed to the id of the original event.
But, no:
if ($form->repeat) {
$fetch = get_record_sql('SELECT 1, MAX(repeatid) AS repeatid FROM '.$CFG->prefix.'event');
$form->repeatid = empty($fetch) ? 1 : $fetch->repeatid + 1;
}
cvs:/calendar/edit.php
|
|
Description
|
I've just realised there's quite a serious race condition for how repeat events are handled in the calendar. I thought the repeatid column just pointed to the id of the original event.
But, no:
if ($form->repeat) {
$fetch = get_record_sql('SELECT 1, MAX(repeatid) AS repeatid FROM '.$CFG->prefix.'event');
$form->repeatid = empty($fetch) ? 1 : $fetch->repeatid + 1;
}
cvs:/calendar/edit.php |
Show » |
committed 2 files to 'Moodle CVS' on branch 'MOODLE_16_STABLE' - 29/Dec/07 03:35 AM
Prevent race condition in event creation. MDL-5956.
Credit goes to Penny, Luke and Martin @ Catalyst.
|
|
|
committed 2 files to 'Moodle CVS' on branch 'MOODLE_17_STABLE' - 29/Dec/07 03:37 AM
Prevent race condition in event creation. MDL-5956.
Credit goes to Penny, Luke and Martin @ Catalyst.
Merged from MOODLE_16_STABLE
|
|
|
committed 2 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 29/Dec/07 03:39 AM
Prevent race condition in event creation. MDL-5956.
Credit goes to Penny, Luke and Martin @ Catalyst.
Merged from MOODLE_17_STABLE
|
|
|
committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 29/Dec/07 03:57 AM
Prevent race condition in event creation. MDL-5956.
Credit goes to Penny, Luke and Martin @ Catalyst.
Merged from MOODLE_18_STABLE
|
|
|
committed 2 files to 'Moodle CVS' - 29/Dec/07 04:14 AM
Prevent race condition in event creation. MDL-5956.
Credit goes to Penny, Luke and Martin @ Catalyst.
Merged from MOODLE_19_STABLE
|
|
|
|
Bug
Resolved
Major
race condition in calendar
