[#MDL-6017] missing lang string on restore

Issue Details (XML | Word | Printable)

Key:	MDL-6017
Type:	Bug
Status:	Resolved
Resolution:	Fixed
Priority:	Trivial
Assignee:	Eloy Lafuente (stronk7)
Reporter:	Chardelle Busch
Votes:	2
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

missing lang string on restore

Created: 05/Jul/06 10:58 AM Updated: 26/Jul/07 06:14 AM

Component/s:

Backup

Affects Version/s:

1.6

Fix Version/s:

1.6.6, 1.7.3, 1.8.3

File Attachments:	1. restorelib.php.diff (2 kB)
Environment:	All

Participants:	Anthony Borrow, Chardelle Busch and Eloy Lafuente (stronk7)
Security Level:	None
Resolved date:	26/Jul/07
Affected Branches:	MOODLE_16_STABLE
Fixed Branches:	MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE

Description

« Hide

There is a missing lang string somewhere. On restore I get this:

? Creating gradebook

o [[respectingcurrentdata]]

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Anthony Borrow added a comment - 25/Jul/07 10:23 PM

Eloy - I believe the language file is grades (not grade). I found 2 such errors in /backup/restorelib.php v 1.218.2.21 (lines 1210 and 1221) which currently are:

1210 - echo '<li>'.get_string('backupwithoutgradebook','grade').'</li>';
1221 - echo '<li>'.get_string('respectingcurrentdata','grade').'</li>';

I think they should be:

1210 - echo '<li>'.get_string('backupwithoutgradebook','grades').'</li>';
1221 - echo '<li>'.get_string('respectingcurrentdata','grades').'</li>';

then these strings need to be added to /lang/en_utf8/grades.php

I'm attaching a diff file.

[ Permalink | « Hide ]

Anthony Borrow added a comment - 25/Jul/07 10:24 PM

diff file for /backup/restorelib.php

[ Permalink | « Hide ]

Anthony Borrow added a comment - 25/Jul/07 10:26 PM

I'm not sure what these strings should say. They were added by you in version 1.138 (http://moodle.cvs.sourceforge.net/moodle/moodle/backup/restorelib.php?revision=1.138&view=markup&pathrev=MOODLE_18_STABLE) in case you don't remember what you did over 2 years ago. Thanks for all of your work and continued contributions to Moodle. Peace - Anthony

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 26/Jul/07 06:14 AM

This has been fixed from Moodle 1.6 to Moodle 1.8. Will be available in next nightly builds (+ versions) or by direct access to CVS.

Note that these strings are OUT from Moodle under the upcoming 1.9 release so translators don't need to do anything with them in HEAD langs.

Thanks and ciao

All content on this web site is made available under the GNU General Public License, unless otherwise stated.