[#MDL-6085] When editing a question from the icon in a preview/review, we should not use a popup, instead, we should redirect back to that point in the quiz

Issue Details (XML | Word | Printable)

Key:	MDL-6085
Type:	Improvement
Status:	Closed
Resolution:	Fixed
Priority:	Minor
Assignee:	Tim Hunt
Reporter:	N Hansen
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

When editing a question from the icon in a preview/review, we should not use a popup, instead, we should redirect back to that point in the quiz

Created: 12/Jul/06 08:20 AM Updated: 10/Jun/09 12:19 PM

Return to search

Component/s:

Quiz

Affects Version/s:

1.9

Fix Version/s:

1.9.4

Environment:

All

Participants:	N Hansen, Sam Hemelryk and Tim Hunt
Security Level:	None
QA Assignee:	Sam Hemelryk
Resolved date:	10/Dec/08
Affected Branches:	MOODLE_19_STABLE
Fixed Branches:	MOODLE_19_STABLE

Description

« Hide

When I am previewing a quiz, and I click to edit a question in that quiz, when I am done editing it, it would be helpful if I was returned to the same place I was in the preview. Instead it takes me to the edit page with all the questions for that quiz.

All

Comments

Change History

Version Control

Sort Order:

Michael Blake made changes - 21/Aug/06 05:05 PM

Field	Original Value	New Value
Reporter		anonymous [ anonymous ]

Tim Hunt made changes - 23/Aug/06 07:32 PM

Status

In Progress [ 3 ]

Open [ 1 ]

Tim Hunt made changes - 26/Sep/07 10:16 PM

Affects Version/s		1.9 [ 10190 ]
Affects Version/s	1.6 [ 10110 ]
Issue Type	Bug [ 1 ]	Improvement [ 4 ]

Tim Hunt made changes - 02/Nov/07 04:51 AM

Summary

need better redirect

When editing a question from the icon in a preview/review, we should not use a popup, instead, we should redirect back to that point in the quiz

[ Permalink | « Hide ]

Tim Hunt added a comment - 09/Dec/08 11:50 PM

I think this is now easy because question.php takes a returnurl parameter. Will do.

Tim Hunt made changes - 09/Dec/08 11:50 PM

Fix Version/s

1.9.4 [ 10300 ]

tjhunt committed 7 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 10/Dec/08 03:22 PM

quiz: ~~MDL-6085~~ when editing a question from various places like a preview attempt or review screen, don't use a popup, instead take advantage of the fact that question.php now takes a returnurl.

MODIFY	mod/quiz/reviewquestion.php	Rev. 1.16.10.7	(+5 -2 lines)
MODIFY	question/type/description/questiontype.php	Rev. 1.11.2.6	(+2 -18 lines)
MODIFY	question/preview.php	Rev. 1.23.2.5	(+2 -1 lines)
MODIFY	mod/quiz/review.php	Rev. 1.59.2.8	(+11 -8 lines)
MODIFY	question/type/questiontype.php	Rev. 1.74.2.15	(+53 -19 lines)
MODIFY	mod/quiz/attempt.php	Rev. 1.131.2.13	(+3 -3 lines)
MODIFY	mod/quiz/report/grading/report.php	Rev. 1.25.2.15	(+2 -1 lines)

tjhunt committed 9 files to 'Moodle CVS' - 10/Dec/08 03:26 PM

quiz: ~~MDL-6085~~ when editing a question from various places like a preview attempt or review screen, don't use a popup, instead take advantage of the fact that question.php now takes a returnurl. Merged from MOODLE_19_STABLE.

And ~~MDL-17568~~ minor niggles with new queston navigation:
* The bit that scrolls down to the question you just submitted in adaptive mode was not working with random questions.
* Teachers reviewing an open attempt were shown the qusetions as editable, not read only!

MODIFY	mod/quiz/reviewquestion.php	Rev. 1.32	(+10 -5 lines)
MODIFY	question/type/questiontype.php	Rev. 1.110	(+59 -20 lines)
MODIFY	mod/quiz/review.php	Rev. 1.85	(+2 -2 lines)
MODIFY	mod/quiz/report/grading/report.php	Rev. 1.51	(+2 -1 lines)
MODIFY	mod/quiz/attempt.php	Rev. 1.159	(+2 -2 lines)
MODIFY	question/preview.php	Rev. 1.35	(+2 -1 lines)
MODIFY	mod/quiz/attemptlib.php	Rev. 1.30	(+19 -3 lines)
MODIFY	question/type/question.html	Rev. 1.20	(+1 -1 lines)
MODIFY	question/type/description/questiontype.php	Rev. 1.19	(+2 -18 lines)

Tim Hunt made changes - 10/Dec/08 03:27 PM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

[ Permalink | « Hide ]

Tim Hunt added a comment - 10/Dec/08 03:29 PM

For testers:

There are links to edit a question when:
1. A teacher is previewing a quiz.
2. A teacher is reviewing someone else's quiz attempt.
3. A teacher is reviewing a particular question within an attempts. Click on a particular question score in the quiz overview report.

There should no longer be an edit icon when previewing a single questions from the question bank or quiz editing screen.

tjhunt committed 2 files to 'Moodle CVS' - 16/Jan/09 01:47 PM

quiz / questions: ~~MDL-17919~~ Bad link edit questions from quiz preview page.

Thanks to Ann Adamcik for noticing this. It was a regression from ~~MDL-6085~~.

MODIFY	mod/quiz/attemptlib.php		Rev. 1.35		(+1 -4 lines)
MODIFY	question/type/questiontype.php		Rev. 1.119		(+3 -3 lines)

tjhunt committed 4 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 16/Jan/09 01:47 PM

quiz / questions: ~~MDL-17919~~ Bad link edit questions from quiz preview page.

Thanks to Ann Adamcik for noticing this. It was a regression from ~~MDL-6085~~.

MODIFY	mod/quiz/reviewquestion.php	Rev. 1.16.10.9	(+2 -1 lines)
MODIFY	question/type/questiontype.php	Rev. 1.74.2.20	(+4 -4 lines)
MODIFY	mod/quiz/attempt.php	Rev. 1.131.2.14	(+2 -1 lines)
MODIFY	mod/quiz/review.php	Rev. 1.59.2.10	(+2 -1 lines)

[ Permalink | « Hide ]

Sam Hemelryk added a comment - 10/Jun/09 12:19 PM

Everything looks and works well thanks Tim

Sam Hemelryk made changes - 10/Jun/09 12:19 PM

Status	Resolved [ 5 ]	Closed [ 6 ]
QA Assignee		samhemelryk

All content on this web site is made available under the GNU General Public License, unless otherwise stated.