[#MDL-6332] Once 1.7 branch was generated, drop UTF-8 migration support from HEAD - Moodle Tracker

Details

Type: Task
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: 1.8
Fix Version/s: 1.8
Component/s: Unicode
Labels:
None

Affected Branches:
MOODLE_18_STABLE
Fixed Branches:
MOODLE_18_STABLE

Description

Once the MOODLE_17_STABLE branch was generated we'll drop all the UTF-8 migration stuff from HEAD.

Apart from that, some more things will be done:

Under 17_STABLE and HEAD, add one new check to the environment stuff to allow users to check that they DB is unicode, informing about it. This will, automatically, forbid installations using install.php

Under HEAD, add one more check at the beginning of the process, looking for unicode DB. This will forbid installations not using install.php (those done by manually creating the config.php file).

Under HEAD, before executing any upgrade, check that the DB is unicode.

Document clearly that running under Unicode is mandatory to be able to run 1.8.

With this measures, everyone installing/upgrading to 1.8 will need to have one unicode db. That's the objective to safely drop migration stuff.

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

env1.patch

07/Nov/06 7:00 AM

6 kB

Petr Škoda (skodak)
environment.xml

06/Nov/06 4:51 PM

3 kB

Yu Zhang
environmentlib.php

06/Nov/06 4:52 PM

35 kB

Yu Zhang

Issue Links

This issue is blocked by:
MDL-6857	Forbid any upgrade in 1.8 if the DB hasn't been migrated to UTF-8
MDL-6858	Forbid installation of 1.8 if the DB isn't Unicode

Options
- Show All
- Show Open

Progress

Sub-Tasks

1.	Remove conditional encodings now that we use only utf-8		Closed	Petr Škoda (skodak)
2.	remove use of get_String("thischarset") replace it with utf-8		Closed	Petr Škoda (skodak)

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 23/Aug/06 10:42 PM

Assigned to Yu, for the future....

Show

Eloy Lafuente (stronk7) added a comment - 23/Aug/06 10:42 PM Assigned to Yu, for the future....

Hide

Permalink

Yu Zhang added a comment - 06/Nov/06 4:52 PM

Hi Eloy,

This is the environment checking code I have modified so far, could you take a look and let me know if this is ok to committ into stable and HEAD? Thanks.

Cheers,

Show

Yu Zhang added a comment - 06/Nov/06 4:52 PM Hi Eloy, This is the environment checking code I have modified so far, could you take a look and let me know if this is ok to committ into stable and HEAD? Thanks. Cheers, Yu

Hide

Permalink

Petr Škoda (skodak) added a comment - 07/Nov/06 7:00 AM

I have fixed the code a bit and added messages into lang pack.

Eloy proposed to add new function type to environment checks - I was not able to it today including proper testing 1.8?

Show

Petr Škoda (skodak) added a comment - 07/Nov/06 7:00 AM I have fixed the code a bit and added messages into lang pack. Eloy proposed to add new function type to environment checks - I was not able to it today including proper testing

1.8?

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 07/Nov/06 7:04 AM

Oki. NP for me. We can safely create that new environment feature later (1.7.1...., 1.8...).

Then I +1 to include this specific Unicode check right now. I really think it's better for moodlers to know about that ASAP.

Show

Eloy Lafuente (stronk7) added a comment - 07/Nov/06 7:04 AM Oki. NP for me. We can safely create that new environment feature later (1.7.1...., 1.8...). Then I +1 to include this specific Unicode check right now. I really think it's better for moodlers to know about that ASAP.

Hide

Permalink

Petr Škoda (skodak) added a comment - 07/Nov/06 4:38 PM

waiting for lang review before commit

Show

Petr Škoda (skodak) added a comment - 07/Nov/06 4:38 PM waiting for lang review before commit

Hide

Permalink

Martin Dougiamas added a comment - 07/Nov/06 6:15 PM

Petr's committed the unicode checking into 1.7 and 1.8 and it works for me.

Show

Martin Dougiamas added a comment - 07/Nov/06 6:15 PM Petr's committed the unicode checking into 1.7 and 1.8 and it works for me.

Hide

Permalink

Yu Zhang added a comment - 09/Nov/06 3:25 PM

All dropped now, will close this in a few days if no objection....

Show

Yu Zhang added a comment - 09/Nov/06 3:25 PM All dropped now, will close this in a few days if no objection....

Hide

Permalink

Yu Zhang added a comment - 10/Nov/06 10:45 AM

Resolving this now, took out all the dbencoding test stuff in install.php, will rely on environment testing. The code to test 'oci8po' seems different (a little shorter) in setuplib (setup_is_unicode()), so please check if it's sufficient.

Show

Yu Zhang added a comment - 10/Nov/06 10:45 AM Resolving this now, took out all the dbencoding test stuff in install.php, will rely on environment testing. The code to test 'oci8po' seems different (a little shorter) in setuplib (setup_is_unicode()), so please check if it's sufficient.

Hide

Permalink

Petr Škoda (skodak) added a comment - 10/Nov/06 4:34 PM

reopening more task ahead

Show

Petr Škoda (skodak) added a comment - 10/Nov/06 4:34 PM reopening more task ahead

Hide

Permalink

Petr Škoda (skodak) added a comment - 12/Nov/06 1:24 AM

subtask finished, reclosing now...

Show

Petr Škoda (skodak) added a comment - 12/Nov/06 1:24 AM subtask finished, reclosing now...

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 13/Nov/06 4:08 AM

Huge change, clap, clap, clap.

Now we are only and exclusively 100% UTF8!

What reminds me that one of the important things to solve is the specification of the charset in all the Moodle interactions with external files/DBs (authentication, enrolment, file load....).

I've been searching the tracker because I'm pretty sure that one bug about this existed but I haven't been able to find it. Uhm...

Show

Eloy Lafuente (stronk7) added a comment - 13/Nov/06 4:08 AM Huge change, clap, clap, clap. Now we are only and exclusively 100% UTF8! What reminds me that one of the important things to solve is the specification of the charset in all the Moodle interactions with external files/DBs (authentication, enrolment, file load....). I've been searching the tracker because I'm pretty sure that one bug about this existed but I haven't been able to find it. Uhm...

Hide

Permalink

Petr Škoda (skodak) added a comment - 16/Nov/06 3:56 AM

reopening and adding new task to get rid of get_string("thischarset");

Show

Petr Škoda (skodak) added a comment - 16/Nov/06 3:56 AM reopening and adding new task to get rid of get_string("thischarset");

Hide

Permalink

Petr Škoda (skodak) added a comment - 16/Nov/06 5:02 AM

reclosing

Show

Petr Škoda (skodak) added a comment - 16/Nov/06 5:02 AM reclosing

People

Assignee:

Yu Zhang

Reporter:

Eloy Lafuente (stronk7)

Tester:

Nobody

Participants:

Eloy Lafuente (stronk7), Martin Dougiamas, Petr Škoda (skodak), Yu Zhang

Vote (0)

Watch (1)

Dates

Created:

23/Aug/06 10:42 PM

Updated:

17/Dec/10 1:22 PM

Resolved:

16/Nov/06 5:02 AM