Moodle

IMS update resource -- 'frameitem' is undefined

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.6.1
  • Fix Version/s: 1.6.4, 1.7.2, 1.8
  • Component/s: IMS-CP resource type
  • Labels:
    None
  • Environment:
    Windows XP IE 6 and Firefox... IE throws an error, firefox handles it more gracefully with my current configuration.
  • Database:
    Any
  • Affected Branches:
    MOODLE_16_STABLE
  • Fixed Branches:
    MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE

Description

When updating an IMS resource type that has been set to open in a new window, the error is present.

I have determined that a possible fix is to modify mod/resource/type/ims/ims.html around line 115 which currently reads:

<script type="text/javascript">
var popupitems = [<?php echo $popupoptions; ?>];
var allitems = [<?php echo $alloptions; ?>];
</script>

To read instead:
<script type="text/javascript">
var popupitems = [<?php echo $popupoptions; ?>];
var allitems = [<?php echo $alloptions; ?>];
var frameitem = [<?php echo $frameitem; ?>];
</script>

Though this resolves the issue, I'm not positive what other implications it might have.

Activity

Hide
Eloy Lafuente (stronk7) added a comment -

Hi,

this has been fixed in all branches. It was some old code never removed. Ciao

Show
Eloy Lafuente (stronk7) added a comment - Hi, this has been fixed in all branches. It was some old code never removed. Ciao

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: