[#MDL-6508] Upgrade from 1.5.4+ to 1.6.1+ stops with hotpot error

Issue Details (XML | Word | Printable)

Key:	MDL-6508
Type:	Bug
Status:	Resolved
Resolution:	Fixed
Priority:	Critical
Assignee:	Martin Dougiamas
Reporter:	Iñaki Arenaza
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Upgrade from 1.5.4+ to 1.6.1+ stops with hotpot error

Created: 09/Sep/06 11:04 PM Updated: 14/Sep/06 11:34 AM

Return to search

Component/s:

Hotpot

Affects Version/s:

1.6.1

Fix Version/s:

1.6.2

Database:	Any
Participants:	Gordon Bateson, Iñaki Arenaza and Martin Dougiamas
Security Level:	None
Resolved date:	14/Sep/06
Affected Branches:	MOODLE_16_STABLE
Fixed Branches:	MOODLE_16_STABLE

Description

« Hide

I've just installed a clean 1.5.4+ copy (2005060241) to test the patch provided in ~~MDL-6147~~. This 1.5.4+ installation works as expected. But when I try to upgrade that copy to 1.6.1+ (2006050513), it stops at the HotPot module upgrade, with a message telling:

Version mismatch: hotpot can't downgrade 2006082800 -> 2006080701 !

It seems Gordon Bateson updated the HotPot module un 1.5.4+ recently (on 2006.08.29, according to CVS) and now the version number in 1.5.4+ is greater than the version number in 1.6.1+, which completely stops the upgrade process.

I guess making the 1.6.1+ HotPot module version number higher would be enough.

Saludos. Iñaki.

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 13/Sep/06 10:21 PM

Yes, seems Gordon mistakenly updated the Hotpot version in 1.5 recently.

http://moodle.cvs.sourceforge.net/moodle/moodle/mod/hotpot/version.php?r1=1.5.2.3&r2=1.5.2.4

Unfortunately we can't take it down again without causing other possible effects.

Unfortunately we can't just bump the version in 1.6 either, because it means that
upgrades that happened in 1.7 would be missed for people going from 1.6.3 to 1.7
at some later date.

I'll have to assign this to Gordon to try and work out. This module is very hard for
others to maintain because of the non-standard way mysql.php is used.

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 13/Sep/06 10:27 PM

Actually, what I'll do is put an upgrade in the core to reset the version. I cab't see any actual database changes taking place in 1.5 so it should be OK.

Can someone test this for me in 1.5? Just upgrade from CVS again.

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 14/Sep/06 12:29 AM

I've rerolled 1.6.2 with this fix too so we should be OK. Worked for me and didn't break moodle.org.

[ Permalink | « Hide ]

Gordon Bateson added a comment - 14/Sep/06 05:41 AM

Sorry everybody. Independant of this bug report, I noticed and fixed this problem yesterday:

http://moodle.org/mod/forum/discuss.php?d=53939

I have confirmed the fix works on MySQL nad PostgreSQL sites, so I guess this bug is ready to pass on to the official bug testers.

sorry ... again

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 14/Sep/06 11:33 AM

No worries, thanks very much, Gordon!

All content on this web site is made available under the GNU General Public License, unless otherwise stated.