[#MDL-6577] Upgrade settings broken in admin interface

Issue Details (XML | Word | Printable)

Key:	MDL-6577
Type:	Bug
Status:	Resolved
Resolution:	Fixed
Priority:	Blocker
Assignee:	Vincenzo K. Marcovecchio
Reporter:	Petr Skoda
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Upgrade settings broken in admin interface

Created: 17/Sep/06 08:12 PM Updated: 18/Sep/06 10:45 AM

Return to search

Component/s:

Administration

Affects Version/s:

1.7

Fix Version/s:

1.7

Issue Links:

Dependency

This issue will be resolved by:

~~MDL-6440~~ Add serialize/deserialize to admin_settings class

Participants:	Martin Dougiamas, Petr Skoda and Vincenzo K. Marcovecchio
Security Level:	None
Resolved date:	18/Sep/06
Affected Branches:	MOODLE_17_STABLE
Fixed Branches:	MOODLE_17_STABLE

Description

« Hide

The handling of default values in output_html() is broken for most admin_setting subclasses. The problem manifests itself in upgradesettings.php script, the default values are not displayed there which is a showstopper for upgrades from pre 1.7 releases.

I will commit partial patch today, please review the changes and fix the rest of classes. This bug is related to ~~MDL-6440~~ .

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 17/Sep/06 09:05 PM

Vince, can you let us know if you are working on this?

[ Permalink | « Hide ]

Vincenzo K. Marcovecchio added a comment - 18/Sep/06 01:41 AM

Looking into it.

[ Permalink | « Hide ]

Vincenzo K. Marcovecchio added a comment - 18/Sep/06 02:21 AM

Martin, Petr,

I've proposed something for ~~MDL-6440~~ (which has to be solved before this can be solved). Let me know if it looks alright. If so, I'll implement the fixes for both bugs tonight.

[ Permalink | « Hide ]

Vincenzo K. Marcovecchio added a comment - 18/Sep/06 10:45 AM

See latest changes to lib/adminlib.php

Hopefully this fully resolves the bug

(it's tricky to do complete upgrade testing)

All content on this web site is made available under the GNU General Public License, unless otherwise stated.