It just doesn't make sense that students get a copy of their grades if you've disabled showing grades to students in the course configuration, don't you think?. I think this should be classified as a "functional" bug and not an improvement request.

This is happening right now in Moodle and is a really, really big annoyance, especially because I don't know if this feature is shown in the documentation and can lead to really undesirable situations between teachers and students.

All efforts are welcome, I'll try to give a hand when I can.

I read this affects "any moodle system from 1.5.x to 1.6.x". Has it been fixed?. If not, we should change the description and, I said, reconsider this as a a bug.

1. Turned off the automatic notification via cron.
2. Added a button at the bottom of the view submissions page 'Send email notices to students'.
3. When/if the instructor clicks the button, students will be sent the email notice that a grade or comment was posted/updated.

It's a manual process, rather than a config setting on the assignment. The 'send' function sends notices to everyone who's grade/comment was added/updated since the last time the instructor hit 'send'. There is not a 'send to selected students' feature.

As for the course 'show grades' setting, this seems to just affect whether or not the gradebook is shown to students - they can still see the grades and comments attached to their assignment submissions. The email notice that is sent from the assignment mod does not include the grade or comment. It just says that the teacher/grader has posted some feedback on your assignment submission, and includes a link to the submission, where they can view the grade.

Peter's user profile preference is not needed in 2.0 because we'll have the new messaging system. In that system all messages from Moodle (including ones like these) go through internal messaging, and each user can choose what to do with messages from each module. eg they might choose assignment notifications to go to SMS gateway, personal messages to be popups, and forum postings to emai).

We will definitely include this in 2.0. I'm undecided about getting it into 1.9 at this late stage.

Looking at the code now

Also, add the string to the assignment lang file:

$string['emailnotification'] = 'Send notification email';

--Gary

Unfortunately the bulk sending of all notifications can not be implemented (requires integer mailed db field to track mailing status) without loosing of current functionality. Possible workaround is to not send any notifications and use forum for announcement when everything graded.

The hiding of grades can be done in new gradebook by specifying hidden until.

Please test, test, test and reopen in case of any problems or major objections

thanks everybody!

I am going to reopen this and I am still studying the revised patch. At this point it is not sending the number of emails that I would expect and there are other critical problems.

Here are some things I would note:

1. There seem to be a number of other changes in mod/assignment/lib.php with this CVS update that do not have to do with email notification. This makes it difficult to isolate this problem and it may introduce other problems to a stable version.
2. While I like the idea of saving notification as a preference, the way it is done here is confusing and will result in emails not being sent when expected. In my original patch, teachers would click Send notification email only when they wanted email sent. That worked great, as teachers would normally just notify students of a significant assignment. Here, they need to save it as a preference which sticks with the teacher for all future assignments. And what is worse, if they save their preference after they have just entered grades, they will lose all those grades And, if they don't save preferences, it does not honor their Send notification email setting for that transaction, which is not what they would expect.
3. As I said, it does not seem to be sending out the quantity of emails that my tests suggest it should.

I would suggest that we revert immediately and apply just a grade notification patch to something that we know is stable. From the description of how we use it given above, I think that the retained setting should be the state that the teacher last used, rather than the current Save preference location.

2/ I did understand what your patch does, but that is very different from Moodle 1.8. Problem with your solution is that teacher must click each time when he wants the email. If he returns back to that submission the submission may or may not be mailed - the options are the student gets 2, 1 or 0 emails depending on timing and what teacher selects. This could be solved if we had some room in submission table to track the mailing states properly.

I think the confusion comes from the label, maybe "Disable email notifications" and invert the switch?

Summary:

• UI changes - added two checkboxes with "Disable email notifications" - in grading popup and quickgrading options
• if somebody does not want notification after saving new grade or feedback - tick the checkbox

the rest works as before

1. I think that the string should continue to be Send notification email. The double-negative will cause confusion. I know that I am confused now and was not before.
2. No problem with notifications being on by initial default as in 1.8, and the button can be checked. And I do agree with saving the user preferences.

3. The popup form is working as it should (except that checkbox should be reverted as per #1.) It sends out emails only when checked, and saves the last preference.

But there are major problems with the main grading page.

4. The issue is that the checkbox be part of the "Save preferences" form. Try entering a bunch of grades and comments, then change the state of the email notification and click "Save preferences". All of your grading is now gone. This is a bug in the previous configuration too, but it happens less often as soon enough teachers settle on those settings. The same will not be true for when the will send out notifications.
5. Another problem with it being on a different form is that when submitting grades, the last preferences is what is used for mailing rather than the current setting of the checkbox. The status of that box is not part of the post. I don't think (in fact I know), that teachers won't expect that. So, emails will go out at the wrong time.

The solution: put the checkbox in the main grading form as in the original patch. Save the preferred setting on submission as with the pop-up form. We won't be getting multiple emails because the cron only sends out notices after maxeditingtime has past and then just uses that last submission.

Anyway I was saying for a long time that assignment needs more work, some rewriting, improvements, new features etc, unfortunately I get to this mod each time just before the release and it is not possible to do any significant changes without db changes

assigning back to Martin so that he decides which label is best, thanks everybody

A note to others testing this: Assignment notifications are sent out by the cron process. This means that notifications will not go out immediately. In addition, they are not sent out until the setting for maxeditingtime has passed since the last teacher edit (set from the Site administration->Block->Site policies and defaulting to 30 minutes). And, the assignment part of the cron is never called more than once a minute. So, if your cron runs every 10 minutes, you may not get notifications for more than 41 minutes. Unless you adjust for this, it may make testing difficult.

We can leave it up to our BDFL to decide on the wording issue, although I recommend that it be called "Send notification email" with the initial default to true for those transitioning from previous versions.

It looks like made this a module setting. I think ideally it should be per assignment (which puts it in the hands of the teacher). A module setting could determine the default. For now, making it a site wide module setting for the admin to decide may be good and improvements can be develop from there.

Looking at the patch, my only comment is a small disclaimer that perhaps we may want to include in the /lang/en_utf8/help/assignment/emailnotification.html file. Emails will only be sent to students with enabled email accounts. The control remains in the hands of the student. I just don't want folks thinking that it is actually sending emails to everyone. If the student disables email then it will not be sent and I think that should be clear in the help file so I reworded the text a little below:

Also, notify was spelled with an f - nofify in the patch file.

<p>Do you want to notify students with an enabled email address about assignment grades and feedback via email?</p>

Do you think we need the disclaimer to avoid confusion?

<p>Do you want to notify students with an enabled email address about assignment grades and feedback via email?</p>

The current option could really do with being on the quick grading page too.

Suggest update the label to "Disable feedback/grade notification emails" so that it's clear to teachers which email this relates to.

Send a notification message about my feedback

(As a rule we should always try and avoid "Disable X" settings)

• email send when either email of grade changed
• emails plural - general preference which applies to grading, looks better on quick grading imho because many emails my be sent after clicking "Save all my feedback"

Martin, please reopen or fix the lang files if you do not like it

Thanks everybody for all feedback, testing, patches and cooperation in general!