| Key: |
MDL-6605
|
| Type: |
Improvement
|
| Status: |
Resolved
|
| Resolution: |
Fixed
|
| Priority: |
Minor
|
| Assignee: |
Petr Skoda
|
| Reporter: |
Penny Leach
|
| Votes: |
1
|
| Watchers: |
6
|
|
|
|
File Attachments:
|
1.
skypelog.html (17 kB)
|
|
Issue Links:
|
Dependency
|
|
This issue will help resolve:
|
|
MDL-6266
sometimes visible backslash escape in user name with apostrophe (e.g. O'Reilly)
|
|
|
|
|
|
Relates
|
|
This issue has a non-specific relationship to:
|
|
|
|
|
|
|
|
|
|
change all the get_records and insert/update/ etc functions to use placeholders.
invert magic_quotes_gpc hack to stripslashes rather than addslashes
take away all calls to addslashes
this was already done once ( http://git.catalyst.net.nz/gitweb?p=elgg.git;a=commitdiff;h=553765dbdba08162745fe10710ac20153f3c12d2) but will need to be re-done.
All calls to *_sql will need to be migrated, although we can retain backwards compatibility by using $values=null in the function definition and only do variable substitution where $values is not empty.
this DOES break backwards compatibility in a few functinon definitions, see get_records_select in above diff.
|
|
Description
|
change all the get_records and insert/update/ etc functions to use placeholders.
invert magic_quotes_gpc hack to stripslashes rather than addslashes
take away all calls to addslashes
this was already done once ( http://git.catalyst.net.nz/gitweb?p=elgg.git;a=commitdiff;h=553765dbdba08162745fe10710ac20153f3c12d2) but will need to be re-done.
All calls to *_sql will need to be migrated, although we can retain backwards compatibility by using $values=null in the function definition and only do variable substitution where $values is not empty.
this DOES break backwards compatibility in a few functinon definitions, see get_records_select in above diff. |
Show » |
made changes - 31/Mar/07 02:18 AM
| Field |
Original Value |
New Value |
|
Fix Version/s
|
|
1.8.1
[ 10213
]
|
|
Fix Version/s
|
1.8
[ 10130
]
|
|
made changes - 11/Jun/07 11:33 AM
|
Fix Version/s
|
|
1.8.2
[ 10220
]
|
|
Fix Version/s
|
1.8.1
[ 10213
]
|
|
made changes - 08/Jul/07 10:41 PM
|
Fix Version/s
|
1.8.2
[ 10220
]
|
|
|
Fix Version/s
|
|
1.8.3
[ 10230
]
|
made changes - 11/Oct/07 02:41 PM
|
Fix Version/s
|
1.8.3
[ 10230
]
|
|
|
Fix Version/s
|
|
1.8.4
[ 10242
]
|
made changes - 07/Dec/07 10:52 AM
|
Attachment
|
|
skypelog.html
[ 12575
]
|
made changes - 29/Dec/07 10:03 PM
|
Link
|
|
This issue will help resolve MDL-6266
[ MDL-6266
]
|
made changes - 12/Jan/08 05:40 PM
|
Fix Version/s
|
1.8.4
[ 10242
]
|
|
|
Fix Version/s
|
|
1.8.5
[ 10252
]
|
made changes - 09/Apr/08 11:27 PM
|
Fix Version/s
|
|
1.8.6
[ 10270
]
|
|
Fix Version/s
|
1.8.5
[ 10252
]
|
|
made changes - 06/May/08 08:20 AM
|
Link
|
|
This issue has a non-specific relationship to MDL-14679
[ MDL-14679
]
|
made changes - 06/Jul/08 01:07 AM
|
Assignee
|
Penny Leach
[ mjollnir
]
|
Petr Skoda
[ skodak
]
|
made changes - 06/Jul/08 01:07 AM
|
Fix Version/s
|
|
2.0
[ 10122
]
|
|
Status
|
Open
[ 1
]
|
Resolved
[ 5
]
|
|
Fix Version/s
|
1.8.6
[ 10270
]
|
|
|
Resolution
|
|
Fixed
[ 1
]
|
|
