| Key: |
MDL-6605
|
| Type: |
Improvement
|
| Status: |
Resolved
|
| Resolution: |
Fixed
|
| Priority: |
Minor
|
| Assignee: |
Petr Skoda
|
| Reporter: |
Penny Leach
|
| Votes: |
1
|
| Watchers: |
6
|
|
|
|
File Attachments:
|
1.
skypelog.html (17 kB)
|
|
Issue Links:
|
Dependency
|
|
This issue will help resolve:
|
|
MDL-6266
sometimes visible backslash escape in user name with apostrophe (e.g. O'Reilly)
|
|
|
|
|
|
Relates
|
|
This issue has a non-specific relationship to:
|
|
|
|
|
|
|
|
|
|
change all the get_records and insert/update/ etc functions to use placeholders.
invert magic_quotes_gpc hack to stripslashes rather than addslashes
take away all calls to addslashes
this was already done once ( http://git.catalyst.net.nz/gitweb?p=elgg.git;a=commitdiff;h=553765dbdba08162745fe10710ac20153f3c12d2) but will need to be re-done.
All calls to *_sql will need to be migrated, although we can retain backwards compatibility by using $values=null in the function definition and only do variable substitution where $values is not empty.
this DOES break backwards compatibility in a few functinon definitions, see get_records_select in above diff.
|
|
Description
|
change all the get_records and insert/update/ etc functions to use placeholders.
invert magic_quotes_gpc hack to stripslashes rather than addslashes
take away all calls to addslashes
this was already done once ( http://git.catalyst.net.nz/gitweb?p=elgg.git;a=commitdiff;h=553765dbdba08162745fe10710ac20153f3c12d2) but will need to be re-done.
All calls to *_sql will need to be migrated, although we can retain backwards compatibility by using $values=null in the function definition and only do variable substitution where $values is not empty.
this DOES break backwards compatibility in a few functinon definitions, see get_records_select in above diff. |
Show » |
| No commits have yet been performed on this issue.
|
|
