Details
Bug
Description
If the language pack contains UTF-8 encoded non breaking spaces, some strings display wrong.
To reproduce, follow these steps:
1) Switch to the french language.
2) Log in and see "Connecté sous le nom « Your Name Here »" in the top right of the window (correct behaviour).
3) Log out
4) In the file moodle.php of the french language pack, replace the in the string $string['loggedinas'] with a UTF8 encoded non breaking space.
5) Log in and see the "Connecté sous le nom «" (nothing more) in the top right of the window (bug).
The correction of this bug could be very handful, as it will allow a better lisibility of the lang pack and the consistent use of non-breaking spaces in all strings (i.e also those that are sent by standard mail, which doesn't support HTML entities).
Issue Links
| This issue has been marked as being related by: | ||||
| MDL-13975 | p() and s() should not be used to print lang strings |
|
|
|
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
No, because:
1) The non-breaking spaces ARE important (at least in french), so we shouldn't remove them, but instead replace them with HTML entities (I meant this in my preceding comment, sorry for the bad explanation) during the file save. Note that as of 1.8dev, the file save strips these entities, which is bad (and I should perhaps open another bug issue for this one).
2) Some translator (me 
), for efficiency, doesn't use the Moodle interface to translate the strings. The conversion described in the above point would be for them of no use.
If it was feasible, I would suggest to workaround the lacking UTF-8 support of the sprintf() PHP function used in get_string_from_file() (in lib/moodlelib.php). This way, we could write the strings in UTF-8 without any doubts.
See for a suggested solution here : http://www.php.net/manual/en/function.sprintf.php#55837
), for efficiency, doesn't use the Moodle interface to translate the strings. The conversion described in the above point would be for them of no use.
If it was feasible, I would suggest to workaround the lacking UTF-8 support of the sprintf() PHP function used in get_string_from_file() (in lib/moodlelib.php). This way, we could write the strings in UTF-8 without any doubts.
See for a suggested solution here : http://www.php.net/manual/en/function.sprintf.php#55837 
Only need to specify the first version in which the problem was found.