Could you pleaes check these modifications are correct? (In the attached file). Sorry I don't know much about LDAP. I could not find where to place checks for auth_sync_users(), where should the checks be?

Yu

When I was hacking with MS LDAP, I noticed that depending on the version it was sending either utf-8 or default platform encoding (cp1250 in my case). I think that the encoding should be configurable, because we can not guess it in all cases.

• The LDAP protocol uses UTF-8. Barring servers doing strange stuff, or PHP-LDAP messing the data up, Moodle should just use the string as returned. It will be valid UTF-8. I did quite a bit of digging around the protocol specs.

• auth/db has 2 cases:
• DB backend supports unicode (even if the database/tables are not in utf-8), we can just issue "use names UTF-8 " and stop worrying as this transfers the job of ensuring data we trade with the DB is treated as UTF-8.
• DB backend does not support unicode. Add option to set what encoding should we assume the db is encoded in, and transcode accordingly.