Moodle

IMS enrolment in 1.7dev (2006092800) uses PHP5 syntax

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.7
  • Fix Version/s: 1.7
  • Component/s: Enrolments
  • Labels:
    None
  • Affected Branches:
    MOODLE_17_STABLE
  • Fixed Branches:
    MOODLE_17_STABLE

Description

IMS enrolment plugin is using some language constructs that are only available in PHP5, but 1.7 is supposed to work with 4.3.x or later.

Namely it's using the 'public static' qualifier for '$imsroles' class variable and 'determine_defalt_rolemapping()' class function. It also breaks in PHP 4.3.10 withe the use of the scope resolution operator for 'enrolment_plugin_imsenterprise::$imsroles' in a couple of places, although it should work, according to PHP manuals.

The errors prevent from displaying the enrolment configuration page.

Saludos. Iñaki.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Martin Dougiamas added a comment -

Dan, what are my chances of getting you to look at this?

Show
Martin Dougiamas added a comment - Dan, what are my chances of getting you to look at this?
Hide
Permalink
Dan Stowell added a comment -

My apologies, I forgot to watch out for PHP4 compat. Now fixed, hopefully, although I haven't actually tested it on PHP4 - I've simply reverted to older syntax. Please test.

Show
Dan Stowell added a comment - My apologies, I forgot to watch out for PHP4 compat. Now fixed, hopefully, although I haven't actually tested it on PHP4 - I've simply reverted to older syntax. Please test.
Hide
Permalink
Iñaki Arenaza added a comment -

Not it parses without trouble and you can get both the general enrolment configuration page and the IMS Enterprise configuration page. I assume the rest of the IMS functionality still works as expected, as I don't use IMS at all.

Saludos. Iñaki.

Show
Iñaki Arenaza added a comment - Not it parses without trouble and you can get both the general enrolment configuration page and the IMS Enterprise configuration page. I assume the rest of the IMS functionality still works as expected, as I don't use IMS at all. Saludos. Iñaki.
Hide
Permalink
Iñaki Arenaza added a comment -

Ups! I meant now it parses without trouble

Saludos. Iñaki.

Show
Iñaki Arenaza added a comment - Ups! I meant now it parses without trouble Saludos. Iñaki.
Hide
Permalink
Michael Blake added a comment -

This has been passed by Inaki.

Show
Michael Blake added a comment - This has been passed by Inaki.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.