Details
Bug
Description
Throughout the moodle core there is use of $CFG->themedir and $CFG->themewww, but these variables are not used in some places, thus making them useful.
I've produced a patch which fixes the few places where these variables aren't used (and copious bits in the standard themes).
Mostly its just replacing $CFG->dirroot . 'theme/' with the themedir variable.
In order to keep previous behaviour I added $CFG->httpsthemewww to keep places happy which used httpswwwroot.
Also in get_list_of_plugins I added a case statement which allows the themedir to be taken notice of.
These changes mean that a completely different theme directory can be used and is taken notice of - the theme selector works too.
Obviously theme authors would need to use these variables - and i've patched the stock themes, but this does mean that the variables are useable.
We wish to use this to allow the core and themes to be kept seperate on a shared hosting solution.
Attachments
Issue Links
| This issue will help resolve: | ||||
| MDL-6623 | $CFG->themedir Mostly Broken |
|
|
|
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
Sounds reasonable to me too, going to review/commit it tomorrow 
I do not like the trailing slash in themedir and wwwdir, because all other config.php paths forbid it. The main problem is that if we do not fix it now, we will not be able to do it later because it would break BC in 3rd party themes.
I have prepared a new patch that fixes following:
- trailing slash removed + fixed current use of themedir and themewww - fortunately no theme uses it now
- fixed initilisation of httpswwwroot in setup.php
- removed obsoleted detect_munged_arguments() in setup.php
If you can, please test it - I will ask MD tomorrow to confirm the removal of the trailing slashes
In any case we need to update theme docs in the docs wiki. Any volunteers?
- trailing slash removed + fixed current use of themedir and themewww - fortunately no theme uses it now
- fixed initilisation of httpswwwroot in setup.php
- removed obsoleted detect_munged_arguments() in setup.php
In any case we need to update theme docs in the docs wiki. Any volunteers? Thanks you Dan!
I have added Urs to the watch list. I was unable to contact Martin Dougiamas today, I will ask for the confirmation of the trailing slash removal tomorrow and commit ASAP if ok
The problem with themes in moodledata is that files can not be served directly by the apache and style.php needs to know where is the main config.php; it will be hard to solve and I guess it would break backwards compatibility 
I guess we would have to use some new themefile.php to allow fetching of theme files from arbitrary location. We can not work around the security problems with execution of php scripts, the upload of new themes should be definitely reserved for administrators only and it should be disabled by default. The download&installation from web should not be a big problem, it would be as secure as current language import.
I guess we would have to use some new themefile.php to allow fetching of theme files from arbitrary location. We can not work around the security problems with execution of php scripts, the upload of new themes should be definitely reserved for administrators only and it should be disabled by default. The download&installation from web should not be a big problem, it would be as secure as current language import. 
forgot to attach the patch