if (and only if) they don't already have course:update on that new course then find a legacy:editingteacher role and assign that role to them in the course context.

Fixed this in HEAD now. Users with restore capabilities but no manageactivities capability will be assigned a legacy:edittingteacher role upon successful restore of a course.

At the bottom where roles are mapped, I did not have the option of keeping the teacher (to which role I already was assigned) = to editingteacher. What I had was to make the teacher = new role, non-editing teacher, student, or guest.

So I chose new role. This left me with instructor rights, but it created a copy of the editingteacher role in the admin area of define roles AND I no longer showed up as instructor in the participants list.

This doesn't seem quite right.

I think this is the case because users doing restore can only map users to roles that they themselves can assign, defined in the "Allow Role Assignment" interface (Users->Permissions->Define Roles->Allow role assignment (tab)). This is to prevent say a teacher mapping students etc to Admin role or so on. The default is a bit restrictive as it does not allow editing teachers to assign other editing teachers, but you can set it to allow them to do so.

Cheers,

Yu