Issue Details (XML | Word | Printable)

Key: MDL-6854
Type: Task Task
Status: Closed Closed
Resolution: Fixed
Priority: Blocker Blocker
Assignee: Eloy Lafuente (stronk7)
Reporter: Eloy Lafuente (stronk7)
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Review UTF migration to check everything works properly...

Created: 06/Oct/06 01:17 AM   Updated: 06/Oct/06 11:35 PM
Return to search
Component/s: Unicode
Affects Version/s: 1.7
Fix Version/s: 1.7

Environment: Any
Issue Links:
Blockers
 

Database: MySQL
Participants: Eloy Lafuente (stronk7)
Security Level: None
Resolved date: 06/Oct/06
Affected Branches: MOODLE_17_STABLE
Fixed Branches: MOODLE_17_STABLE

Sub-Tasks  All   Open   
 Sub-Task Progress: 

 Description  « Hide
Perform one UTF-8 migration to confirm that all the tables/fields under 1.7 are properly migrated, doing it with debuglevel = developer to detect any notice/warning....

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Eloy Lafuente (stronk7) added a comment - 06/Oct/06 01:25 AM
Changing this task to blocked. I'm on it right now!

Eloy Lafuente (stronk7) made changes - 06/Oct/06 01:25 AM
Field Original Value New Value
Priority Critical [ 2 ] Blocker [ 1 ]
Eloy Lafuente (stronk7) added a comment - 06/Oct/06 02:24 AM
I've found these different notices:
  • Notice: Undefined index: dummy in /Users/stronk7/cvs_moodle/moodle_head/admin/utfdbmigrate.php on line 523
  • Notice: Undefined variable: result in /Users/stronk7/cvs_moodle/moodle_head/backup/db/migrate2utf8.php on line 39
  • Notice: Undefined variable: result in /Users/stronk7/cvs_moodle/moodle_head/lib/db/migrate2utf8.php on line 265
  • Notice: Undefined variable: result in /Users/stronk7/cvs_moodle/moodle_head/lib/db/migrate2utf8.php on line 301
  • Notice: Undefined variable: result in /Users/stronk7/cvs_moodle/moodle_head/lib/db/migrate2utf8.php on line 609
  • Notice: Undefined variable: result in /Users/stronk7/cvs_moodle/moodle_head/lib/db/migrate2utf8.php on line 685

Also, these problems (sub-tasking them):

  • Some tables aren't processed at all: MDL-6859
  • Some fields aren't processed at all: MDL-6860

Working in the notices now...


Eloy Lafuente (stronk7) committed 2 files to 'Moodle CVS' - 06/Oct/06 03:29 AM
Avoid some notices. Part of MDL-6854
MODIFY backup/db/Attic/migrate2utf8.php   Rev. 1.8    (+4 -3 lines)
MODIFY lib/db/Attic/migrate2utf8.php   Rev. 1.25    (+12 -5 lines)
Eloy Lafuente (stronk7) committed 1 file to 'Moodle CVS' - 06/Oct/06 03:51 AM
Avoid some notices. Part of MDL-6854
MODIFY admin/Attic/utfdbmigrate.php   Rev. 1.73    (+2 -2 lines)
Eloy Lafuente (stronk7) added a comment - 06/Oct/06 03:57 AM
Now all the notices are completely out (they were 100% innocent).

"Only" sub-tasks remain....


Eloy Lafuente (stronk7) added a comment - 06/Oct/06 10:24 PM
Subtasks finished..... marking as resolved and testing it right now.

Eloy Lafuente (stronk7) made changes - 06/Oct/06 10:24 PM
Fix Version/s 1.7 [ 10120 ]
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Eloy Lafuente (stronk7) made changes - 06/Oct/06 10:49 PM
Link This issue is blocked by MDL-6336 [ MDL-6336 ]
Eloy Lafuente (stronk7) added a comment - 06/Oct/06 10:50 PM
Reopening because of MDL-6336 not working properly...

Eloy Lafuente (stronk7) made changes - 06/Oct/06 10:50 PM
Status Resolved [ 5 ] Reopened [ 4 ]
Resolution Fixed [ 1 ]
Eloy Lafuente (stronk7) added a comment - 06/Oct/06 11:14 PM
One new notice found:

Notice: Undefined index: FIELDS in /Users/stronk7/cvs_moodle/moodle_head/admin/utfdbmigrate.php on line 432

(checking it now)

Both sub-tasks (MDL-6859 and MDL-6860) seems ok. now! B-)


Eloy Lafuente (stronk7) committed 1 file to 'Moodle CVS' - 06/Oct/06 11:26 PM
One malformed XML was preventing wiki_logs to be properly UTF8-ised. MDL-6854
MODIFY mod/wiki/db/Attic/migrate2utf8.xml   Rev. 1.7    (+1 -0 lines)
Eloy Lafuente (stronk7) added a comment - 06/Oct/06 11:29 PM
Notice fixed too. It was caused by one malformed XML file.

Now everythings seems to be OK with UTF-8 migration, so marking as resolved.


Eloy Lafuente (stronk7) made changes - 06/Oct/06 11:29 PM
Resolution Fixed [ 1 ]
Status Reopened [ 4 ] Resolved [ 5 ]
Eloy Lafuente (stronk7) added a comment - 06/Oct/06 11:35 PM
And, after execution and check, closed! B-)

Good work!


Eloy Lafuente (stronk7) made changes - 06/Oct/06 11:35 PM
Status Resolved [ 5 ] Closed [ 6 ]