[#MDL-6878] Scalable Vector Graphics (SVG) files in Moodle are not correctly displayed in many Browsers - Moodle Tracker

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 1.6.2
Fix Version/s: 1.6.3, 1.7
Component/s: Resource
Labels:
None
Environment:
Any

Database:

Any
URL:
http://moodle.org/mod/forum/discuss.php?d=55755
Affected Branches:
MOODLE_16_STABLE
Fixed Branches:
MOODLE_16_STABLE, MOODLE_17_STABLE

Description

Applies to Web browsers (Firefox, Opera) that natively display SVG and require correct MIME type to be served from Moodle.
Internet Explorer + Adobe SVG Plugin view does not have a problem as it renders SVG base on the .svg extension alone.

Problem can be simply resolved by adding the following lines to function get_mimetypes_array() in /lib/filelib.php

i.e.

'svg' => array ('type'=>'image/svg+xml', 'icon'=>'image.gif'),
'svgz' => array ('type'=>'image/svg+xml', 'icon'=>'image.gif'),

Issue Links

This issue is a clone of:
MDL-10599	CLONE -Scalable Vector Graphics (SVG) files in Moodle are not correctly displayed in many Browsers

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Petr Škoda (skodak) added a comment - 08/Oct/06 4:20 PM

fixed in cvs, thanks for the report and patch!

Show

Petr Škoda (skodak) added a comment - 08/Oct/06 4:20 PM fixed in cvs, thanks for the report and patch!

Hide

Permalink

Stephen Bourget added a comment - 14/Oct/06 4:31 AM

This fix seems to work only in the case wher you add the file as a resource using "Link to a file or website". If you add the svg using any other method (to a forum post, as an image on a resource, etc) it seems to fail.

The built-in HTML Editor rejects svg files as "not an image"

This can be fixed by changing line 63 of lib\editor\htmlarea\coursefiles.php
From:

if(params.itype.indexOf("image/gif") == -1 && params.itype.indexOf("image/jpeg") == -1 && params.itype.indexOf("image/png") == -1)

To:

if(params.itype.indexOf("image/gif") == -1 && params.itype.indexOf("image/jpeg") == -1 && params.itype.indexOf("image/png") == -1 && params.itype.indexOf("image/svg") == -1)

However even if the svg is added to Moodle using HTML.

The image will fail to be displayed.

Thoughts?

Show

Stephen Bourget added a comment - 14/Oct/06 4:31 AM This fix seems to work only in the case wher you add the file as a resource using "Link to a file or website". If you add the svg using any other method (to a forum post, as an image on a resource, etc) it seems to fail. The built-in HTML Editor rejects svg files as "not an image" This can be fixed by changing line 63 of lib\editor\htmlarea\coursefiles.php From: if(params.itype.indexOf("image/gif") == -1 && params.itype.indexOf("image/jpeg") == -1 && params.itype.indexOf("image/png") == -1) To: if(params.itype.indexOf("image/gif") == -1 && params.itype.indexOf("image/jpeg") == -1 && params.itype.indexOf("image/png") == -1 && params.itype.indexOf("image/svg") == -1) However even if the svg is added to Moodle using HTML. <img border="1" style="width: 135px; height: 102px;" title="svg?" alt="svg?" src="http://localhost/Tectonic_plates.svg" /> or <img hspace="0" border="0" title="SVG" alt="SVG" src="http://localhost/moodle17/file.php/2/Tectonic_plates.svg" style="width: 102px; height: 102px;" /> The image will fail to be displayed. Thoughts?

Hide

Permalink

Stephen Bourget added a comment - 14/Oct/06 5:11 AM

I was trying to insert the svg file incorrectly.

The fix works on Moodle 1.7beta

Closing

Show

Stephen Bourget added a comment - 14/Oct/06 5:11 AM I was trying to insert the svg file incorrectly. The fix works on Moodle 1.7beta Closing

People

Assignee:

Petr Škoda (skodak)

Reporter:

Geoffrey Rowland

Tester:

Stephen Bourget

Participants:

Geoffrey Rowland, Petr Škoda (skodak), Stephen Bourget

Vote (0)

Watch (1)

Dates

Created:

08/Oct/06 6:08 AM

Updated:

25/Jul/07 4:44 PM

Resolved:

14/Oct/06 5:11 AM