[#MDL-6892] AJAX weekly course format - the section date is not updated when we reorder sections

Issue Details (XML | Word | Printable)

Key:	MDL-6892
Type:	Bug
Status:	Closed
Resolution:	Fixed
Priority:	Minor
Assignee:	Vy-Shane Sin Fat
Reporter:	Vy-Shane Sin Fat
Votes:	0
Watchers:	1

Operations

If you were logged in you would be able to see more operations.

Moodle

AJAX weekly course format - the section date is not updated when we reorder sections

Created: 09/Oct/06 04:51 PM Updated: 03/Aug/07 08:44 PM

Component/s:

AJAX, Course

Affects Version/s:

1.7

Fix Version/s:

1.7, 1.8

File Attachments:

format.php.diff (1.0 kB)
2.

section_classes.js.diff (2 kB)

Issue Links:

Duplicate

This issue is duplicated by:

~~MDL-7574~~ Dates Disappear when you "turn editing on"

Participants:	Ken Wilson, Matthew Davidson, Nicolas Martignoni and Vy-Shane Sin Fat
Security Level:	None
QA Assignee:	Nicolas Martignoni

Description

« Hide

We should either hide the section dates, generate new ones, or have a temporary message when sections are moved. Do via javascript.

All

Comments

Change History

Version Control

Sort Order:

[ Permlink | « Hide ]

Vy-Shane Sin Fat added a comment - 10/Oct/06 10:42 AM

I've committed a fix to hide the dates if we are in editing mode and if ajax is turned on. This is a temporary measure. The correct way to fix this is to have the javascript update the dates whenever sections are moved around.

However, the code to do that would be relevant only for the weekly course format. What's the best way to do this? Do we subclass the section_class javascript class and put the new code in the course/format/weeks/ directory? Any suggestions?

[ Permlink | « Hide ]

Vy-Shane Sin Fat added a comment - 15/Nov/06 03:18 PM

Already been fixed.

[ Permlink | « Hide ]

Ken Wilson added a comment - 21/Nov/06 07:11 AM

Vy - I'm not seeing any dates in weekly format. Is this OK to close as it is, or will the dates be put back at a later stage? I'm thinking that without the dates users will get confused about which week they are amending/moving :). Thanks. Ken.

[ Permlink | « Hide ]

Vy-Shane Sin Fat added a comment - 22/Nov/06 04:33 PM

Yes, this is a temporary fix. I've kept ~~MDL-7574~~ open. They are pretty much duplicates of each other.

[ Permlink | « Hide ]

Nicolas Martignoni added a comment - 21/Dec/06 11:36 PM

Closing. This temp fix works.

[ Permlink | « Hide ]

Matthew Davidson added a comment - 03/Aug/07 08:44 PM

Here is the ajax fix so that the dates update correctly when dragging and dropping weekly sections. You also have to change the course/format/weeks/format.php