Moodle

AJAX weekly course format - the section date is not updated when we reorder sections

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.7
  • Fix Version/s: 1.7, 1.8
  • Component/s: AJAX, Course
  • Labels:
    None
  • Affected Branches:
    MOODLE_17_STABLE
  • Fixed Branches:
    MOODLE_17_STABLE, MOODLE_18_STABLE

Description

We should either hide the section dates, generate new ones, or have a temporary message when sections are moved. Do via javascript.

Attachments

  1. File
    format.php.diff
    03/Aug/07 8:44 PM
    1.0 kB
    Matthew Davidson
  2. File
    section_classes.js.diff
    03/Aug/07 8:44 PM
    2 kB
    Matthew Davidson

Issue Links

This issue is duplicated by:
MDL-7574 Dates Disappear when you "turn editing on" Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Vy-Shane Sin Fat added a comment -

I've committed a fix to hide the dates if we are in editing mode and if ajax is turned on. This is a temporary measure. The correct way to fix this is to have the javascript update the dates whenever sections are moved around.

However, the code to do that would be relevant only for the weekly course format. What's the best way to do this? Do we subclass the section_class javascript class and put the new code in the course/format/weeks/ directory? Any suggestions?

Show
Vy-Shane Sin Fat added a comment - I've committed a fix to hide the dates if we are in editing mode and if ajax is turned on. This is a temporary measure. The correct way to fix this is to have the javascript update the dates whenever sections are moved around. However, the code to do that would be relevant only for the weekly course format. What's the best way to do this? Do we subclass the section_class javascript class and put the new code in the course/format/weeks/ directory? Any suggestions?
Hide
Permalink
Vy-Shane Sin Fat added a comment -

Already been fixed.

Show
Vy-Shane Sin Fat added a comment - Already been fixed.
Hide
Permalink
Ken Wilson added a comment -

Vy - I'm not seeing any dates in weekly format. Is this OK to close as it is, or will the dates be put back at a later stage? I'm thinking that without the dates users will get confused about which week they are amending/moving . Thanks. Ken.

Show
Ken Wilson added a comment - Vy - I'm not seeing any dates in weekly format. Is this OK to close as it is, or will the dates be put back at a later stage? I'm thinking that without the dates users will get confused about which week they are amending/moving . Thanks. Ken.
Hide
Permalink
Vy-Shane Sin Fat added a comment -

Yes, this is a temporary fix. I've kept MDL-7574 open. They are pretty much duplicates of each other.

Show
Vy-Shane Sin Fat added a comment - Yes, this is a temporary fix. I've kept MDL-7574 open. They are pretty much duplicates of each other.
Hide
Permalink
Nicolas Martignoni added a comment -

Closing. This temp fix works.

Show
Nicolas Martignoni added a comment - Closing. This temp fix works.
Hide
Permalink
Matthew Davidson added a comment -

Here is the ajax fix so that the dates update correctly when dragging and dropping weekly sections. You also have to change the course/format/weeks/format.php

Show
Matthew Davidson added a comment - Here is the ajax fix so that the dates update correctly when dragging and dropping weekly sections. You also have to change the course/format/weeks/format.php

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.