• File uploading and sesskey protection not implemented.
• Method names could be improved.
• Some dummy validation callback method could be added.

Changes:

• the outside API is not dependent on quickforms
• non-post form type compatible with xxx_param() functions - both return the same data
• easier to learn how to use - less methods in the wrapper
• server-side Moodle specific cleaning
• only form_definition() uses quickform methods, but only those related to form construction

• one more change - form name is constructed from the class name

We should consider removing the target parameter in :

function moodleform_wrapper($action, $customdata=null, $method='post', $target='', $attributes=null) {

as target is deprecated in xhtml strict.

I added this code to the end of your updateSubmission method and then use_values_as_defaults() really is redundant :

//need to tell elements that they need to update their value attribute.
foreach (array_keys($this->_elements) as $key) { $this->_elements[$key]->onQuickFormEvent('updateValue', null, $this); }

Jamie

I am working on course/edit3.php and incline docs+comments. in formslib.php today.