Moodle

Edit Icon in Internet Explorer

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.7
  • Fix Version/s: 1.7.1, 1.8
  • Component/s: Administration, AJAX
  • Labels:
    None
  • Environment:
    Internet Explorer
  • Database:
    MySQL
  • Affected Branches:
    MOODLE_17_STABLE
  • Fixed Branches:
    MOODLE_17_STABLE, MOODLE_18_STABLE

Description

Edit icon does not appear in Internet explorer on any resources or activities. It does show on Topic Summary and blocks.
In Firefox, everything is good.

Issue Links

Activity

Hide
Yu Zhang added a comment -

Hi,

I got them showing up fine here, can you attach a screenshot?

Show
Yu Zhang added a comment - Hi, I got them showing up fine here, can you attach a screenshot?
Hide
Ken Wilson added a comment -

Confirmed and duplicated OK. Problem occurs in Weekly format also - but not in Weekly CSS/No tables format. Workaround was to turn off AJAX for the user as in MDL-6965. Have added AJAX as a component of this bug.

Show
Ken Wilson added a comment - Confirmed and duplicated OK. Problem occurs in Weekly format also - but not in Weekly CSS/No tables format. Workaround was to turn off AJAX for the user as in MDL-6965. Have added AJAX as a component of this bug.
Hide
Yu Zhang added a comment -

Thanks for pointing out that this is AJAX related.

Show
Yu Zhang added a comment - Thanks for pointing out that this is AJAX related.
Hide
Martin Dougiamas added a comment -

AJAX man, AJAX man ...

Show
Martin Dougiamas added a comment - AJAX man, AJAX man ...
Hide
Lori Bakken added a comment -

Here's a bit more info now.

I'm using parent themes as well, with some custom icons. With AJAX turned on, it doesn't look in the right folder and show the right icons.

I don't know if this is relevant, but I figured it would be good to know.

Show
Lori Bakken added a comment - Here's a bit more info now. I'm using parent themes as well, with some custom icons. With AJAX turned on, it doesn't look in the right folder and show the right icons. I don't know if this is relevant, but I figured it would be good to know.
Hide
Andrew Walker added a comment -

Hi,

I'm just slowly trying to learn how all this Ajax stuff works in moodle I think to fix the problem with the edit buttons not appearing in Internet Explorer you can make the following change in the resource_class.prototype.init_buttons in lib/ajax/section_classes.js

changing

for (var x=0; x<buttons.length; x++) {
if (buttons[x].title == main.portal.strings['update']) { updateButton = buttons[x]; }
}

so it becomes,

for (var x=0; x<buttons.length; x++) {
if (buttons[x].title == main.portal.strings['update']) { updateButton = buttons[x].cloneNode(true); }
}

Show
Andrew Walker added a comment - Hi, I'm just slowly trying to learn how all this Ajax stuff works in moodle I think to fix the problem with the edit buttons not appearing in Internet Explorer you can make the following change in the resource_class.prototype.init_buttons in lib/ajax/section_classes.js changing for (var x=0; x<buttons.length; x++) { if (buttons[x].title == main.portal.strings['update']) { updateButton = buttons[x]; } } so it becomes, for (var x=0; x<buttons.length; x++) { if (buttons[x].title == main.portal.strings['update']) { updateButton = buttons[x].cloneNode(true); } }
Hide
Andrew Walker added a comment -

Hi Lori,

I don't know if there are better solutions (there quite probably are ), but I seem to have the custom icons back in my theme by making the modifications described in this bug - http://tracker.moodle.org/browse/MDL-7440

Show
Andrew Walker added a comment - Hi Lori, I don't know if there are better solutions (there quite probably are ), but I seem to have the custom icons back in my theme by making the modifications described in this bug - http://tracker.moodle.org/browse/MDL-7440
Hide
Lori Bakken added a comment -

Thanks. That worked like a charm. Is this going to be place in CVS soon?

Lori

Show
Lori Bakken added a comment - Thanks. That worked like a charm. Is this going to be place in CVS soon? Lori
Hide
Martin Dougiamas added a comment -

Thanks, Andy!!

Vy, can you get this in ASAP?

Show
Martin Dougiamas added a comment - Thanks, Andy!! Vy, can you get this in ASAP?
Hide
Vy-Shane Sin Fat added a comment -

Thanks Andrew. I've checked in the fix.

Show
Vy-Shane Sin Fat added a comment - Thanks Andrew. I've checked in the fix.
Hide
Ken Wilson added a comment -

Confirmed and tested. Thanks. Now closed.

Show
Ken Wilson added a comment - Confirmed and tested. Thanks. Now closed.

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: