Issue Details (XML | Word | Printable)

Key: MDL-7010
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Tim Hunt
Reporter: Priya Saini
Votes: 1
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-6937

mod\quiz\config.html

Created: 16/Oct/06 03:46 PM   Updated: 10/Dec/08 12:17 AM
Return to search
Component/s: Accessibility, Forms Library
Affects Version/s: 1.8
Fix Version/s: 2.0

File Attachments: 1. File settingstree.php (3 kB)
Issue Links:
Dependency
 
Duplicate
 
Relates
 

Participants: Jamie Pratt, Priya Saini and Tim Hunt
Security Level: None
Resolved date: 26/Aug/08
Affected Branches: MOODLE_18_STABLE
Fixed Branches: MOODLE_20_STABLE


 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
[ Permalink | « Hide ]
Jamie Pratt added a comment - 02/May/08 11:13 PM
Would be great if you had time to tackle this Tim.

Jamie Pratt made changes - 02/May/08 11:13 PM
Field Original Value New Value
Assignee Jamie Pratt [ jamiesensei ] Tim Hunt [ timhunt ]
Jamie Pratt committed 1 file to 'Moodle CVS' - 09/May/08 02:12 PM
MDL-14637 "allow activity modules to add sub menus of settings pages to admin menu" and MDL-14565 "allow quiz reports to add configuration settings to the admin tree" added a mechanism to admin/settings/plugins.php to allow modules to include a file settingstree.php instead of settings.php which will allow for more flexibility of what a module can add to the admin settings menu.

Merged from 1.9

Added a comment to the if branch that includes config.html that this branch needs to be deleted as soon as quiz/config.html has been migrated to settingstree.php which is MDL-7010
MODIFY admin/settings/plugins.php   Rev. 1.5    (+6 -2 lines)
[ Permalink | « Hide ]
Jamie Pratt added a comment - 09/May/08 02:23 PM
Attaching a file settingstree.php that uses the new mechanism in the admin tree to let activity modules do more than just add one page to the admin menu. This file includes commented out code to include general settings for all reports and a comment about where to add code for the quiz module general settings page.

It also searches mod/quiz/report sub folders for any settings.php pages. If any are found or if some general settings for reports have been defined a sub folder will be added quiz/reports.

Right now you can drop this into mod/quiz. You won't see anything until some actual pages are added to the extra categories on the admin menu. If you drop this into mod/quiz then you will no longer see the settings page defined by config.html The same page can be used in HEAD and 1.9

I added a TODO comment to an if branch in HEAD that needs deleting as soon as quiz/config.html is migrated to used the admin menu api.


Jamie Pratt made changes - 09/May/08 02:23 PM
Attachment settingstree.php [ 13922 ]
[ Permalink | « Hide ]
Jamie Pratt added a comment - 09/May/08 02:25 PM
The TODO comment is in admin/settings/plugins.php

Tim Hunt made changes - 18/Jun/08 10:25 PM
Link This issue will help resolve MDL-15279 [ MDL-15279 ]
[ Permalink | « Hide ]
Tim Hunt added a comment - 22/Aug/08 06:00 PM
I have nearly finished this, but it is 6:00pm Friday and I have had enough. Just the review options to go. Should be done on Monday.

tjhunt committed 19 files to 'Moodle CVS' - 26/Aug/08 09:05 AM
MDL-7010 Convert mod\quiz\config.html to mod/quiz/settingstree.php using the new admin tree system.
MODIFY mod/quiz/lib.php   Rev. 1.314    (+21 -1 lines)
MODIFY mod/quiz/edit.php   Rev. 1.121    (+2 -2 lines)
MODIFY admin/settings/plugins.php   Rev. 1.16    (+1 -5 lines)
MODIFY lib/adminlib.php   Rev. 1.246    (+271 -17 lines)
DEL mod/quiz/Attic/reviewoptions.html   Rev. 1.8    (+0 -0 lines)
MODIFY lang/en_utf8/quiz_responses.php   Rev. 1.6    (+2 -1 lines)
MODIFY mod/quiz/Attic/defaults.php   Rev. 1.15    (+36 -36 lines)
ADD mod/quiz/settingstree.php   Rev. 1.1    (+0 -0 lines)
MODIFY mod/quiz/locallib.php   Rev. 1.156    (+1 -22 lines)
MODIFY lang/en_utf8/quiz_analysis.php   Rev. 1.7    (+2 -1 lines)
MODIFY mod/quiz/version.php   Rev. 1.136    (+2 -2 lines)
MODIFY mod/quiz/db/upgrade.php   Rev. 1.24    (+17 -1 lines)
MODIFY theme/standard/styles_layout.css   Rev. 1.598    (+15 -6 lines)
MODIFY mod/quiz/mod_form.php   Rev. 1.36    (+53 -52 lines)
MODIFY lang/en_utf8/quiz_grading.php   Rev. 1.8    (+2 -1 lines)
DEL mod/quiz/Attic/config.html   Rev. 1.38    (+0 -0 lines)
MODIFY lang/en_utf8/quiz_statistics.php   Rev. 1.15    (+2 -1 lines)
MODIFY lang/en_utf8/quiz.php   Rev. 1.111    (+20 -1 lines)
MODIFY lang/en_utf8/quiz_overview.php   Rev. 1.16    (+2 -1 lines)
[ Permalink | « Hide ]
Tim Hunt added a comment - 26/Aug/08 09:06 AM
Done.

Note that if non of the quiz reports have any settings, then the quiz settings appear directly under Plugins -> Activity modules. If some quiz reports do have settings, then Plugins -> Activity modules -> Quiz becomes an expandable menu with General settings and XXX Report settings, etc.


Tim Hunt made changes - 26/Aug/08 09:06 AM
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s 2.0 [ 10122 ]
Resolution Fixed [ 1 ]
tjhunt committed 1 file to 'Moodle CVS' - 26/Aug/08 01:58 PM
MDL-7010 - followup - delete file that is no longer required.
DEL mod/quiz/Attic/defaults.php   Rev. 1.16    (+0 -0 lines)
Mitsuhiro Yoshida committed 15 files to 'Lang CVS' - 27/Aug/08 04:28 PM
MDL-16166 Translated new strings for admin, mnet and notes.
Brushed up a translated help file for quiz max grade.
MDL-7010 Translated new strings for quiz settings.
MDL-13766 Translated new strings for repository.
Updated translated strings for repository based on lang/en_utf8 change.
MODIFY ja_utf8/help/quiz/maxgrade.html   Rev. 1.6    (+2 -2 lines)
MODIFY ja_utf8/quiz_analysis.php   Rev. 1.8    (+2 -1 lines)
MODIFY ja_utf8/repository_local.php   Rev. 1.2    (+5 -5 lines)
MODIFY ja_utf8/admin.php   Rev. 1.296    (+2 -1 lines)
MODIFY ja_utf8/quiz_grading.php   Rev. 1.9    (+2 -1 lines)
MODIFY ja_utf8/quiz_responses.php   Rev. 1.6    (+2 -1 lines)
MODIFY ja_utf8/notes.php   Rev. 1.8    (+4 -1 lines)
MODIFY ja_utf8/repository_flickr.php   Rev. 1.2    (+2 -2 lines)
MODIFY ja_utf8/quiz.php   Rev. 1.159    (+20 -1 lines)
MODIFY ja_utf8/repository.php   Rev. 1.9    (+6 -4 lines)
MODIFY ja_utf8/mnet.php   Rev. 1.42    (+2 -1 lines)
MODIFY ja_utf8/quiz_statistics.php   Rev. 1.15    (+6 -5 lines)
MODIFY ja_utf8/quiz_overview.php   Rev. 1.18    (+2 -1 lines)
MODIFY ja_utf8/README   Rev. 1.796    (+1 -1 lines)
MODIFY ja_utf8/repository_boxnet.php   Rev. 1.2    (+3 -3 lines)
martignoni committed 6 files to 'Lang CVS' - 27/Aug/08 05:12 PM
MDL-7010 strings added
MODIFY fr_utf8/quiz_responses.php   Rev. 1.6    (+2 -1 lines)
MODIFY fr_utf8/quiz_statistics.php   Rev. 1.14    (+2 -1 lines)
MODIFY fr_utf8/quiz.php   Rev. 1.116    (+20 -1 lines)
MODIFY fr_utf8/quiz_overview.php   Rev. 1.18    (+2 -1 lines)
MODIFY fr_utf8/quiz_grading.php   Rev. 1.10    (+2 -1 lines)
MODIFY fr_utf8/quiz_analysis.php   Rev. 1.10    (+2 -1 lines)
tjhunt committed 2 files to 'Moodle CVS' - 10/Sep/08 10:44 AM
MDL-7010 - followup - quiz config settings were referred to in two places in the question bank. Since these settings are now in config_plugins, the references need to be update. (Of course, perhaps these should not be referred to at all ...)
MODIFY question/format.php   Rev. 1.50    (+6 -2 lines)
MODIFY question/preview.php   Rev. 1.33    (+2 -2 lines)
Jamie Pratt made changes - 24/Nov/08 05:05 PM
Link This issue has been marked as being related by MDL-14194 [ MDL-14194 ]
Tim Hunt made changes - 10/Dec/08 12:17 AM
Link This issue is duplicated by MDL-11627 [ MDL-11627 ]

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators