Moodle

API debug

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Duplicate
  • Affects Version/s: 1.5.3
  • Fix Version/s: None
  • Component/s: SCORM
  • Labels:
    None
  • Affected Branches:
    MOODLE_15_STABLE

Description

Every SCORM type has a different API that provides communications from the SCO to Moodle.
The SCORM 1.2 API has passed ADL test suite many times ago but it may need some bug fix. I say this thing because during SCORM 2004 debugging I fixed some bugs that may be fixed also in 1.2.
These files (aicc/scorm_12/scorm_13.js.php) are mostly javascript files with a small use of PHP to provide data content.
SCORM 2004 APIs are defined as a Javascript (ECMAscript as ADL says) DOM object with these 8 methods:
Initialize("")
Terminate("")
GetValue(dataelement)
SetValue(dataelement,value)
Commit("")
GetLastError()
GetErrorString(errorcode)
GetDiagnostic(errorcode)
SCORM 2004 introduces also an attribute call version usually equal to "1.0".

From Moodle 1.5 I decided to provide the datamodel definition as a multidimensional array and all the methods was rewritten to use the datamodel array to check Gen and Set calls.
That datamodel definition uses many regular expressions and one the main problems is to define the right regular expression for each datamodel element type.

Issue Links

This issue will help resolve:
MDL-9255 SCORM 2004 - cmi vars not saving correctly Critical Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Roberto Pinna added a comment -

Last week I made some fixes on datamodel to pass all the ADL requirements.

There still remains some problems and we need to introduce sequencing to complete all the things.

Please update every day your version.

Bobo.

Show
Roberto Pinna added a comment - Last week I made some fixes on datamodel to pass all the ADL requirements. There still remains some problems and we need to introduce sequencing to complete all the things. Please update every day your version. Bobo.
Hide
Permalink
Martin Dougiamas added a comment -

How's this going, Maximino? We have about 5 weeks left to get SCORM 2004 done.

Show
Martin Dougiamas added a comment - How's this going, Maximino? We have about 5 weeks left to get SCORM 2004 done.
Hide
Permalink
Maximino Pecero Sánchez added a comment -

We have fixed a problem with the update of cmi.entry adding conditions in the first php block of the file scorm_13.js.php

Show
Maximino Pecero Sánchez added a comment - We have fixed a problem with the update of cmi.entry adding conditions in the first php block of the file scorm_13.js.php
Hide
Permalink
Maximino Pecero Sánchez added a comment -

We have fixed a problem with the double indexed elements in the GetValue method

Show
Maximino Pecero Sánchez added a comment - We have fixed a problem with the double indexed elements in the GetValue method
Hide
Permalink
Maximino Pecero Sánchez added a comment -

We have already fixed some problems with the double indexed elements, but there are still some left. We have been doing tests in order to find the reason why it is not working. It seems like one of the main problems is the maxmodel variable, so we are trying to adapt it to double indexed elements because, right now, the SetValue function is not working when we want to use it correctly for one of those elements.

Show
Maximino Pecero Sánchez added a comment - We have already fixed some problems with the double indexed elements, but there are still some left. We have been doing tests in order to find the reason why it is not working. It seems like one of the main problems is the maxmodel variable, so we are trying to adapt it to double indexed elements because, right now, the SetValue function is not working when we want to use it correctly for one of those elements.
Hide
Permalink
Martin Dougiamas added a comment -

Assigning to Sadiel for prioritising and fixing.

Show
Martin Dougiamas added a comment - Assigning to Sadiel for prioritising and fixing.
Hide
Permalink
Martin Dougiamas added a comment -

Assigning to Jesús Rincón to organise and start working on.

Show
Martin Dougiamas added a comment - Assigning to Jesús Rincón to organise and start working on.
Hide
Permalink
Roberto Pinna added a comment -

We must review some things added from Sadiel like this one.

if (element== 'cmi.interactions.0.learner_response' && value=='Dependency on cmi.interaction.n.type not established'){ errorCode="408"; }

In this way we could pass ADL test suite but it's just a test workaround.

Show
Roberto Pinna added a comment - We must review some things added from Sadiel like this one. if (element== 'cmi.interactions.0.learner_response' && value=='Dependency on cmi.interaction.n.type not established'){ errorCode="408"; } In this way we could pass ADL test suite but it's just a test workaround.
Hide
Permalink
Jesús Rincón added a comment -

We have deleted that code and commit the changes to the CVS.

Show
Jesús Rincón added a comment - We have deleted that code and commit the changes to the CVS.
Hide
Permalink
Jesús Rincón added a comment -

We have been searching the code to find some errors and we realized there were a problem with the CMIFeedback and with the double indexed elements and we communicated it to Bobo, who has already solved some of those bugs. We continue working on this.

Show
Jesús Rincón added a comment - We have been searching the code to find some errors and we realized there were a problem with the CMIFeedback and with the double indexed elements and we communicated it to Bobo, who has already solved some of those bugs. We continue working on this.
Hide
Permalink
Jesús Rincón added a comment -

Fixed a bug with cmi.interactions.n.id elements. Now it sets the value correctly instead of showing the error 351, as it used to do for some tests.

Show
Jesús Rincón added a comment - Fixed a bug with cmi.interactions.n.id elements. Now it sets the value correctly instead of showing the error 351, as it used to do for some tests.
Hide
Permalink
Jesús Rincón added a comment -

We fixed a problem with duplicated ids for cmi.interactions.n.objectives.n.id elements.

Show
Jesús Rincón added a comment - We fixed a problem with duplicated ids for cmi.interactions.n.objectives.n.id elements.
Hide
Permalink
Jesús Rincón added a comment -

We fixed a problem with duplicated ids for cmi.interactions.n.id elements.

Show
Jesús Rincón added a comment - We fixed a problem with duplicated ids for cmi.interactions.n.id elements.
Hide
Permalink
Jesús Rincón added a comment -

We and Bobo continue working on the CMI Feedback type definition. We are solving different bugs related to the dependency we have to establish between this type and the cmi.interactions.n.type.

Show
Jesús Rincón added a comment - We and Bobo continue working on the CMI Feedback type definition. We are solving different bugs related to the dependency we have to establish between this type and the cmi.interactions.n.type.
Hide
Permalink
Jesús Rincón added a comment -

Fixed a problem with the type "sequencing" for CMIFeedback.

Show
Jesús Rincón added a comment - Fixed a problem with the type "sequencing" for CMIFeedback.
Hide
Permalink
Jesús Rincón added a comment -

CMIFeedback is done for learner_response. We are working on the correct_responses type.

Show
Jesús Rincón added a comment - CMIFeedback is done for learner_response. We are working on the correct_responses type.
Hide
Permalink
Jesús Rincón added a comment -

Working on the definition of the correct_responses type

Show
Jesús Rincón added a comment - Working on the definition of the correct_responses type
Hide
Permalink
Jesús Rincón added a comment -

Working on some javascript errors on the definition of correct_responses.

Show
Jesús Rincón added a comment - Working on some javascript errors on the definition of correct_responses.
Hide
Permalink
Jesús Rincón added a comment -

Fixed some errors of duplicated elements and with the number of patterns.

Show
Jesús Rincón added a comment - Fixed some errors of duplicated elements and with the number of patterns.
Hide
Permalink
Jesús Rincón added a comment -

Fixed a problem with true-false type for correct responses.

Show
Jesús Rincón added a comment - Fixed a problem with true-false type for correct responses.
Hide
Permalink
Petr Škoda (skodak) added a comment -

lowering priority

Show
Petr Škoda (skodak) added a comment - lowering priority
Hide
Permalink
Dan Marsden added a comment -

closing this as a duplicate - will use the parent of this bug for tracking details regarding to SCORM 2004 compliance.

Show
Dan Marsden added a comment - closing this as a duplicate - will use the parent of this bug for tracking details regarding to SCORM 2004 compliance.

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.