[#MDL-7114] installation failing on infinite loop in forum_add_user_default_subscriptions()

Issue Details (XML | Word | Printable)

Key:	MDL-7114
Type:	Bug
Status:	Resolved
Resolution:	Fixed
Priority:	Blocker
Assignee:	Yu Zhang
Reporter:	Petr Skoda
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

installation failing on infinite loop in forum_add_user_default_subscriptions()

Created: 20/Oct/06 06:29 AM Updated: 20/Oct/06 04:32 PM

Return to search

Component/s:

Installation

Affects Version/s:

1.7, 1.8

Fix Version/s:

1.7, 1.8

Participants:	Petr Skoda and Yu Zhang
Security Level:	None
Resolved date:	20/Oct/06
Affected Branches:	MOODLE_17_STABLE, MOODLE_18_STABLE
Fixed Branches:	MOODLE_17_STABLE, MOODLE_18_STABLE

Description

« Hide

installation failing on infinite loop in admin/user.php when creating admin account in forum_add_user_default_subscriptions(), cause by recent improvement in get_context_instance() -

  // This is really a systen context
    if ($contextlevel == CONTEXT_COURSE && $instance == SITEID) {
        $contextlevel = CONTEXT_SYSTEM;
    }

I am going to commit some quick fix - please review and find better solution...

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Yu Zhang added a comment - 20/Oct/06 10:56 AM

Hi,

I really think this logic is ok, the site context should be 1 context instead of being separate. If they are 2, some capabilities needs to be set in CONTEXT_SYSTEM (site:config for example) while others needs to be set in CONTEXT_COURSE (all the mod capabilities), or set all capabilities at both contexts. I am not sure there are benefits of keep them separate.

I have seen your patch in forum, and I don't really know how to make it better.

[ Permalink | « Hide ]

Petr Skoda added a comment - 20/Oct/06 04:32 PM

I am no expert on CONTEXT_SYSTEM - I believe you, closing now

All content on this web site is made available under the GNU General Public License, unless otherwise stated.