|
Assigning this issue to the language Tzar
 Thanks hotpot guru.
Found a dozen more - fixed them all Just changing the title a bit to avoid some undesired effect in moodle.org
Canging back the title. Sorry by the noise. Just testing moodle.org :-/
Thanks Koen. Closing this issue.
The error is not a human error, but caused by saving hotpot.php with the moodle editor. Again there are a few languages affected. I'll recheck them all and fix them.
Added David to have a look whether a permanent fix is possible.
Following strings from hotpot.php: get converted to if saved with the editor. It messes up the screen in hotpot Can you have a look or comment on it David? I'll correct the affected language packs. Thanks Why is there even <IFRAME> in the language strings???
Well, strictly speaking there isn't an <IFRAME> in the language strings. We are talking about using HTML-entities such as < and >
The particular language string which started this thread was in hotpot.php: This string is used to explain on of the options for the "Navigation" setting of a HotPot activity I think using the angle brackets helps to make clear that the IFRAME is an HTML element. However, it would be perfectly simple to remove the HTML entities, thus: For a more general fix though, I think it would be preferable to handle the HTML-entities in the way that Koen has suggested. Oops, I meant it would be simple to change the string to:
$string['navigation_iframe'] = 'Embedded IFRAME'; Since this is the only case where < and > is used in a language pack, and since it is apparently not really necessary to have them, we could aswell just leave them out of the language packs.
I'm happy with removing < and >, rather then tweaking the sanitizing mechanism of the language editor. Aha, I see now.
Koen if you can remove them then excellent. But also, David, they should be encoded automatically by the language editor ... can you do that too? (to avoid any such problems in future) Koen,
when you change ">IFRAME<" to plain old "IFRAME" in all the "hotpot.php" language files, please could you also make the same change to all the "help/hotpot/navigation.html" files. many thanks Removed all < and > around IFRAME in all language files.
> But also, David, they should be encoded automatically by the language editor ...
> can you do that too? (to avoid any such problems in future) Negative. If it encoded all < and > characters, how would the editor work with real <br />, <p>, <strong> and other HTML in strings? Unless we use real template mechamism with i18n feature (like e.g. Zope Page Template) with no HTML in language pack, we can not encode < and > automatically. The second issue is that the editor apparently does not keep < as < and transforms it back into <. This is bug. I will look at it (I do not have much time these weeks, sorry guys.) Nicolas,
I think many thanks Gordon,
since language packs do not use CVS branching mechanism, all such fixes are automatically backported into older version. Just download and update your language pack. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Bug
Resolved
Minor
<IFRAME> should be encoded using HTML entities in lang/pt_br/hotpot.php
 |
|
http://moodle.org/mod/forum/discuss.php?d=56819