Moodle

Finish strings for graderoles

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.7
  • Fix Version/s: 1.7, 1.8
  • Component/s: Administration
  • Labels:
    None
  • Affected Branches:
    MOODLE_17_STABLE
  • Fixed Branches:
    MOODLE_17_STABLE, MOODLE_18_STABLE

Description

See: admin/settings.php?section=gradebook_roles

needs strings and docs

Issue Links

This issue has a non-specific relationship to:
MDL-6416 The grading list shows all admins if there are no students in the course Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Martin Dougiamas added a comment -

Actually, page should just be called "gradebook" too. the roles that appear in it are just one setting (more to come)

Show
Martin Dougiamas added a comment - Actually, page should just be called "gradebook" too. the roles that appear in it are just one setting (more to come)
Hide
Permalink
Petr Škoda (skodak) added a comment -

Should be fixed in CVS, please review and close.

Show
Petr Škoda (skodak) added a comment - Should be fixed in CVS, please review and close.
Hide
Permalink
Petr Škoda (skodak) added a comment -

oh, we should also raise main version number to get default gradebook_roles into existing installations through admin/upgradesettings.php

I did not raise it myself because I guess we might need to do another bump soon and we have only 7 bumps left for 1.7.0.

Show
Petr Škoda (skodak) added a comment - oh, we should also raise main version number to get default gradebook_roles into existing installations through admin/upgradesettings.php I did not raise it myself because I guess we might need to do another bump soon and we have only 7 bumps left for 1.7.0.
Hide
Permalink
Martin Dougiamas added a comment -

Done. I fixed some logic too (defaults were not right) and changed the name from gradebook_roles to gradebookroles

Show
Martin Dougiamas added a comment - Done. I fixed some logic too (defaults were not right) and changed the name from gradebook_roles to gradebookroles
Hide
Permalink
Petr Škoda (skodak) added a comment -

the default value is wrong, results in 0 stored in db

Show
Petr Škoda (skodak) added a comment - the default value is wrong, results in 0 stored in db
Hide
Permalink
Petr Škoda (skodak) added a comment -

fixed in cvs, reclosing...

Show
Petr Škoda (skodak) added a comment - fixed in cvs, reclosing...
Hide
Permalink
Stephen Bourget added a comment -

Verified on Moodle 1.7Beta 2

Closing

Show
Stephen Bourget added a comment - Verified on Moodle 1.7Beta 2 Closing

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.