Moodle

Hover text for 'Search and replace' button in the HTML editor inconvenient for translation.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.7
  • Fix Version/s: 1.7
  • Component/s: Language
  • Labels:
    None
  • Affected Branches:
    MOODLE_17_STABLE
  • Fixed Branches:
    MOODLE_17_STABLE

Description

The hover text for 'Search and replace' button in the HTML editor is probably hard coded in the following file:

"C:\xampplite\moodle\lib\editor\htmlarea\htmlarea.php"(246,28):
search_replace: [ "Search and replace", "ed_replace.gif", false, function(e) {e.execCommand("searchandreplace");} ]

which is inconvenient for translation.

Issue Links

Activity

Hide
Dan Poltawski added a comment -

Think this will fix it:

diff -ruN moodle/lang/en_utf8/editor.php moodle_local/lang/en_utf8/editor.php
— moodle/lang/en_utf8/editor.php 2006-11-01 14:56:17.000000000 +0000
+++ moodle_local/lang/en_utf8/editor.php 2006-11-03 20:12:00.000000000 +0000
@@ -47,6 +47,7 @@
$string['imageurl'] = 'Image URL';
$string['indent'] = 'Increase Indent';
$string['insertchar'] = 'Insert Special Character';
+$string['search_replace'] = 'Search and Replace';
$string['insertimage'] = 'Insert Image';
$string['insertlink'] = 'Insert Link';
$string['insertsmile'] = 'Insert Smiley';
diff -ruN moodle/lib/editor/htmlarea/lang/en.php moodle_local/lib/editor/htmlarea/lang/en.php
— moodle/lib/editor/htmlarea/lang/en.php 2006-06-23 20:53:26.000000000 +0100
+++ moodle_local/lib/editor/htmlarea/lang/en.php 2006-11-03 20:12:08.000000000 +0000
@@ -73,6 +73,7 @@
paste: "<?php print_string("paste","editor") ?>",
insertsmile: "<?php print_string("insertsmile","editor") ?>",
insertchar: "<?php print_string("insertchar","editor") ?>",
+ search_replace: "<?php print_string("search_replace","editor") ?>",
clean: "<?php print_string("wordclean","editor") ?>",
lefttoright: "<?php print_string("lefttoright","editor");?>",
righttoleft: "<?php print_string("righttoleft","editor");?>"

Show
Dan Poltawski added a comment - Think this will fix it: diff -ruN moodle/lang/en_utf8/editor.php moodle_local/lang/en_utf8/editor.php — moodle/lang/en_utf8/editor.php 2006-11-01 14:56:17.000000000 +0000 +++ moodle_local/lang/en_utf8/editor.php 2006-11-03 20:12:00.000000000 +0000 @@ -47,6 +47,7 @@ $string['imageurl'] = 'Image URL'; $string['indent'] = 'Increase Indent'; $string['insertchar'] = 'Insert Special Character'; +$string['search_replace'] = 'Search and Replace'; $string['insertimage'] = 'Insert Image'; $string['insertlink'] = 'Insert Link'; $string['insertsmile'] = 'Insert Smiley'; diff -ruN moodle/lib/editor/htmlarea/lang/en.php moodle_local/lib/editor/htmlarea/lang/en.php — moodle/lib/editor/htmlarea/lang/en.php 2006-06-23 20:53:26.000000000 +0100 +++ moodle_local/lib/editor/htmlarea/lang/en.php 2006-11-03 20:12:08.000000000 +0000 @@ -73,6 +73,7 @@ paste: "<?php print_string("paste","editor") ?>", insertsmile: "<?php print_string("insertsmile","editor") ?>", insertchar: "<?php print_string("insertchar","editor") ?>", + search_replace: "<?php print_string("search_replace","editor") ?>", clean: "<?php print_string("wordclean","editor") ?>", lefttoright: "<?php print_string("lefttoright","editor");?>", righttoleft: "<?php print_string("righttoleft","editor");?>"
Hide
Dan Poltawski added a comment -

Scratch that - this will be the simpler fix:

diff -ruN moodle/lib/editor/htmlarea/lang/en.php public_html/lib/editor/htmlarea/lang/en.php
— moodle/lib/editor/htmlarea/lang/en.php 2006-11-03 20:30:56.000000000 +0000
+++ public_html/lib/editor/htmlarea/lang/en.php 2006-11-03 21:21:19.000000000 +0000
@@ -73,6 +73,7 @@
paste: "<?php print_string("paste","editor") ?>",
insertsmile: "<?php print_string("insertsmile","editor") ?>",
insertchar: "<?php print_string("insertchar","editor") ?>",
+ search_replace: "<?php print_string("searchandreplace", "editor" ?>",
clean: "<?php print_string("wordclean","editor") ?>",
lefttoright: "<?php print_string("lefttoright","editor");?>",
righttoleft: "<?php print_string("righttoleft","editor");?>"

Show
Dan Poltawski added a comment - Scratch that - this will be the simpler fix: diff -ruN moodle/lib/editor/htmlarea/lang/en.php public_html/lib/editor/htmlarea/lang/en.php — moodle/lib/editor/htmlarea/lang/en.php 2006-11-03 20:30:56.000000000 +0000 +++ public_html/lib/editor/htmlarea/lang/en.php 2006-11-03 21:21:19.000000000 +0000 @@ -73,6 +73,7 @@ paste: "<?php print_string("paste","editor") ?>", insertsmile: "<?php print_string("insertsmile","editor") ?>", insertchar: "<?php print_string("insertchar","editor") ?>", + search_replace: "<?php print_string("searchandreplace", "editor" ?>", clean: "<?php print_string("wordclean","editor") ?>", lefttoright: "<?php print_string("lefttoright","editor");?>", righttoleft: "<?php print_string("righttoleft","editor");?>"
Hide
Martin Dougiamas added a comment -

Thanks, Dan! I checked it in to 1.7 and HEAD

Show
Martin Dougiamas added a comment - Thanks, Dan! I checked it in to 1.7 and HEAD
Hide
Nicolas Martignoni added a comment -

Verified, closing.

Show
Nicolas Martignoni added a comment - Verified, closing.

People

Dates

  • Created:
    Updated:
    Resolved: