Moodle

Remove custom timezone handling when PHP5 is required

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.5, 1.5.1, 1.5.2, 1.5.3, 1.5.4, 1.6, 1.6.1, 1.6.2, 1.6.3, 1.6.4, 1.6.5, 1.7, 1.7.1, 1.7.2, 1.8, 1.8.1, 1.8.2
  • Fix Version/s: 2.1.5
  • Component/s: Libraries
  • Labels:
    None
  • Affected Branches:
    MOODLE_15_STABLE, MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_21_STABLE

Description

We have custom timezone handling code in Moodle versions 1.5 to 1.7. This was put in place to work around

  • A long-standing bug in PHP on Windows 95/98/Me where TZ info was missing and the TZ calls did not return an error. This was considered a critical problem. This bug did not apply to WindowsNT/2000 AFAIK.
  • Possibly outdated TZ info in all platforms. This is a minor issue.

This naturally affected all PHP-based projects. From PHP5 onwards, PECL's timezonedb (see http://php.net/manual/en/ref.datetime.php ) addresses both problems.

Moodle 1.8 is expected to require PHP5 so we can drop this nasty kludge.

Issue Links

Activity

Hide
Petr Škoda (skodak) added a comment -

I am afraid we will have to support PHP4 in 1.8, if I remember it correctly MD said that about a month ago

Show
Petr Škoda (skodak) added a comment - I am afraid we will have to support PHP4 in 1.8, if I remember it correctly MD said that about a month ago
Hide
Martín Langhoff added a comment -

Hmmm. Well, whenever PHP5 is required -

Do we have a 'switch to PHP5' meta-bug to link this against? Might be a good idea to have one... there will be things to do for it to happen, and things waiting on it.

Show
Martín Langhoff added a comment - Hmmm. Well, whenever PHP5 is required - Do we have a 'switch to PHP5' meta-bug to link this against? Might be a good idea to have one... there will be things to do for it to happen, and things waiting on it.
Hide
Petr Škoda (skodak) added a comment -

Good idea, I like metabugs!

Show
Petr Škoda (skodak) added a comment - Good idea, I like metabugs!
Hide
Martin Dougiamas added a comment -

Link to metabug added

Show
Martin Dougiamas added a comment - Link to metabug added
Hide
Martin Dougiamas added a comment -

Note that the nasty kludge actually works perfectly

Show
Martin Dougiamas added a comment - Note that the nasty kludge actually works perfectly

People

Vote (0)
Watch (5)

Dates

  • Created:
    Updated: