Issue Details (XML | Word | Printable)

Key: MDL-7323
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Piers Harding
Reporter: Keith Starling
Votes: 2
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

AICC Import does not handle Core_Vendor

Created: 02/Nov/06 03:35 AM   Updated: 24/Jul/08 09:52 AM
Return to search
Component/s: SCORM
Affects Version/s: 1.6.3
Fix Version/s: 1.8.7, 1.9.3, 2.0

File Attachments: 1. Text File patch.txt (0.6 kB)
2. Zip Archive sample_crs.zip (1.0 kB)


Participants: Dan Marsden, Jesús Rincón, Keith Starling, Martin Dougiamas and Piers Harding
Security Level: None
QA Assignee: Dan Marsden
Resolved date: 24/Jul/08
Affected Branches: MOODLE_16_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE


 Description  « Hide
mod/scorm/locallib.php does not process the Core_Vendor section of an AICC au file. This has been checked in current version of 1.7 and the problem persists. Can be fixed by following change to the scorm_parse_aicc() function:
on the line following:

-----------------------------CUT----------------------------
                    $sco->masteryscore = $element->mastery_score;
-----------------------------CUT----------------------------

insert:

-----------------------------CUT----------------------------
                    if (!isset($element->core_vendor)) {
                        $element->core_vendor = '';
                    }
                    else {
                        $element->core_vendor = eregi_replace('<cr>', "\r\n", $element->core_vendor);
                    }
                    $sco->datafromlms = $element->core_vendor;
-----------------------------CUT----------------------------

This functionality is required for level 1 AICC compliance.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Martin Dougiamas added a comment - 26/Mar/07 03:51 PM
Assigning to Sadiel for prioritising and fixing.

Martin Dougiamas added a comment - 26/Mar/07 04:20 PM
Assigning to Jesús Rincón to organise and start working on.

Jesús Rincón added a comment - 11/May/07 08:02 PM
Could you please send an AICC file so we can reproduce this?

Keith Starling added a comment - 04/Apr/08 10:07 AM
This is an AICC sample lesson with data in the Core_Vendor section, it requires the Macromedia Authorware plugin to run, which can be downloaded from http://www.adobe.com/shockwave/download/alternates/#ap

Keith Starling added a comment - 04/Apr/08 11:50 AM
Patch to fix this in Trunk

Dan Marsden added a comment - 03/Jul/08 01:48 PM
Assigning to Piers - Does this get fixed with the patches from Martin Holden?

Dan


Piers Harding added a comment - 23/Jul/08 09:34 AM
Have applied this patch in HEAD, and attempted to test this using the attached package. This package fails to load correctly hanging on the interaction with http://www.aicc.org/pages/samples.html (which opens if I go to it directly from within browser). Would be great if someone could test this and get back to me on their experiences - thanks.

Piers Harding.


Dan Marsden added a comment - 24/Jul/08 07:48 AM
Hi Piers - patch looks good to me, can you please now apply this 1.9Stable and 1.8Stable?

thanks!

Dan


Piers Harding added a comment - 24/Jul/08 09:49 AM
Applied patch supplied, and propagated changes to 1.8 and 1.9.

Cheers.


Dan Marsden added a comment - 24/Jul/08 09:52 AM
great! - good work Piers!

1 down....76 more to go!

Dan