Details
Sub-task
Closed
Minor
Description
I wondered why I was getting the PHP Warning about the 'allow_call_time_pass_reference' use being deprecated. Turns out
that the expliit test for a setting to 0, will not always work. init_get() is documented to return '0' or ''. The present code only
tests for '0',and will thus not warn invokers in all unsupported instances. I attach a context diff of a patch to fix this.
Attachments
Activity
Uhm, Dongsheng,
I think that setting was deprecated long time ago and perhaps, instead of looking at that value... we should declare those parameters to be passed by reference in function declaration, not relaying in that setting at all.
Can you research a bit more in chatd if we have properly declared what functions are using by-reference parameters and if we are declaring them properly ?
I really think it's the correct way. If we can guarantee that by-reference parameters are properly declared... then we should delete that check because for sure... will be dropped from PHP someday (or can be off by default in a lot of sites).
http://es2.php.net/manual/en/ini.core.php
Ciao 
Fixed in 1.8, 1.9 and HEAD, thanks James, feel free to reopen if any problem arises.