Issue Details (XML | Word | Printable)

Key: MDL-7436
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Nick Freear
Reporter: Martin Dougiamas
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-7396

Indicate type of resource in the name of the resource

Created: 10/Nov/06 02:52 PM   Updated: 21/Nov/07 07:50 PM
Return to search
Component/s: Accessibility, Resource
Affects Version/s: 1.7
Fix Version/s: 1.8.3, 1.9

File Attachments: 1. File patch-MDL-7436-course-lib-screenreader-no-6mime.diff (5 kB)

Issue Links:
Blockers
 
Relates
 

Participants: Chetz Colwell, Martin Dougiamas, Nick Freear, Petr Skoda and Yu Zhang
Security Level: None
Resolved date: 25/Sep/07
Affected Branches: MOODLE_17_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE


 Description  « Hide
Where icons are used to indicate the type of resource or the destination of a link this needs to be conveyed to screen-reader users in the link text. E.g. <pdf icon> <link: interesting article (PDF)>. (It is not necessary to add anything when it is clear from the text link, e.g. "news forum".) P1. Note it is not sufficient to just add alt text to these icons to convey this information because when screen-readers create a list of links the images will not be included and so the information will not be available in that context.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda added a comment - 23/Nov/06 05:33 PM
maybe the description could be hidden, possible solution described in http://www.webaim.org/techniques/css/invisiblecontent/

Yu Zhang added a comment - 28/Nov/06 10:24 AM
Added the type of the resource in the text link. This will show if the user sets his screenreader setting. I think it is also possible to include the icons into the link so that they get displayed together, and since the icons have alt tag it would also solve this problem?

Chetz Colwell added a comment - 18/Dec/06 08:08 PM
Please can you send me a url where I can see how you have implemented this?
Thanks, Chetz

Yu Zhang added a comment - 19/Dec/06 08:41 AM
Hi Chetz,

In 1.8, go to your profile, set Screenreader to true, and return to any course home page, you will see resource types in brackets.

Cheers,

Yu


Nick Freear added a comment - 25/Sep/07 01:23 AM
Reopened - the "screenreader" flag is bad, and in this case unnecessary:

Nick Freear added a comment - 25/Sep/07 01:34 AM
Partial fix in HEAD and 1.8 branch, because 1.8.3 is imminent.

IMPORTANT: not complete!


Nick Freear added a comment - 25/Sep/07 10:55 PM
Hopefully the definitive patch, affecting 3 files, tested in Firefox, IE, JAWS:
  • theme/standard/styles_font.css - fix icon/link underline via class "img-text"
  • lib/filelib.php - new "mimeinfo_from_icon" function.
  • course/lib.php, several points:
    1. For file resources get description ALT text via icon.
    2. If this description is contained in the $instancename text make ALT empty - avoid duplication.
    3. The TITLE is unnecessary for <a /> link.
    4. Image has empty TITLE to suppress IE tooltip - so all links match.

Nick Freear added a comment - 25/Sep/07 11:47 PM
I have committed the patch above to HEAD/ 1.9 and 1.8 branches.
Some points:
  • I deemed it important for 1.8.3 because the original fix, using the "screenreader" flag (MDL-7487, MDL-11348) was so broken,
  • Finally screen reader users see the type of a file,
  • And avoid unnecessary duplication, including in the link TITLE!
  • This solution needed creative thinking, and Chetz's help!

Nick Freear added a comment - 26/Sep/07 12:23 AM
Some examples, including for MDL-11161:
  • [Forum icon] News forum - duplicate, empty ALT, JAWS says "...link News forum".
  • [Resource icon] A random web page - JAWS says "...link graphic Resource A random web page..." (or language equivalent!)
  • [Resource icon] Course resource - duplicate, empty ALT, JAWS says "... link Course resource..." (or lang...)
  • [Word icon] Course introduction - JAWS says "... link graphic Word document Course introduction..." (or lang...)

Nick Freear added a comment - 02/Oct/07 05:48 PM
Further fix applied under MDL-11161. The above examples now are:
  • [Forum icon] News forum - duplicate, empty ALT, JAWS says "...link News forum".
  • [Resource icon] A random web page - JAWS says "...link A random web page Resource" (or language equivalent!) - hidden text.
    ...
  • [Word icon] Course introduction - JAWS says "... link Course introduction Word document" (or lang...) - hidden text.

Nick Freear added a comment - 21/Nov/07 07:50 PM
(Add 1.9 meta-bug link.)