Moodle

Indicate type of resource in the name of the resource

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.7
  • Fix Version/s: 1.8.3, 1.9
  • Component/s: Accessibility, Resource
  • Labels:
    None
  • Affected Branches:
    MOODLE_17_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE

Description

Where icons are used to indicate the type of resource or the destination of a link this needs to be conveyed to screen-reader users in the link text. E.g. <pdf icon> <link: interesting article (PDF)>. (It is not necessary to add anything when it is clear from the text link, e.g. "news forum".) P1. Note it is not sufficient to just add alt text to these icons to convey this information because when screen-readers create a list of links the images will not be included and so the information will not be available in that context.

Issue Links

This issue blocks:
MDL-12298 META BUG: Accessibility improvements in Moodle 1.9 Major Closed
This issue has been marked as being related by:
MDL-11161 Activity type text added to beginning of activity links in Screen Reader mode moved to end of links Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda (skodak) added a comment -

maybe the description could be hidden, possible solution described in http://www.webaim.org/techniques/css/invisiblecontent/

Show
Petr Škoda (skodak) added a comment - maybe the description could be hidden, possible solution described in http://www.webaim.org/techniques/css/invisiblecontent/
Hide
Permalink
Yu Zhang added a comment -

Added the type of the resource in the text link. This will show if the user sets his screenreader setting. I think it is also possible to include the icons into the link so that they get displayed together, and since the icons have alt tag it would also solve this problem?

Show
Yu Zhang added a comment - Added the type of the resource in the text link. This will show if the user sets his screenreader setting. I think it is also possible to include the icons into the link so that they get displayed together, and since the icons have alt tag it would also solve this problem?
Hide
Permalink
Chetz Colwell added a comment -

Please can you send me a url where I can see how you have implemented this?
Thanks, Chetz

Show
Chetz Colwell added a comment - Please can you send me a url where I can see how you have implemented this? Thanks, Chetz
Hide
Permalink
Yu Zhang added a comment -

Hi Chetz,

In 1.8, go to your profile, set Screenreader to true, and return to any course home page, you will see resource types in brackets.

Cheers,

Yu

Show
Yu Zhang added a comment - Hi Chetz, In 1.8, go to your profile, set Screenreader to true, and return to any course home page, you will see resource types in brackets. Cheers, Yu
Hide
Permalink
Nick Freear added a comment -

Reopened - the "screenreader" flag is bad, and in this case unnecessary:

Show
Nick Freear added a comment - Reopened - the "screenreader" flag is bad, and in this case unnecessary:
Hide
Permalink
Nick Freear added a comment -

Partial fix in HEAD and 1.8 branch, because 1.8.3 is imminent.

IMPORTANT: not complete!

Show
Nick Freear added a comment - Partial fix in HEAD and 1.8 branch, because 1.8.3 is imminent. IMPORTANT: not complete!
Hide
Permalink
Nick Freear added a comment -

Hopefully the definitive patch, affecting 3 files, tested in Firefox, IE, JAWS:

  • theme/standard/styles_font.css - fix icon/link underline via class "img-text"
  • lib/filelib.php - new "mimeinfo_from_icon" function.
  • course/lib.php, several points:
    1. For file resources get description ALT text via icon.
    2. If this description is contained in the $instancename text make ALT empty - avoid duplication.
    3. The TITLE is unnecessary for <a /> link.
    4. Image has empty TITLE to suppress IE tooltip - so all links match.
Show
Nick Freear added a comment - Hopefully the definitive patch, affecting 3 files, tested in Firefox, IE, JAWS:
  • theme/standard/styles_font.css - fix icon/link underline via class "img-text"
  • lib/filelib.php - new "mimeinfo_from_icon" function.
  • course/lib.php, several points: 1. For file resources get description ALT text via icon. 2. If this description is contained in the $instancename text make ALT empty - avoid duplication. 3. The TITLE is unnecessary for <a /> link. 4. Image has empty TITLE to suppress IE tooltip - so all links match.
Hide
Permalink
Nick Freear added a comment -

I have committed the patch above to HEAD/ 1.9 and 1.8 branches.
Some points:

  • I deemed it important for 1.8.3 because the original fix, using the "screenreader" flag (MDL-7487, MDL-11348) was so broken,
  • Finally screen reader users see the type of a file,
  • And avoid unnecessary duplication, including in the link TITLE!
  • This solution needed creative thinking, and Chetz's help!
Show
Nick Freear added a comment - I have committed the patch above to HEAD/ 1.9 and 1.8 branches. Some points:
  • I deemed it important for 1.8.3 because the original fix, using the "screenreader" flag (MDL-7487, MDL-11348) was so broken,
  • Finally screen reader users see the type of a file,
  • And avoid unnecessary duplication, including in the link TITLE!
  • This solution needed creative thinking, and Chetz's help!
Hide
Permalink
Nick Freear added a comment -

Some examples, including for MDL-11161:

  • [Forum icon] News forum - duplicate, empty ALT, JAWS says "...link News forum".
  • [Resource icon] A random web page - JAWS says "...link graphic Resource A random web page..." (or language equivalent!)
  • [Resource icon] Course resource - duplicate, empty ALT, JAWS says "... link Course resource..." (or lang...)
  • [Word icon] Course introduction - JAWS says "... link graphic Word document Course introduction..." (or lang...)
Show
Nick Freear added a comment - Some examples, including for MDL-11161:
  • [Forum icon] News forum - duplicate, empty ALT, JAWS says "...link News forum".
  • [Resource icon] A random web page - JAWS says "...link graphic Resource A random web page..." (or language equivalent!)
  • [Resource icon] Course resource - duplicate, empty ALT, JAWS says "... link Course resource..." (or lang...)
  • [Word icon] Course introduction - JAWS says "... link graphic Word document Course introduction..." (or lang...)
Hide
Permalink
Nick Freear added a comment -

Further fix applied under MDL-11161. The above examples now are:

  • [Forum icon] News forum - duplicate, empty ALT, JAWS says "...link News forum".
  • [Resource icon] A random web page - JAWS says "...link A random web page Resource" (or language equivalent!) - hidden text.
    ...
  • [Word icon] Course introduction - JAWS says "... link Course introduction Word document" (or lang...) - hidden text.
Show
Nick Freear added a comment - Further fix applied under MDL-11161. The above examples now are:
  • [Forum icon] News forum - duplicate, empty ALT, JAWS says "...link News forum".
  • [Resource icon] A random web page - JAWS says "...link A random web page Resource" (or language equivalent!) - hidden text. ...
  • [Word icon] Course introduction - JAWS says "... link Course introduction Word document" (or lang...) - hidden text.
Hide
Permalink
Nick Freear added a comment -

(Add 1.9 meta-bug link.)

Show
Nick Freear added a comment - (Add 1.9 meta-bug link.)

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.