[#MDL-7437] BIG: Extend HTML editor so it can "tag" passages as text with language - Moodle Tracker

Details

Type: Sub-task
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 1.7
Fix Version/s: 1.8
Component/s: Accessibility, HTML Editor
Labels:
None

Affected Branches:
MOODLE_17_STABLE
Fixed Branches:
MOODLE_18_STABLE

Description

Changes in language should be marked up appropriately, especially e.g. in language teaching. This will allow screenreaders to switch languages accordingly and speak with the correct pronunciation.

The HTML editor should make it easy to mark certain languages for this purpose (and also for multilang texts).

Issue Links

This issue has been marked as being related by:
MDL-7887	Multilang upgrade to new tags in Moodle 1.8

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Petr Škoda (skodak) added a comment - 01/Dec/06 6:20 AM

There is a small problem with lang attribute: if somebody uses ?esky in english without multilang filter both would be visible, with it only one of them. This might confuse people that know nothing about our multilang implementation. If there is only one or <lang> tag, it works as expected.

Show

Petr Škoda (skodak) added a comment - 01/Dec/06 6:20 AM There is a small problem with lang attribute: if somebody uses ?esky in english without multilang filter both would be visible, with it only one of them. This might confuse people that know nothing about our multilang implementation. If there is only one or <lang> tag, it works as expected.

Hide

Permalink

Martin Dougiamas added a comment - 06/Dec/06 12:38 PM

Yes, this is a tricky problem. blah is the best correct way to mark up text that is meant to be in a specific language, and such tags are not broken by the HTML editor. The proper solution for this bug is to mark up text that way.

However, like Petr said, there will be confusion with our multilang implementation, which uses the same tag. (Note that the <lang lang="es"></lang> form is obsolete and should not be used at all, we support it only for backward compatibility). As above, I think this tag makes good sense to use for this purpose so that when those texts end up in non-filtered circumstances they still work.

So we need something else to distinguish multilang text from other normal text that may contain multiple languages.

Should we perhaps add a class to one of them?

?

Show

Martin Dougiamas added a comment - 06/Dec/06 12:38 PM Yes, this is a tricky problem. blah is the best correct way to mark up text that is meant to be in a specific language, and such tags are not broken by the HTML editor. The proper solution for this bug is to mark up text that way. However, like Petr said, there will be confusion with our multilang implementation, which uses the same tag. (Note that the <lang lang="es"></lang> form is obsolete and should not be used at all, we support it only for backward compatibility). As above, I think this tag makes good sense to use for this purpose so that when those texts end up in non-filtered circumstances they still work. So we need something else to distinguish multilang text from other normal text that may contain multiple languages. Should we perhaps add a class to one of them? or ?

Hide

Permalink

Martin Dougiamas added a comment - 06/Dec/06 12:47 PM

Thinking further, the menu could contain two lists of languages, the first as normal and the second as "language-dependent text" (multilang).

Selecting from the first would just insert the normal span tags.

Selecting from the second would insert the span with a "multilang" class in it.

Then we'd need to:

1) Modify the filter to only work when

there is more than one language section in the text
the multilang class is used.

2) For backward compatibility, search/replace the database for any occurrences of the old multilang tags and fix them up.

How does that sound?

Show

Martin Dougiamas added a comment - 06/Dec/06 12:47 PM Thinking further, the menu could contain two lists of languages, the first as normal and the second as "language-dependent text" (multilang). Selecting from the first would just insert the normal span tags. Selecting from the second would insert the span with a "multilang" class in it. Then we'd need to: 1) Modify the filter to only work when

there is more than one language section in the text
the multilang class is used.

2) For backward compatibility, search/replace the database for any occurrences of the old multilang tags and fix them up. How does that sound?

Hide

Permalink

Vy-Shane Sin Fat added a comment - 08/Dec/06 12:48 PM

I've just checked in a fix for the editor.

The editor now has a language drop down that allows the user to tag (via spans) content as being in different languages. E.g:

Bonjour!

The above will tag the "Bonjour!" as French. If we want to tag a selection for the multilang filter, the format is:

Bonjour!

We still need to fix the old multilang tags.

Show

Vy-Shane Sin Fat added a comment - 08/Dec/06 12:48 PM I've just checked in a fix for the editor. The editor now has a language drop down that allows the user to tag (via spans) content as being in different languages. E.g: Bonjour! The above will tag the "Bonjour!" as French. If we want to tag a selection for the multilang filter, the format is: Bonjour! We still need to fix the old multilang tags.

Hide

Permalink

Martin Dougiamas added a comment - 11/Dec/06 9:34 PM

This issue is fixed, I'll file a new one about adding the multilang class to old multilang tags.

Show

Martin Dougiamas added a comment - 11/Dec/06 9:34 PM This issue is fixed, I'll file a new one about adding the multilang class to old multilang tags.

People

Assignee:

Vy-Shane Sin Fat

Reporter:

Martin Dougiamas

Tester:

Nobody

Participants:

Martin Dougiamas, Petr Škoda (skodak), Vy-Shane Sin Fat

Vote (1)

Watch (3)

Dates

Created:

10/Nov/06 2:56 PM

Updated:

17/Dec/10 1:23 PM

Resolved:

11/Dec/06 9:34 PM