Moodle

Ensure all table headers are marked up with 'th'

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.7
  • Fix Version/s: 1.8
  • Component/s: Accessibility
  • Labels:
    None
  • Affected Branches:
    MOODLE_17_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE

Description

Ensure ALL table headers are marked up with 'th'.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda (skodak) added a comment -

I have reviewed places where <table is used, I think that all table-like use has correct 'th' now, closing. Please reopen if you find a missed one

Show
Petr Škoda (skodak) added a comment - I have reviewed places where <table is used, I think that all table-like use has correct 'th' now, closing. Please reopen if you find a missed one
Hide
Permalink
Nick Freear added a comment -

Hi Petr,

I think in the case of cvs:/admin/roles/assign.html - a layout table, <th> may not be the best solution - see my bug, MDL-7721. The patch includes <label> elements.

Show
Nick Freear added a comment - Hi Petr, I think in the case of cvs:/admin/roles/assign.html - a layout table, <th> may not be the best solution - see my bug, MDL-7721. The patch includes <label> elements.
Hide
Permalink
Nick Freear added a comment -

<TH> is for data tables NOT layout ones, and where you're applying it you should also look at <th scope="col">,

http://www.w3.org/TR/html40/struct/tables.html#h-11.2.6

Hope this helps. Must dash!

Show
Nick Freear added a comment - <TH> is for data tables NOT layout ones, and where you're applying it you should also look at <th scope="col">, http://www.w3.org/TR/html40/struct/tables.html#h-11.2.6 Hope this helps. Must dash!
Hide
Permalink
Petr Škoda (skodak) added a comment -

Hi Nick, thanks for the info - sorry for the mess, I am learning every day something new about accessibility please be patient with me
I have changed the form layout tables - added the label element instead of the th (blog tabs, lang import, child courses and groups definition). I have tested it with JAWS a bit too. Is it ok now?

Show
Petr Škoda (skodak) added a comment - Hi Nick, thanks for the info - sorry for the mess, I am learning every day something new about accessibility please be patient with me I have changed the form layout tables - added the label element instead of the th (blog tabs, lang import, child courses and groups definition). I have tested it with JAWS a bit too. Is it ok now?
Hide
Permalink
Nick Freear added a comment -

Hi Petr, no need to apologise - I'm learning too!

Only had time to look at cvs:/admin/langimport.php so far - labels are an improvement. I've attached a patch which also fixes markup errors, removes unnecessary tables, and table-cells (when you linearise a table you have to ask if it makes sense - I moved the <label>s closer to their <input>s).

I'm using the HTML Validator Firefox extension, http://users.skynet.be/mgueury/mozilla/
(It's annoying the way it calls errors it can fix 'warnings', but at least gives you instantaneous validation.)
Also, Web Developer extension, Fangs ... will add more here, http://docs.moodle.org/en/Category:Developer_tools

Show
Nick Freear added a comment - Hi Petr, no need to apologise - I'm learning too! Only had time to look at cvs:/admin/langimport.php so far - labels are an improvement. I've attached a patch which also fixes markup errors, removes unnecessary tables, and table-cells (when you linearise a table you have to ask if it makes sense - I moved the <label>s closer to their <input>s). I'm using the HTML Validator Firefox extension, http://users.skynet.be/mgueury/mozilla/ (It's annoying the way it calls errors it can fix 'warnings', but at least gives you instantaneous validation.) Also, Web Developer extension, Fangs ... will add more here, http://docs.moodle.org/en/Category:Developer_tools
Hide
Permalink
Petr Škoda (skodak) added a comment -

closing again, major problems should be fixed - please reopen if needed, thanks!

Show
Petr Škoda (skodak) added a comment - closing again, major problems should be fixed - please reopen if needed, thanks!

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.