[#MDL-7474] Provide alt text for ascending/ descending icons in glossary

Issue Details (XML | Word | Printable)

Key:	MDL-7474
Type:	Sub-task
Status:	Closed
Resolution:	Fixed
Priority:	Minor
Assignee:	Dongsheng Cai
Reporter:	Martin Dougiamas
Votes:	0
Watchers:	3

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-7396

Provide alt text for ascending/ descending icons in glossary

Created: 13/Nov/06 12:53 AM Updated: 30/Apr/08 12:34 AM

Return to search

Component/s:

Accessibility, Glossary

Affects Version/s:

1.7

Fix Version/s:

1.8.6, 1.9.1

File Attachments:

patch-MDL-7474-glossary-sortorder.diff (5 kB)

Issue Links:

Blockers

This issue blocks:

~~MDL-12298~~ META BUG: Accessibility improvements in Moodle 1.9

URL:	http://moodle.org/mod/glossary/view.php?id=2334&mode=date
Participants:	Dongsheng Cai, Eloy Lafuente (stronk7), Martin Dougiamas, Michael Penney, Nick Freear and Yu Zhang
Security Level:	None
QA Assignee:	Eloy Lafuente (stronk7)
Resolved date:	23/Apr/08
Affected Branches:	MOODLE_17_STABLE
Fixed Branches:	MOODLE_18_STABLE, MOODLE_19_STABLE

Description

« Hide

Glossary: provide alt text for the 'ascending' and 'descending' icons as this information is currently not available to a screen-reader. Combine the text link with the image link so that they are read together by a screen-reader. Note: Do not rely on <title> to convey this information because this is not read by default by screen-readers.

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Yu Zhang added a comment - 13/Nov/06 10:21 AM

fixed

[ Permalink | « Hide ]

Nick Freear added a comment - 20/Sep/07 12:26 AM

Reopening as there are several problems:

There is still an ALT text missing in the PHP code (mod/glossary/lib.php glossary_print_sorting_links function)
There is no non-visual representation of the current sort - denoted in bold.
At present the ALT text matches the icon, eg "ascending" but not the link title "By last update (descending)" - thanks Chetz - a golden rule is to make image ALT text plus other link text match the optional link TITLE.
There is confusion in user-logic (not code logic) in that the icon in the link shows the current sort - ascending is an UP arrow, while the purpose of the link is to change the sort, to descending.

I will attach a patch to discuss. Thanks Nick

Example - Moodle Features,
http://moodle.org/mod/glossary/view.php?id=2334&mode=date

[ Permalink | « Hide ]

Nick Freear added a comment - 20/Sep/07 12:37 AM

The attached patch affects 2 files, including the language file, lang/en_utf8/glossary.php

I do NOT consider this a final solution - please discuss!
It attempts to fix all problems listed above.
It adds a current sort "accesshide" phrase before "Sort chronologically:", for example "Currently sorted By last update ascending"
It changes the title (and text), for example from "By last update (descending)" to "By last update change to descending".
It is a bit wordy for screen readers - ideas?
(I've got rid of the brackets "Left paren ...right paren".)

Many thanks Nick

[ Permalink | « Hide ]

Nick Freear added a comment - 25/Sep/07 01:34 AM

Partial fix in HEAD and 1.8 branch, using the patch, because 1.8.3 is imminent.

IMPORTANT: not complete!

[ Permalink | « Hide ]

Nick Freear added a comment - 21/Nov/07 09:06 PM

(Adding link to 1.9 meta-bug.)

[ Permalink | « Hide ]

Michael Penney added a comment - 25/Jan/08 02:54 AM

Is this going to be fixed in 1.9 or 2.0?

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 17/Apr/08 10:14 AM

Hi Dongsheng,

can you see how is this working under 1.9.1. Are alts for those icons available? Also see the proposed patch... and comment about it here, plz.. ciao

[ Permalink | « Hide ]

Dongsheng Cai added a comment - 17/Apr/08 04:46 PM

I checked <img> tags in mod/glossary of MOODLE_19_STABLE and HEAD, they all have alt text now, the patch solved the issues, in addition, it changed the title text and alt text to make them more clear, but why Nick said it is not complete?

[ Permalink | « Hide ]

Dongsheng Cai added a comment - 18/Apr/08 10:20 AM

Eloy, Can I "Resolve" this issue now?

[ Permalink | « Hide ]

Dongsheng Cai added a comment - 22/Apr/08 12:01 PM

Eloy, I added you in the watching list now, can you please have a look?
Thanks

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 23/Apr/08 06:31 AM

Yup please!

Also, if it was fixed in 18_STABLE and it's also applied in 19_STABLE and HEAD... I think it's a good idea to change the "fix for" to the correct versions (do you remember the strategy for this?) while resolving the bug.

Thanks!

[ Permalink | « Hide ]

Dongsheng Cai added a comment - 23/Apr/08 09:47 AM

This issue has been resolved, feel free to reopen it if you find any problem.

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 30/Apr/08 12:34 AM

Confirmed. Closing.

All content on this web site is made available under the GNU General Public License, unless otherwise stated.