Moodle

Provide alt text for ascending/ descending icons in glossary

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.7
  • Fix Version/s: 1.8.6, 1.9.1
  • Component/s: Accessibility, Glossary
  • Labels:
    None

Description

Glossary: provide alt text for the 'ascending' and 'descending' icons as this information is currently not available to a screen-reader. Combine the text link with the image link so that they are read together by a screen-reader. Note: Do not rely on <title> to convey this information because this is not read by default by screen-readers.

Issue Links

This issue blocks:
MDL-12298 META BUG: Accessibility improvements in Moodle 1.9 Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Yu Zhang added a comment -

fixed

Show
Yu Zhang added a comment - fixed
Hide
Permalink
Nick Freear added a comment -

Reopening as there are several problems:

  • There is still an ALT text missing in the PHP code (mod/glossary/lib.php glossary_print_sorting_links function)
  • There is no non-visual representation of the current sort - denoted in bold.
  • At present the ALT text matches the icon, eg "ascending" but not the link title "By last update (descending)" - thanks Chetz - a golden rule is to make image ALT text plus other link text match the optional link TITLE.
  • There is confusion in user-logic (not code logic) in that the icon in the link shows the current sort - ascending is an UP arrow, while the purpose of the link is to change the sort, to descending.

I will attach a patch to discuss. Thanks Nick

Example - Moodle Features,
http://moodle.org/mod/glossary/view.php?id=2334&mode=date

Show
Nick Freear added a comment - Reopening as there are several problems:
  • There is still an ALT text missing in the PHP code (mod/glossary/lib.php glossary_print_sorting_links function)
  • There is no non-visual representation of the current sort - denoted in bold.
  • At present the ALT text matches the icon, eg "ascending" but not the link title "By last update (descending)" - thanks Chetz - a golden rule is to make image ALT text plus other link text match the optional link TITLE.
  • There is confusion in user-logic (not code logic) in that the icon in the link shows the current sort - ascending is an UP arrow, while the purpose of the link is to change the sort, to descending.
I will attach a patch to discuss. Thanks Nick Example - Moodle Features, http://moodle.org/mod/glossary/view.php?id=2334&mode=date
Hide
Permalink
Nick Freear added a comment -

The attached patch affects 2 files, including the language file, lang/en_utf8/glossary.php

  • I do NOT consider this a final solution - please discuss!
  • It attempts to fix all problems listed above.
  • It adds a current sort "accesshide" phrase before "Sort chronologically:", for example "Currently sorted By last update ascending"
  • It changes the title (and text), for example from "By last update (descending)" to "By last update change to descending".
  • It is a bit wordy for screen readers - ideas?
    (I've got rid of the brackets "Left paren ...right paren".)

Many thanks Nick

Show
Nick Freear added a comment - The attached patch affects 2 files, including the language file, lang/en_utf8/glossary.php
  • I do NOT consider this a final solution - please discuss!
  • It attempts to fix all problems listed above.
  • It adds a current sort "accesshide" phrase before "Sort chronologically:", for example "Currently sorted By last update ascending"
  • It changes the title (and text), for example from "By last update (descending)" to "By last update change to descending".
  • It is a bit wordy for screen readers - ideas? (I've got rid of the brackets "Left paren ...right paren".)
Many thanks Nick
Hide
Permalink
Nick Freear added a comment -

Partial fix in HEAD and 1.8 branch, using the patch, because 1.8.3 is imminent.

IMPORTANT: not complete!

Show
Nick Freear added a comment - Partial fix in HEAD and 1.8 branch, using the patch, because 1.8.3 is imminent. IMPORTANT: not complete!
Hide
Permalink
Nick Freear added a comment -

(Adding link to 1.9 meta-bug.)

Show
Nick Freear added a comment - (Adding link to 1.9 meta-bug.)
Hide
Permalink
Michael Penney added a comment -

Is this going to be fixed in 1.9 or 2.0?

Show
Michael Penney added a comment - Is this going to be fixed in 1.9 or 2.0?
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Hi Dongsheng,

can you see how is this working under 1.9.1. Are alts for those icons available? Also see the proposed patch... and comment about it here, plz.. ciao

Show
Eloy Lafuente (stronk7) added a comment - Hi Dongsheng, can you see how is this working under 1.9.1. Are alts for those icons available? Also see the proposed patch... and comment about it here, plz.. ciao
Hide
Permalink
Dongsheng Cai added a comment -

I checked <img> tags in mod/glossary of MOODLE_19_STABLE and HEAD, they all have alt text now, the patch solved the issues, in addition, it changed the title text and alt text to make them more clear, but why Nick said it is not complete?

Show
Dongsheng Cai added a comment - I checked <img> tags in mod/glossary of MOODLE_19_STABLE and HEAD, they all have alt text now, the patch solved the issues, in addition, it changed the title text and alt text to make them more clear, but why Nick said it is not complete?
Hide
Permalink
Dongsheng Cai added a comment -

Eloy, Can I "Resolve" this issue now?

Show
Dongsheng Cai added a comment - Eloy, Can I "Resolve" this issue now?
Hide
Permalink
Dongsheng Cai added a comment -

Eloy, I added you in the watching list now, can you please have a look?
Thanks

Show
Dongsheng Cai added a comment - Eloy, I added you in the watching list now, can you please have a look? Thanks
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Yup please!

Also, if it was fixed in 18_STABLE and it's also applied in 19_STABLE and HEAD... I think it's a good idea to change the "fix for" to the correct versions (do you remember the strategy for this?) while resolving the bug.

Thanks!

Show
Eloy Lafuente (stronk7) added a comment - Yup please! Also, if it was fixed in 18_STABLE and it's also applied in 19_STABLE and HEAD... I think it's a good idea to change the "fix for" to the correct versions (do you remember the strategy for this?) while resolving the bug. Thanks!
Hide
Permalink
Dongsheng Cai added a comment -

This issue has been resolved, feel free to reopen it if you find any problem.

Show
Dongsheng Cai added a comment - This issue has been resolved, feel free to reopen it if you find any problem.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Confirmed. Closing.

Show
Eloy Lafuente (stronk7) added a comment - Confirmed. Closing.

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.