Issue Details (XML | Word | Printable)

Key: MDL-7493
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Nick Freear
Reporter: Martin Dougiamas
Votes: 1
Watchers: 7
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-7396

Make sure standard themes are visible under "Windows High Contrast Black" mode

Created: 13/Nov/06 02:28 PM   Updated: 09/Jan/08 08:24 AM
Return to search
Component/s: Accessibility, Themes
Affects Version/s: 1.7
Fix Version/s: 1.8.4, 1.9, 2.0

File Attachments: 1. File patch-MDL-7493-highcontrast-showhide-2.diff (0.6 kB)
2. File patch-MDL-7493-highcontrast-showhide-32js.diff (8 kB)
3. File patch-MDL-7493-highcontrast-showhide-41js.diff (8 kB)
4. File patch-MDL-7493-highcontrast-showhide-4js.diff (8 kB)
5. File patch-MDL-7493-theme-cleanup.diff (7 kB)

Image Attachments:

1. screen-1-ie6-high-contrast.jpg
(148 kB)
Issue Links:
Blockers
 
Dependency
 
Duplicate
 

Participants: Eloy Lafuente (stronk7), Martin Dougiamas, Nick Freear, Petr Skoda, Urs Hunkler, Vy-Shane Sin Fat and Yu Zhang
Security Level: None
Resolved date: 21/Dec/07
Affected Branches: MOODLE_17_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE


 Description  « Hide
Make sure standard themes are visible under "Windows High Contrast Black" mode

There are reports of some buttons not showing. - Show/ hide (plus/minus) sideblock buttons.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Vy-Shane Sin Fat committed 1 file to 'Moodle CVS' - 11/Dec/06 04:10 PM
Fix for MDL-7493.
We basically replace the plus and minus hide buttons when the elementToggleHide javascript function is called.
MODIFY lib/javascript-static.js   Rev. 1.19    (+6 -5 lines)
Vy-Shane Sin Fat committed 1 file to 'Moodle CVS' - 11/Dec/06 04:15 PM
Fix for MDL-7493. Added html id attribute for the image button used to toggle hide and show for blocks. This is used by javascript to replace the image on the fly.
MODIFY blocks/moodleblock.class.php   Rev. 1.75    (+8 -12 lines)
Nick Freear committed 1 file to 'Moodle CVS' - 25/Sep/07 12:39 AM
Partial fix reopened for MDL-7493, Accessibility: Make sure 'Show hide block' button-link visible under Windows High Contrast.
MODIFY theme/standard/styles_color.css   Rev. 1.147    (+5 -0 lines)
Nick Freear committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 25/Sep/07 12:44 AM
Partial fix reopened for MDL-7493, Accessibility: Make sure 'Show hide block' button-link visible under Windows High Contrast.
MODIFY theme/standard/styles_color.css   Rev. 1.128.2.10    (+4 -0 lines)
Nick Freear committed 8 files to 'Moodle CVS' - 19/Dec/07 02:18 AM
Fixes reopened MDL-7493 "Make sure standard themes are visible under "Windows High Contrast Black" mode" - foreground show/hide block icon/ALT text switched with Javscript.
MODIFY theme/standard/styles_layout.css   Rev. 1.541    (+2 -5 lines)
MODIFY theme/standard/styles_color.css   Rev. 1.158    (+1 -14 lines)
MODIFY pix/t/switch_plus.gif   Rev. 1.2    (+0 -0 lines)
MODIFY lib/javascript-static.js   Rev. 1.41    (+17 -7 lines)
MODIFY pix/t/switch_minus.gif   Rev. 1.2    (+0 -0 lines)
MODIFY lib/weblib.php   Rev. 1.1008    (+10 -8 lines)
MODIFY blocks/moodleblock.class.php   Rev. 1.95    (+12 -12 lines)
MODIFY lang/en_utf8/access.php   Rev. 1.10    (+3 -2 lines)
Nick Freear committed 8 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 19/Dec/07 02:25 AM
Fixes reopened MDL-7493... - foreground show/hide block icon/ALT text switched with Javscript. Merged.
MODIFY lib/weblib.php   Rev. 1.970.2.35    (+10 -8 lines)
MODIFY lib/javascript-static.js   Rev. 1.39.2.2    (+17 -7 lines)
MODIFY pix/t/switch_minus.gif   Rev. 1.1.22.1    (+0 -0 lines)
MODIFY lang/en_utf8/access.php   Rev. 1.8.2.2    (+3 -2 lines)
MODIFY theme/standard/styles_layout.css   Rev. 1.516.2.23    (+1 -4 lines)
MODIFY theme/standard/styles_color.css   Rev. 1.149.2.7    (+0 -13 lines)
MODIFY blocks/moodleblock.class.php   Rev. 1.92.2.2    (+12 -12 lines)
MODIFY pix/t/switch_plus.gif   Rev. 1.1.22.1    (+0 -0 lines)
Nick Freear committed 8 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 19/Dec/07 02:43 AM
Fixes reopened MDL-7493... - foreground show/hide block icon/ALT text switched with Javscript. Merged.
MODIFY pix/t/switch_minus.gif   Rev. 1.1.20.1    (+0 -0 lines)
MODIFY theme/standard/styles_layout.css   Rev. 1.365.2.82    (+1 -4 lines)
MODIFY lib/javascript-static.js   Rev. 1.29.2.6    (+17 -7 lines)
MODIFY pix/t/switch_plus.gif   Rev. 1.1.20.1    (+0 -0 lines)
MODIFY lib/weblib.php   Rev. 1.812.2.93    (+9 -6 lines)
MODIFY blocks/moodleblock.class.php   Rev. 1.79.2.8    (+13 -13 lines)
MODIFY lang/en_utf8/access.php   Rev. 1.6.4.3    (+3 -2 lines)
MODIFY theme/standard/styles_color.css   Rev. 1.128.2.12    (+0 -9 lines)
Mitsuhiro Yoshida committed 4 files to 'Lang CVS' - 19/Dec/07 08:18 AM
Translated new strings for show/hide block icon/ALT text MDL-7493.
Translated new strings for new config option for mail newline chars MDL-12103.
Translated a new string for quiz grading MDL-12635.
MODIFY ja_utf8/admin.php   Rev. 1.223    (+2 -0 lines)
MODIFY ja_utf8/README   Rev. 1.597    (+1 -1 lines)
MODIFY ja_utf8/access.php   Rev. 1.11    (+4 -2 lines)
MODIFY ja_utf8/quiz_grading.php   Rev. 1.5    (+2 -1 lines)
Nick Freear committed 2 files to 'Moodle CVS' - 19/Dec/07 10:25 PM
Followup for MDL-7493... - revert images to fix transparency, and improve contrast in Windows High Contrast Black mode.
MODIFY pix/t/switch_plus.gif   Rev. 1.3    (+0 -0 lines)
MODIFY pix/t/switch_minus.gif   Rev. 1.3    (+0 -0 lines)
Nick Freear committed 2 files to 'Moodle CVS' - 19/Dec/07 10:35 PM
Followup for MDL-7493... - Finally the correct images! fix transparency, and improve contrast in Windows High Contrast Black mode.
MODIFY pix/t/switch_plus.gif   Rev. 1.4    (+0 -0 lines)
MODIFY pix/t/switch_minus.gif   Rev. 1.4    (+0 -0 lines)
Nick Freear committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 19/Dec/07 10:39 PM
Followup for MDL-7493... - Finally the correct images! fix transparency, and improve contrast in Windows High Contrast Black mode. Merged.
MODIFY pix/t/switch_plus.gif   Rev. 1.1.22.2    (+0 -0 lines)
MODIFY pix/t/switch_minus.gif   Rev. 1.1.22.2    (+0 -0 lines)
Nick Freear committed 2 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 19/Dec/07 10:41 PM
Followup for MDL-7493... - Finally the correct images! fix transparency, and improve contrast in Windows High Contrast Black mode. Merged.
MODIFY pix/t/switch_plus.gif   Rev. 1.1.20.2    (+0 -0 lines)
MODIFY pix/t/switch_minus.gif   Rev. 1.1.20.2    (+0 -0 lines)
moodler committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 20/Dec/07 10:50 AM
MDL-7493 further fix: strip_tags from title strings because the titles may have HTML in them.
MODIFY blocks/moodleblock.class.php   Rev. 1.92.2.3    (+4 -4 lines)
moodler committed 1 file to 'Moodle CVS' - 20/Dec/07 10:51 AM
Merged MDL-7493 further fix: strip_tags from title strings because the titles may have HTML in them.
MODIFY blocks/moodleblock.class.php   Rev. 1.96    (+4 -4 lines)
martignoni committed 1 file to 'Lang CVS' - 20/Dec/07 11:52 PM
Fixes reopened MDL-7493 "Make sure standard themes are visible under "Windows High Contrast Black" mode" - foreground show/hide block icon/ALT text switched with Javscript.
MODIFY fr_utf8/access.php   Rev. 1.9    (+6 -3 lines)
Nick Freear committed 1 file to 'Moodle CVS' - 21/Dec/07 08:12 PM
MDL-7493 further fix: strip_tags from title strings because the titles may have HTML in them.
  -From Martin D/moodler in moodleblock.class.php - thanks.
MODIFY lib/weblib.php   Rev. 1.1011    (+4 -4 lines)
Nick Freear committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 21/Dec/07 08:28 PM
Merged MDL-7493 further fix: strip_tags from title strings because the titles may have HTML in them.
  -From Martin D/moodler in moodleblock.class.php - thanks.
MODIFY lib/weblib.php   Rev. 1.970.2.39    (+4 -4 lines)
Nick Freear committed 2 files to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 21/Dec/07 08:32 PM
Merged MDL-7493 further fix: strip_tags from title strings because the titles may have HTML in them.
  -From Martin D/moodler in moodleblock.class.php - thanks.
MODIFY blocks/moodleblock.class.php   Rev. 1.79.2.9    (+4 -4 lines)
MODIFY lib/weblib.php   Rev. 1.812.2.94    (+4 -4 lines)
Nick Freear committed 10 files to 'Moodle CVS' - 21/Dec/07 08:58 PM
MDL-7493 further fix: clean up themes, and remove references to 'hide-show-image' background images. Document smartpix for theming icons in wood and orangewhite readmes.
MODIFY theme/wood/README.html   Rev. 1.3    (+5 -1 lines)
MODIFY theme/orangewhite/styles_layout.css   Rev. 1.42    (+1 -1 lines)
MODIFY theme/orangewhite/styles_color.css   Rev. 1.34    (+0 -6 lines)
MODIFY theme/custom_corners/user_styles.css   Rev. 1.28    (+1 -8 lines)
MODIFY theme/chameleon/user_styles.css   Rev. 1.11    (+2 -6 lines)
MODIFY theme/wood/styles_color.css   Rev. 1.40    (+1 -9 lines)
MODIFY theme/metal/colors.css   Rev. 1.6    (+0 -8 lines)
MODIFY theme/orangewhite/README.html   Rev. 1.3    (+2 -0 lines)
MODIFY theme/oceanblue/styles_color.css   Rev. 1.59    (+0 -13 lines)
MODIFY theme/formal_white/fw_color.css   Rev. 1.19    (+0 -8 lines)
Nick Freear committed 9 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 21/Dec/07 09:01 PM
Merged MDL-7493 further fix: clean up themes, and remove references to 'hide-show-image' background images. Document smartpix for theming icons in wood and orangewhite readmes.
MODIFY theme/wood/README.html   Rev. 1.2.20.1    (+5 -1 lines)
MODIFY theme/metal/colors.css   Rev. 1.5.2.1    (+0 -8 lines)
MODIFY theme/orangewhite/styles_layout.css   Rev. 1.41.4.1    (+1 -1 lines)
MODIFY theme/formal_white/fw_color.css   Rev. 1.18.2.1    (+0 -8 lines)
MODIFY theme/orangewhite/styles_color.css   Rev. 1.33.2.1    (+0 -6 lines)
MODIFY theme/orangewhite/README.html   Rev. 1.2.20.1    (+2 -0 lines)
MODIFY theme/chameleon/user_styles.css   Rev. 1.10.2.1    (+2 -6 lines)
MODIFY theme/wood/styles_color.css   Rev. 1.35.2.5    (+1 -9 lines)
MODIFY theme/custom_corners/user_styles.css   Rev. 1.11.2.16    (+1 -8 lines)