[#MDL-7589] Please remove the "simple" smileys

Issue Details (XML | Word | Printable)

Key:	MDL-7589
Type:	Improvement
Status:	Closed
Resolution:	Fixed
Priority:	Minor
Assignee:	Martin Dougiamas
Reporter:	Michael Schneider
Votes:	1
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Please remove the "simple" smileys

Created: 16/Nov/06 09:27 PM Updated: 15/Mar/09 10:00 AM

Return to search

Component/s:

General

Affects Version/s:

1.7

Fix Version/s:

1.9, 2.0

Environment:

1.7, Linux, Apache, MySQL

Issue Links:

Dependency

This issue will be resolved by:

~~MDL-10915~~ code for a "thumbs down" image not being filtered in LaTeX input

Database:	MySQL
Participants:	Dan Poltawski, Manish Verma, Martin Dougiamas, Michael Schneider, Nancy Webb and Stephen Bourget
Security Level:	None
QA Assignee:	Stephen Bourget
Resolved date:	16/Dec/07
Affected Branches:	MOODLE_17_STABLE
Fixed Branches:	MOODLE_19_STABLE, MOODLE_20_STABLE

Description

« Hide

Please remove the following, "simple" emoticons:
'B)' => 'cool',
':(' => 'sad',

and maybe
':)' => 'smiley',

These smileys come into the way when having Quiz answers in mathematical forms, abbreviations --> (USB) , class-numbers, etc. If someone wants to use them, the longer form could be used.

File: lib/weblib.php, line 1772

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Michael Schneider added a comment - 17/Nov/06 02:49 AM

Discussion is at http://moodle.org/mod/forum/discuss.php?d=58823#267095

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 17/Nov/06 10:13 AM

I've removed the B) which was the only one added in 1.7. The others have been there forever, and removing them now would probably break a lot of smileys in existing texts ...

and

are very common.

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 17/Nov/06 10:16 AM

I'm not closing this myself because this could still be solved, possibly, by making the search/replace smarter.

[ Permalink | « Hide ]

Manish Verma added a comment - 20/Nov/06 11:59 PM

I have 1.7 installation (not the latest one). How can I at least make (B) work?

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 21/Nov/06 11:39 AM

If you lick on the "Version control" tab of this link you can see the patches, direct link:

http://moodle.cvs.sourceforge.net/moodle/moodle/lib/weblib.php?r1=1.674.2.8&r2=1.674.2.9

[ Permalink | « Hide ]

Dan Poltawski added a comment - 16/Dec/07 09:20 PM

This has been resolved by ~~MDL-10915~~ in 1.9+

You can now remove all the emoticons using the setting in Admin > Apperance > Htmleditor > emoticons

[ Permalink | « Hide ]

Stephen Bourget added a comment - 08/Feb/08 05:36 AM

Verified fixed in Moodle 1.9
Closing

[ Permalink | « Hide ]

Nancy Webb added a comment - 15/Mar/09 10:00 AM

I had the same problem when a quiz answer showed a drive letter such as C: inside parentheses. It would look like C smiley face! Luckily for me it was only a couple of questions, so I substituted : for a colon. Just in case my code simply shows as a colon, it is & # 5 8 ;

All content on this web site is made available under the GNU General Public License, unless otherwise stated.