Issue Details (XML | Word | Printable)

Key: MDL-7603
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Petr Skoda
Reporter: Daniele Cordella
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

script 'Language' attribute (simple accessibility w3c issue)

Created: 17/Nov/06 10:34 PM   Updated: 09/Jan/07 12:06 AM
Return to search
Component/s: General
Affects Version/s: 1.6.3
Fix Version/s: 1.8

Issue Links:
Dependency
 

Participants: Daniele Cordella, Nick Freear and Petr Skoda
Security Level: None
Resolved date: 09/Jan/07
Affected Branches: MOODLE_16_STABLE
Fixed Branches: MOODLE_18_STABLE


 Description  « Hide
in course/report/participation/index.php
and in user/index.php
in the code is written <script Language="JavaScript">
instead of
<script language="JavaScript" type="text/javascript">

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Nick Freear committed 2 files to 'Moodle CVS' - 28/Nov/06 06:23 PM
Fixes MDL-7603 <script Language..> should use 'type', user/index.php, course/report/participation/index.php
MODIFY user/index.php   Rev. 1.152    (+2 -2 lines)
MODIFY course/report/participation/index.php   Rev. 1.12    (+2 -2 lines)
[ Permalink | « Hide ]
Nick Freear added a comment - 28/Nov/06 06:33 PM
Hi Daniele, this isn't "Accessibility (to those with disabilities)" per se - just general Standards/ QA. I've fixed those 2 cases, removing the 'language' attribute as this is deprecated, http://www.w3.org/TR/html401/index/attributes.html

There is a wider issue, removing all 'language' attributes in the codebase, to move towards XHTML 1 strict.


Nick Freear made changes - 28/Nov/06 06:33 PM
Field Original Value New Value
Component/s General [ 10049 ]
Component/s Accessibility [ 10083 ]
Fix Version/s 1.8 [ 10130 ]
Nick Freear made changes - 28/Nov/06 06:33 PM
Status Open [ 1 ] In Progress [ 3 ]
[ Permalink | « Hide ]
Daniele Cordella added a comment - 28/Nov/06 06:46 PM
you are right.
What i simportant is to add the -type="text/javascript"-

The list of -language- in moodle 1.7 today is:
course/report/participation/index.php:<script Language="JavaScript">
user/index.php: <script Language="JavaScript">

admin/xmldb/javascript.php: echo '<script language="JavaScript" type="text/javascript" src="' . $wwwfile . '"></script>' . "\n";
admin/xmldb/javascript.php: echo '<script language="JavaScript" type="text/javascript" src="' . $wwwfile . '"></script>' . "\n";
backup/backup_form.html:<script language="JavaScript" type="text/javascript">
backup/restore_form.html:<script language="JavaScript" type="text/javascript">
blocks/course_menu/xtree/xtree.php: echo chr(13).'<script language="javascript">'.chr(13);
blocks/loancalc/block_loancalc.php: <script language="JavaScript">
blog/tags.php: echo '<script language="JavaScript" type="text/javascript">
blog/tags.php: echo '<script language="JavaScript" type="text/javascript">
course/edit.html: <script language="JavaScript">
files/index.php: <script language="javascript" type="text/javascript">
grade/exceptions.html:<script language="JavaScript" type="text/javascript">
grade/exceptions.html:<script language="JavaScript">
install.php: echo '<script language="JavaScript" type="text/javascript" defer="defer">window.onload=toggledbinfo;</script>';
install.php:<script language="JavaScript" type="text/javascript" defer="defer">
lib/ajax/ajaxlib.php: $output .= "<script language='javascript'>\n";
lib/csshover.htc:<script language="JScript">
lib/editor/htmlarea/coursefiles.php: <script language="javscript" type="text/javascript">
lib/editor/htmlarea/htmlarea.class.php: echo '<script language="javascript" type="text/javascript" defer="defer">'."\n";
lib/editor/htmlarea/htmlarea.class.php: echo "\n".'<script language="javascript" type="text/javascript">'."\n";
lib/editor/htmlarea/popups/createanchor.php:<script language="javascript" type="text/javascript" src="popup.js"></script>
lib/editor/htmlarea/popups/createanchor.php:<script language="javascript" type="text/javascript">
lib/editor/htmlarea/popups/dlg_ins_char.php:<script language="javascript" type="text/javascript" src="popup.js"></script>
lib/editor/htmlarea/popups/dlg_ins_char.php:<script language="javascript" type="text/javascript">
lib/editor/htmlarea/popups/dlg_ins_char.php: <script language="javascript" type="text/javascript">
lib/editor/htmlarea/popups/dlg_ins_smile.php:<script language="javascript" type="text/javascript" src="popup.js"></script>
lib/editor/htmlarea/popups/dlg_ins_smile.php:<script language="javascript" type="text/javascript">
lib/editor/htmlarea/popups/insert_image.php:<script language="javascript" type="text/javascript" src="popup.js"></script>
lib/editor/htmlarea/popups/insert_image.php:<script language="javascript" type="text/javascript">
lib/editor/htmlarea/popups/insert_image_std.php:<script language="javascript" type="text/javascript" src="popup.js"></script>
lib/editor/htmlarea/popups/insert_image_std.php:<script language="javascript" type="text/javascript">
lib/editor/htmlarea/popups/insert_table.php:<script language="javascript" type="text/javascript" src="popup.js"></script>
lib/editor/htmlarea/popups/insert_table.php:<script language="javascript" type="text/javascript">
lib/editor/htmlarea/popups/link.php:<script language="javascript" type="text/javascript">
lib/editor/htmlarea/popups/link_std.php: <script language="javascript" type="text/javascript" src="popup.js"></script>
lib/editor/htmlarea/popups/link_std.php: <script language="javascript" type="text/javascript">
lib/editor/htmlarea/popups/searchandreplace.php:<script language="javascript" type="text/javascript" src="popup.js"></script>
lib/editor/htmlarea/popups/searchandreplace.php:<script language="javascript" type="text/javascript">
lib/editor/tinymce/jscripts/tiny_mce/plugins/advimage/image.htm: <script language="javascript" type="text/javascript" src="../../tiny_mce_popup.js"></script>
lib/editor/tinymce/jscripts/tiny_mce/plugins/advimage/image.htm: <script language="javascript" type="text/javascript" src="../../utils/mctabs.js"></script>
lib/editor/tinymce/jscripts/tiny_mce/plugins/advimage/image.htm: <script language="javascript" type="text/javascript" src="../../utils/form_utils.js"></script>
lib/editor/tinymce/jscripts/tiny_mce/plugins/advimage/image.htm: <script language="javascript" type="text/javascript" src="jscripts/functions.js"></script>
lib/editor/tinymce/jscripts/tiny_mce/plugins/fullscreen/fullscreen.htm: <script language="javascript" type="text/javascript" src="../../tiny_mce.js"></script>
lib/editor/tinymce/jscripts/tiny_mce/plugins/fullscreen/fullscreen.htm: <script language="javascript" type="text/javascript">
lib/editor/tinymce/jscripts/tiny_mce/themes/advanced/about.htm: <script language="javascript" type="text/javascript" src="../../tiny_mce_popup.js"></script>
lib/editor/tinymce/jscripts/tiny_mce/themes/advanced/about.htm: <script language="javascript" type="text/javascript" src="../../utils/mctabs.js"></script>
lib/editor/tinymce/jscripts/tiny_mce/themes/advanced/about.htm: <script language="javascript" type="text/javascript" src="jscripts/about.js"></script>
lib/editor/tinymce/jscripts/tiny_mce/themes/advanced/anchor.htm: <script language="javascript" type="text/javascript" src="../../tiny_mce_popup.js"></script>
lib/editor/tinymce/jscripts/tiny_mce/themes/advanced/anchor.htm: <script language="javascript" type="text/javascript" src="jscripts/anchor.js"></script>
lib/editor/tinymce/jscripts/tiny_mce/themes/advanced/charmap.htm: <script language="javascript" type="text/javascript" src="../../tiny_mce_popup.js"></script>
lib/editor/tinymce/jscripts/tiny_mce/themes/advanced/charmap.htm: <script language="javascript" type="text/javascript" src="jscripts/charmap.js"></script>
lib/editor/tinymce/jscripts/tiny_mce/themes/advanced/charmap.htm: <script language="javascript" type="text/javascript">renderCharMapHTML();</script>
lib/editor/tinymce/jscripts/tiny_mce/themes/advanced/color_picker.htm: <script language="javascript" type="text/javascript" src="../../tiny_mce_popup.js"></script>
lib/editor/tinymce/jscripts/tiny_mce/themes/advanced/color_picker.htm: <script language="javascript" type="text/javascript" src="jscripts/color_picker.js"></script>
lib/editor/tinymce/jscripts/tiny_mce/themes/advanced/color_picker.htm: <script language="javascript" type="text/javascript">renderColorMap();</script>
lib/editor/tinymce/jscripts/tiny_mce/themes/advanced/image.htm: <script language="javascript" type="text/javascript" src="../../tiny_mce_popup.js"></script>
lib/editor/tinymce/jscripts/tiny_mce/themes/advanced/image.htm: <script language="javascript" type="text/javascript" src="../../utils/mctabs.js"></script>
lib/editor/tinymce/jscripts/tiny_mce/themes/advanced/image.htm: <script language="javascript" type="text/javascript" src="../../utils/form_utils.js"></script>
lib/editor/tinymce/jscripts/tiny_mce/themes/advanced/image.htm: <script language="javascript" type="text/javascript" src="jscripts/image.js"></script>
lib/editor/tinymce/jscripts/tiny_mce/themes/advanced/image.htm: <script language="javascript">
lib/editor/tinymce/jscripts/tiny_mce/themes/advanced/link.htm: <script language="javascript" type="text/javascript" src="../../tiny_mce_popup.js"></script>
lib/editor/tinymce/jscripts/tiny_mce/themes/advanced/link.htm: <script language="javascript" type="text/javascript" src="../../utils/mctabs.js"></script>
lib/editor/tinymce/jscripts/tiny_mce/themes/advanced/link.htm: <script language="javascript" type="text/javascript" src="../../utils/form_utils.js"></script>
lib/editor/tinymce/jscripts/tiny_mce/themes/advanced/link.htm: <script language="javascript" type="text/javascript" src="jscripts/link.js"></script>
lib/editor/tinymce/jscripts/tiny_mce/themes/advanced/link.htm: <script language="javascript">
lib/editor/tinymce/jscripts/tiny_mce/themes/advanced/link.htm: <script language="javascript">
lib/editor/tinymce/jscripts/tiny_mce/themes/advanced/source_editor.htm: <script language="javascript" type="text/javascript" src="../../tiny_mce_popup.js"></script>
lib/editor/tinymce/jscripts/tiny_mce/themes/advanced/source_editor.htm: <script language="javascript" type="text/javascript" src="jscripts/source_editor.js"></script>
lib/editor/tinymce/jscripts/tiny_mce/themes/advanced/source_editor.htm: <script language="javascript" type="text/javascript">renderWordWrap();</script>
lib/editor/tinymce/tinymce.class.php: echo '<script language="javascript" type="text/javascript">'."\n";
lib/javascript.php: echo '<script language="JavaScript" type="text/javascript" src="'.$CFG->httpswwwroot.'/lib/speller/spellChecker.js"></script>'."\n";
lib/javascript.php: echo '<script language="javascript" type="text/javascript" src="'. $scriptsource .'"></script>'."\n";
lib/javascript.php:<script language="JavaScript" type="text/javascript" src="<?php echo $CFG->httpswwwroot ?>/lib/javascript-static.js"></script>
lib/javascript.php:<script language="JavaScript" type="text/javascript" src="<?php echo $CFG->httpswwwroot ?>/lib/javascript-mod.php"></script>
lib/javascript.php:<script language="JavaScript" type="text/javascript" src="<?php echo $CFG->httpswwwroot ?>/lib/overlib.js"></script>
lib/javascript.php:<script language="JavaScript" type="text/javascript" src="<?php echo $CFG->httpswwwroot ?>/lib/cookies.js"></script>
lib/javascript.php:<script language="JavaScript" type="text/javascript" defer="defer">
lib/moodlelib.php: return '<script language="JavaScript" type="text/javascript">'."\n openpopup('/message/index.php', 'message', 'menubar=0,location=0,scrollbars,status,resizable,width=400,height=500', 0);\n</script>";
lib/soap/nusoap.php: <script language="JavaScript" type="text/javascript">
lib/speller/changes.txt: echo "<script language=\"javascript\" type=\"text/javascript\" defer=\"1\">\n";
lib/speller/server-scripts/spellchecker.php:<script language="javascript" src="<?php echo $word_win_src ?>"></script>
lib/speller/server-scripts/spellchecker.php:<script language="javascript">
lib/weblib.php: preg_match_all('/<script language(.+?)<\/script>/is',$text,$list_of_excludes);
lib/weblib.php: echo '<script language="javascript" type="text/javascript" defer="defer">'."\n";
lib/weblib.php: $str .= "\n".'<script language="javascript" type="text/javascript">'."\n";
message/index.php: echo '<script language="JavaScript" type="text/javascript">'."\n openpopup('/message/index.php', 'message', 'menubar=0,location=0,scrollbars,status,resizable,width=400,height=500', 0);\n</script>";
mod/chat/chatd.php: echo '<script language="JavaScript">';
mod/chat/lib.php:$CHAT_HTMLHEAD_JS = "<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.0 Transitional//EN\" \"http://www.w3.org/TR/REC-html40/loose.dtd\"><html><head><script language=\"JavaScript\">
mod/chat/lib.php:$CHAT_HTMLHEAD_MSGINPUT_JS = "<Unable to render embedded object: File (//www.w3.org/TR/REC-html40/loose.dtd\"><html><head><title>Message Input</title>\n<script language=\"Javascript\">\n<) not found.--\nscroll_active = true;\nfunction empty_field_and_submit()\n{\ndocument.fdummy.arsc_message.value=document.f.arsc_message.value;\ndocument.fdummy.submit();\ndocument.f.arsc_message.focus();\ndocument.f.arsc_message.select();\nreturn false;\n}\n// -->\n</script>\n</head><body bgcolor=\"#FFFFFF\" OnLoad=\"document.f.arsc_message.focus();document.f.arsc_message.select();\">";
mod/feedback/analysis_course.php: echo '<script language="javascript" type="text/javascript">
mod/feedback/edit_item.php: echo '<script language="javascript">';
mod/hotpot/report/fullstat/report.php:<script language="javascript">
mod/hotpot/report/fullstat/report.php:<script language="javascript">
mod/lams/mod.html:<script language="JavaScript" type="text/javascript">
mod/lesson/locallib.php: $meta = "\n<script language=\"javascript\" type=\"text/javascript\">";
mod/lesson/timer.js:// echo "<script language=\"javascript\">\n";
mod/quiz/attempt.php: <script language="javascript" type="text/javascript">
mod/quiz/attempt.php: <script language="javascript" type="text/javascript">
mod/quiz/attempt_close_js.php:<script language="javascript" type="text/javascript">
mod/quiz/jsclock.php:<script language="javascript">
mod/quiz/jstimer.php:<script language="javascript" type="text/javascript">
mod/quiz/jstimer.php:<script language="javascript" type="text/javascript" src="timer.js"></script>
mod/quiz/jstimer.php:<script language="javascript" type="text/javascript">
mod/quiz/mod.html: <script language="javascript" type="text/javascript">
mod/quiz/mod.html:<script language="javascript" type="text/javascript">
mod/quiz/protect_js.php:<script language="JavaScript" type="text/javascript">
mod/quiz/view.php:<script language="javascript" type="text/javascript">
mod/resource/type/file/file.html:<script language="javascript" type="text/javascript">
mod/resource/type/file/file.html:<script language="javascript" type="text/javascript">
mod/resource/type/file/localfile.php: <script language="javascript" type="text/javascript">
mod/resource/type/file/localpath.php: <script language="javascript" type="text/javascript">
mod/resource/type/file/localpath.php: <script language="javascript" type="text/javascript">
mod/resource/type/file/resource.class.php: echo "\n<script language=\"javascript\" type=\"text/javascript\">";
mod/resource/type/html/html.html:<script language="javascript" type="text/javascript">
mod/resource/type/html/html.html:<script language="javascript" type="text/javascript">
mod/resource/type/html/resource.class.php: echo "\n<script language=\"javascript\" type=\"text/javascript\">";
mod/resource/type/ims/ims.html:<script language="javascript" type="text/javascript">
mod/resource/type/ims/ims.html:<script language="javascript" type="text/javascript">
mod/resource/type/ims/ims.html:<script language="javascript" type="text/javascript">
mod/resource/type/ims/javascript.php: echo "<script language=\"JavaScript\" type=\"text/javascript\" src=\"$CFG->wwwroot/mod/resource/type/ims/dummyapi.js\"></script>\n";
mod/resource/type/ims/javascript.php: echo " <script language=\"JavaScript\" type=\"text/javascript\" src=\"$CFG->wwwroot/mod/resource/type/ims/resize.js\"></script>\n";
mod/resource/type/ims/javascript.php: echo " <script language=\"JavaScript\" type=\"text/javascript\">
mod/resource/type/ims/resource.class.php: echo "\n<script language=\"javascript\" type=\"text/javascript\">";
mod/resource/type/repository/hive/makelink.php:<script language="javascript" type="text/javascript">
mod/resource/type/repository/hive/openhive.php: echo '<script language="javascript"/>';
mod/resource/type/repository/repository.html:<script language="javascript" type="text/javascript">
mod/resource/type/repository/repository.html:<script language="javascript" type="text/javascript">
mod/resource/type/repository/resource.class.php: echo "\n<script language=\"javascript\" type=\"text/javascript\">";
mod/resource/type/text/resource.class.php: echo "\n<script language=\"javascript\" type=\"text/javascript\">";
mod/resource/type/text/text.html: <script language="javascript" type="text/javascript">
mod/resource/type/text/text.html:<script language="javascript" type="text/javascript">
mod/scorm/datamodels/aicclib.php: <script language="javascript" type="text/javascript">
mod/scorm/datamodels/scorm_12lib.php: <script language="javascript" type="text/javascript">
mod/scorm/datamodels/scorm_13lib.php: <script language="javascript" type="text/javascript">
mod/scorm/datamodels/sequencinglib.php: //echo "<script language='JavaScript'>";
mod/scorm/datamodels/sequencinglib.php: //echo "<script language='JavaScript'>";
mod/scorm/datamodels/sequencinglib.php: //echo "<script language='JavaScript'>";
mod/scorm/datamodels/sequencinglib.php: //echo "<script language='JavaScript'>";
mod/scorm/datamodels/sequencinglib.php: echo "<script language='JavaScript'>";
mod/scorm/datamodels/sequencinglib.php: echo "<script language='JavaScript'>";
mod/scorm/loadSCO.php: <script language="javascript" type="text/javascript">
mod/scorm/mod.html: <script language="javascript" type="text/javascript">
mod/scorm/player.php: <script language="JavaScript" type="text/javascript" src="request.js"></script>
mod/scorm/player.php: <script language="JavaScript" type="text/javascript" src="api.php?id=<?php echo $cm->id.$scoidstr.$modestr.$attemptstr ?>"></script>
mod/scorm/player.php: echo ' <script language="javascript">var prev="'.$CFG->wwwroot.'/mod/scorm/player.php?id='.$cm->id.$orgstr.$modepop.$scostr."\";</script>\n";
mod/scorm/player.php: echo ' <script language="javascript">var prev="'.$CFG->wwwroot.'/mod/scorm/view.php?id='.$cm->id."\";</script>\n";
mod/scorm/player.php: echo ' <script language="javascript">var next="'.$CFG->wwwroot.'/mod/scorm/player.php?id='.$cm->id.$orgstr.$modepop.$scostr."\";</script>\n";
mod/scorm/player.php: echo ' <script language="javascript">var next="'.$CFG->wwwroot.'/mod/scorm/view.php?id='.$cm->id."\";</script>\n";
mod/wiki/ewiki/ewiki.php:<script language="PHP"> @define("EWIKI_VERSION", "R1.01d");
mod/wiki/ewiki/ewiki.php:<html><head><title>File/Picture Upload</title><script language="JavaScript" type="text/javascript"><!--
mod/wiki/ewiki/fragments/homepage.src: <script language="JavaScript" type="text/javascript">
question/type/calculated/editquestion.html:<script language="javascript" type="text/javascript">
theme/orangewhite/csshover.htc:<script language="JScript">

thanks


[ Permalink | « Hide ]
Daniele Cordella added a comment - 28/Nov/06 06:50 PM
if you want I can attach this list of files without the atribute language inside the tag script.
Is this useful?
Tell me.

Nick Freear made changes - 06/Dec/06 05:22 PM
Summary simple accessibility w3c issue script 'Language' attribute (simple accessibility w3c issue)
Daniele Cordella made changes - 04/Jan/07 07:15 PM
Link This issue will be resolved by MDL-8049 [ MDL-8049 ]
[ Permalink | « Hide ]
Petr Skoda added a comment - 09/Jan/07 12:06 AM
Resolved by MDL-8049, closing now. thanks for the report.

Petr Skoda made changes - 09/Jan/07 12:06 AM
Status In Progress [ 3 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Assignee Nick Freear [ nfreear ] Petr ?koda [ skodak ]

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators