Moodle

Move legacy capabilities down the bottom of the list in a new section to help avoid confusion

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.7
  • Fix Version/s: 1.8, 1.9
  • Component/s: Roles / Access
  • Labels:
    None
  • Environment:
    PHP 5.1.2 MySQL 5.0.27 Windows 2003 IIS
  • Database:
    MySQL
  • URL:
    mitie.edu.au
  • Affected Branches:
    MOODLE_17_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE

Description

Create a new role based on teacher - lets call it instructor. Sign in as this person, my course is not listed - go to the course and I'm asked do I want to enrol - but I'm already enrolled! When you click yes you are now a student of the course (as well as the Instructor) - you have some of the roles of the teacher eg control settings but most are lost (you are in fact mainly a student.

Issue Links

This issue will help resolve:
MDLSITE-133 Improve Roles documentation Minor Resolved
This issue has a non-specific relationship to:
MDL-9013 Improve explanation of legacy roles Major Closed
This issue has been marked as being related by:
MDL-8859 Inconsistent behavior when (a) modifying a legacy role (b) defining a new role inherited from legacy role Minor Closed
MDL-8524 Roles administration improvements - META Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda (skodak) added a comment -

How did you exactly create a new role "based on teacher"?
AFAIK there is no duplication mechanism in 1.7, only in 1.8.

Show
Petr Škoda (skodak) added a comment - How did you exactly create a new role "based on teacher"? AFAIK there is no duplication mechanism in 1.7, only in 1.8.
Hide
Permalink
Ian Scott added a comment -

Signed in as admin - Permissions/define role/add a new role then ticked the box Legacy Role Teacher (editing) - assume from this the new role has all the rights of a legacy teacher. Do I take it I must tick every box a teacher role should have?

Show
Ian Scott added a comment - Signed in as admin - Permissions/define role/add a new role then ticked the box Legacy Role Teacher (editing) - assume from this the new role has all the rights of a legacy teacher. Do I take it I must tick every box a teacher role should have?
Hide
Permalink
Martin Dougiamas added a comment -

Yes you need to tick every box ... this is a documentation problem really ... those legacy capabilities should be moved right down the bottom to a different section.

They're only used by old 3rd party code that was not designed for Moodle 1.7 and doesn't support roles yet. In those cases, Moodle will respond to queries like "get all teachers for this course" by using these legacy capabilities.

Show
Martin Dougiamas added a comment - Yes you need to tick every box ... this is a documentation problem really ... those legacy capabilities should be moved right down the bottom to a different section. They're only used by old 3rd party code that was not designed for Moodle 1.7 and doesn't support roles yet. In those cases, Moodle will respond to queries like "get all teachers for this course" by using these legacy capabilities.
Hide
Permalink
Martin Dougiamas added a comment -

Renaming the bug ...

Show
Martin Dougiamas added a comment - Renaming the bug ...
Hide
Permalink
Helen Foster added a comment -

Notes on legacy capabilities added to http://docs.moodle.org/en/Manage_roles

Also additional notes added to each legacy capability page e.g. http://docs.moodle.org/en/Capabilities/moodle/legacy:editingteacher

Show
Helen Foster added a comment - Notes on legacy capabilities added to http://docs.moodle.org/en/Manage_roles Also additional notes added to each legacy capability page e.g. http://docs.moodle.org/en/Capabilities/moodle/legacy:editingteacher
Hide
Permalink
Helen Foster added a comment -

Adding QA assignee

Show
Helen Foster added a comment - Adding QA assignee
Hide
Permalink
Petr Škoda (skodak) added a comment -

fixed in cvs 1.8dev and HEAD, now the legacy caps have special menu - you can select only one (selecting several of them would cause problems anyway)

thanks for the report!

Show
Petr Škoda (skodak) added a comment - fixed in cvs 1.8dev and HEAD, now the legacy caps have special menu - you can select only one (selecting several of them would cause problems anyway) thanks for the report!
Hide
Permalink
Helen Foster added a comment -

Could the legacy role type drop-down menu have a help pop-up? Perhaps something like this:

"Legacy role types provide backward compatibility. A legacy role type may be set if your site uses old 3rd party code that was not designed for Moodle 1.7 and doesn't yet support roles. Otherwise, it's not necessary to set a legacy role type.

Setting a legacy role type does NOT provide a new role with all capabilities of a pre-Moodle 1.7 role."

Also, could the legacy role type drop-down menu be put at the bottom of the page below the list of capabilities and just above the "Add new role" and Cancel buttons, as it's not so important? Assuming I understand it correctly...

Show
Helen Foster added a comment - Could the legacy role type drop-down menu have a help pop-up? Perhaps something like this: "Legacy role types provide backward compatibility. A legacy role type may be set if your site uses old 3rd party code that was not designed for Moodle 1.7 and doesn't yet support roles. Otherwise, it's not necessary to set a legacy role type. Setting a legacy role type does NOT provide a new role with all capabilities of a pre-Moodle 1.7 role." Also, could the legacy role type drop-down menu be put at the bottom of the page below the list of capabilities and just above the "Add new role" and Cancel buttons, as it's not so important? Assuming I understand it correctly...
Hide
Permalink
Helen Foster added a comment -

Reopening as legacy role types continue to cause confusion. Please see bug MDL-8859

Show
Helen Foster added a comment - Reopening as legacy role types continue to cause confusion. Please see bug MDL-8859
Hide
Permalink
Petr Škoda (skodak) added a comment -

Unfortunately legacy roles are not unimportant yet - a lot of code depends on them

The help popup is a good idea, going to add it

Show
Petr Škoda (skodak) added a comment - Unfortunately legacy roles are not unimportant yet - a lot of code depends on them The help popup is a good idea, going to add it
Hide
Permalink
Petr Škoda (skodak) added a comment -

closing, please use MDL-9013 to propose improvements

thanks everybody for ideas and participation, I agree we should make roles much easier to use

Show
Petr Škoda (skodak) added a comment - closing, please use MDL-9013 to propose improvements thanks everybody for ideas and participation, I agree we should make roles much easier to use
Hide
Permalink
Helen Foster added a comment -

Closing, please see MDL-9013. Thanks again Petr

Show
Helen Foster added a comment - Closing, please see MDL-9013. Thanks again Petr

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.